Changeset 128197 in webkit

Timestamp:

Sep 11, 2012 9:48:14 AM (12 years ago)

Author:

mifenton@rim.com

Message:

[BlackBerry] Colour Dialog popup request should return proper state.
​https://bugs.webkit.org/show_bug.cgi?id=96392

Reviewed by Rob Buis.

Return proper state from openColorPopup dependent on
whether the popup actually opened.

Reviewed Internally by Chris Hutten-Czapski

• WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::openColorPopup):

Location:

trunk/Source/WebKit/blackberry

Files:

• ChangeLog (modified) (1 diff)
• WebKitSupport/InputHandler.cpp (modified) (1 diff)

trunk/Source/WebKit/blackberry/ChangeLog

@@ +1 @@
+2012-09-11  Mike Fenton  <mifenton@rim.com>
+
+        [BlackBerry] Colour Dialog popup request should return proper state.
+        https://bugs.webkit.org/show_bug.cgi?id=96392
+
+        Reviewed by Rob Buis.
+
+        Return proper state from openColorPopup dependent on
+        whether the popup actually opened.
+
+        Reviewed Internally by Chris Hutten-Czapski
+
+        * WebKitSupport/InputHandler.cpp:
+        (BlackBerry::WebKit::InputHandler::openColorPopup):
+
 2012-09-11  Nima Ghanavatian  <nghanavatian@rim.com>
 

trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp

@@ -1002 +1002 @@
     // Check if popup already exists, close it if does.
     m_webPage->m_page->chrome()->client()->closePagePopup(0);
+
     ColorPickerClient* client = new ColorPickerClient(element->value(), m_webPage, element);
-    m_webPage->m_page->chrome()->client()->openPagePopup(client,  WebCore::IntRect());
-    return true;
+    return m_webPage->m_page->chrome()->client()->openPagePopup(client,  WebCore::IntRect());
 }