Changeset 128198 in webkit


Ignore:
Timestamp:
Sep 11, 2012 9:52:01 AM (12 years ago)
Author:
mifenton@rim.com
Message:

[BlackBerry] Suppress keyboard requests while processing spell checking suggestions.
https://bugs.webkit.org/show_bug.cgi?id=96394

Reviewed by Rob Buis.

Suppress the VKB notification when the touch event
is a spell checking request.

PR 192925.

Reviewed Internally by Gen Mak.

  • WebKitSupport/TouchEventHandler.cpp:

(BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):

Location:
trunk/Source/WebKit/blackberry
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebKit/blackberry/ChangeLog

    r128197 r128198  
     12012-09-11  Mike Fenton  <mifenton@rim.com>
     2
     3        [BlackBerry] Suppress keyboard requests while processing spell checking suggestions.
     4        https://bugs.webkit.org/show_bug.cgi?id=96394
     5
     6        Reviewed by Rob Buis.
     7
     8        Suppress the VKB notification when the touch event
     9        is a spell checking request.
     10
     11        PR 192925.
     12
     13        Reviewed Internally by Gen Mak.
     14
     15        * WebKitSupport/TouchEventHandler.cpp:
     16        (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
     17
    1182012-09-11  Mike Fenton  <mifenton@rim.com>
    219
  • trunk/Source/WebKit/blackberry/WebKitSupport/TouchEventHandler.cpp

    r127086 r128198  
    236236            // Apply any suppressed changes. This does not eliminate the need
    237237            // for the show after the handling of fat finger pressed as it may
    238             // have triggered a state change.
    239             m_webPage->m_inputHandler->processPendingKeyboardVisibilityChange();
     238            // have triggered a state change. Leave the change suppressed if
     239            // we are triggering spell check options.
     240            if (!shouldRequestSpellCheckOptions)
     241                m_webPage->m_inputHandler->processPendingKeyboardVisibilityChange();
    240242
    241243            if (shouldSuppressMouseDownOnTouchDown())
Note: See TracChangeset for help on using the changeset viewer.