Changeset 128213 in webkit


Ignore:
Timestamp:
Sep 11, 2012 11:50:13 AM (12 years ago)
Author:
adamk@chromium.org
Message:

Garden-o-matic should ignore a wider variety of warnings in buildbot json
​https://bugs.webkit.org/show_bug.cgi?id=96411

Reviewed by Adam Barth.

Previously only the exact string "warning" was treated as a warning
result. This patch treats any string with "warning" as a substring
as a warning (e.g., "warnings", as seen on the cr-win buildbots).

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:

(.):

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
Location:
trunk/Tools
Files:
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js

    r124635 r128213  
    5757        return step.text.indexOf(kCrashedOrHungOutputMarker) != -1;
    5858    }
    59     return step.results[0] > 0 && step.text.indexOf('warning') == -1;
     59    function isWarning(text) { return text.indexOf('warning') != -1; }
     60    return step.results[0] > 0 && !step.text.some(isWarning);
    6061}
    6162

  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js

    r121301 r128213  
    542542        "statistics": {},
    543543        "step_number": 4,
    544         "text": ["extract_build", "warning"],
     544        "text": ["extract_build", "warnings"],
    545545        "times": [1318366370.94771, 1318366404.552783],
    546546        "urls": {}

  • trunk/Tools/ChangeLog

    r128210 r128213  
     12012-09-11  Adam Klein  <adamk@chromium.org>
     2
     3        Garden-o-matic should ignore a wider variety of warnings in buildbot json
     4        https://bugs.webkit.org/show_bug.cgi?id=96411
     5
     6        Reviewed by Adam Barth.
     7
     8        Previously only the exact string "warning" was treated as a warning
     9        result. This patch treats any string with "warning" as a substring
     10        as a warning (e.g., "warnings", as seen on the cr-win buildbots).
     11
     12        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
     13        (.):
     14        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
     15
    1162012-09-11  Marcelo Lira  <marcelo.lira@openbossa.org>
    217
Note: See TracChangeset for help on using the changeset viewer.