Changeset 128221 in webkit

Timestamp:

Sep 11, 2012 1:34:08 PM (12 years ago)

Author:

zandobersek@gmail.com

Message:

Unreviewed, manually rolling out r128175.
The patch is causing crashes in debug builds.
​http://trac.webkit.org/changeset/128175
​https://bugs.webkit.org/show_bug.cgi?id=96284

Source/WebCore:

• platform/network/soup/ResourceResponseSoup.cpp:

(WebCore::ResourceResponse::updateFromSoupMessage):

LayoutTests:

• http/tests/misc/non-utf8-header-name-expected.txt: Removed.
• http/tests/misc/non-utf8-header-name.php: Removed.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/http/tests/misc/non-utf8-header-name-expected.txt (deleted)
• LayoutTests/http/tests/misc/non-utf8-header-name.php (deleted)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/platform/network/soup/ResourceResponseSoup.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2012-09-11  Zan Dobersek  <zandobersek@gmail.com>
+
+        Unreviewed, manually rolling out r128175.
+        The patch is causing crashes in debug builds.
+        http://trac.webkit.org/changeset/128175
+        https://bugs.webkit.org/show_bug.cgi?id=96284
+
+        * http/tests/misc/non-utf8-header-name-expected.txt: Removed.
+        * http/tests/misc/non-utf8-header-name.php: Removed.
+
 2012-09-11  Adam Klein  <adamk@chromium.org>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-09-11  Zan Dobersek  <zandobersek@gmail.com>
+
+        Unreviewed, manually rolling out r128175.
+        The patch is causing crashes in debug builds.
+        http://trac.webkit.org/changeset/128175
+        https://bugs.webkit.org/show_bug.cgi?id=96284
+
+        * platform/network/soup/ResourceResponseSoup.cpp:
+        (WebCore::ResourceResponse::updateFromSoupMessage):
+
 2012-09-11  James Robinson  <jamesr@chromium.org>
 

trunk/Source/WebCore/platform/network/soup/ResourceResponseSoup.cpp

@@ -70 +70 @@
     soup_message_headers_iter_init(&headersIter, soupMessage->response_headers);
     while (soup_message_headers_iter_next(&headersIter, &headerName, &headerValue))
-        m_httpHeaderFields.set(String::fromUTF8WithLatin1Fallback(headerName, strlen(headerName)),
+        m_httpHeaderFields.set(String::fromUTF8(headerName),
                                String::fromUTF8WithLatin1Fallback(headerValue, strlen(headerValue)));