Changeset 128222 in webkit
- Timestamp:
- Sep 11, 2012 1:36:16 PM (12 years ago)
- Location:
- trunk
- Files:
-
- 2 added
- 3 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r128221 r128222 1 2012-09-11 Kevin Ellis <kevers@chromium.org> 2 3 Crash on a long press gesture when touch adjustment is enabled. 4 https://bugs.webkit.org/show_bug.cgi?id=96313 5 6 Reviewed by Antonio Gomes. 7 8 Add test to ensure that a long-press on a shadow DOM element does 9 not trigger a crash when determining if an element provides a context 10 menu. 11 12 * touchadjustment/context-menu-shadow-node-expected.txt: Added. 13 * touchadjustment/context-menu-shadow-node.html: Added. 14 1 15 2012-09-11 Zan Dobersek <zandobersek@gmail.com> 2 16 -
trunk/Source/WebCore/ChangeLog
r128221 r128222 1 2012-09-11 Kevin Ellis <kevers@chromium.org> 2 3 Crash on a long press gesture when touch adjustment is enabled. 4 https://bugs.webkit.org/show_bug.cgi?id=96313 5 6 Reviewed by Antonio Gomes. 7 8 Fix to ensure that a long-press on a shadow-DOM element does not 9 trigger a crash in TouchAdjustment::providesContextMenuItems. 10 Prior to the patch, a null-pointer exception was trigger because 11 of a null renderer in the check. 12 13 Test: touchadjustment/context-menu-shadow-node.html 14 15 * page/TouchAdjustment.cpp: 16 (WebCore::TouchAdjustment::providesContextMenuItems): 17 1 18 2012-09-11 Zan Dobersek <zandobersek@gmail.com> 2 19 -
trunk/Source/WebCore/page/TouchAdjustment.cpp
r126284 r128222 97 97 // This function tries to match the nodes that receive special context-menu items in 98 98 // ContextMenuController::populate(), and should be kept uptodate with those. 99 ASSERT(node->renderer() || node->isShadowRoot()); 100 if (!node->renderer()) 101 return false; 99 102 if (node->isContentEditable()) 100 103 return true; … … 127 130 static inline void appendBasicSubtargetsForNode(Node* node, SubtargetGeometryList& subtargets) 128 131 { 129 // Since the node is a result of a hit test, we are already ensured it has a renderer.132 // Node guaranteed to have renderer due to check in node filter. 130 133 ASSERT(node->renderer()); 131 134
Note: See TracChangeset
for help on using the changeset viewer.