Changeset 128226 in webkit


Ignore:
Timestamp:
Sep 11, 2012 2:29:59 PM (12 years ago)
Author:
rwlbuis@webkit.org
Message:

[BlackBerry] make pickers/dialogs use appendLiteral
​https://bugs.webkit.org/show_bug.cgi?id=96424

Reviewed by Antonio Gomes.

PR 204032

Other pickers were updated in r128204.

  • WebCoreSupport/ColorPickerClient.cpp:

(WebCore::ColorPickerClient::generateHTML):

  • WebCoreSupport/PagePopupBlackBerry.cpp:

(WebCore::PagePopupBlackBerry::generateHTML):

Location:
trunk/Source/WebKit/blackberry
Files:
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebKit/blackberry/ChangeLog

    r128211 r128226  
     12012-09-11  Rob Buis  <rbuis@rim.com>
     2
     3        [BlackBerry] make pickers/dialogs use appendLiteral
     4        https://bugs.webkit.org/show_bug.cgi?id=96424
     5
     6        Reviewed by Antonio Gomes.
     7
     8        PR 204032
     9
     10        Other pickers were updated in r128204.
     11
     12        * WebCoreSupport/ColorPickerClient.cpp:
     13        (WebCore::ColorPickerClient::generateHTML):
     14        * WebCoreSupport/PagePopupBlackBerry.cpp:
     15        (WebCore::PagePopupBlackBerry::generateHTML):
     16
    1172012-09-11  Konrad Piascik  <kpiascik@rim.com>
    218

  • trunk/Source/WebKit/blackberry/WebCoreSupport/ColorPickerClient.cpp

    r127817 r128226  
    4646{
    4747    StringBuilder source;
    48     source.append("<style>\n");
     48    source.appendLiteral("<style>\n");
    4949    // Include CSS file.
    5050    source.append(popupControlBlackBerryCss,
    5151            sizeof(popupControlBlackBerryCss));
    52     source.append("</style>\n<style>");
     52    source.appendLiteral("</style>\n<style>");
    5353    source.append(colorControlBlackBerryCss,
    5454            sizeof(colorControlBlackBerryCss));
    55     source.append("</style></head><body>\n");
    56     source.append("<script>\n");
    57     source.append("window.addEventListener('load', function () {");
    58     source.append("window.popupcontrol.show(");
     55    source.appendLiteral("</style></head><body>\n");
     56    source.appendLiteral("<script>\n");
     57    source.appendLiteral("window.addEventListener('load', function () {");
     58    source.appendLiteral("window.popupcontrol.show(");
    5959    if (!value.isEmpty())
    6060        source.append("\"" + String(value.impl()) + "\"); \n }); \n");
    6161    else
    62         source.append("); \n }); \n");
     62        source.appendLiteral("); \n }); \n");
    6363    source.append(colorControlBlackBerryJs, sizeof(colorControlBlackBerryJs));
    64     source.append("</script>\n");
    65     source.append("</body> </html>\n");
     64    source.appendLiteral("</script>\n");
     65    source.appendLiteral("</body> </html>\n");
    6666    m_source = source.toString();
    6767}

  • trunk/Source/WebKit/blackberry/WebCoreSupport/PagePopupBlackBerry.cpp

    r127191 r128226  
    8282    // FIXME: the hardcoding padding will be removed soon.
    8383    int screenWidth = webpage->d->screenSize().width() - PADDING;
    84     source.append("<html><head><meta http-equiv=\"Content-Type\" content=\"text/html; charset=UTF-8\"/>\n");
     84    source.appendLiteral("<html><head><meta http-equiv=\"Content-Type\" content=\"text/html; charset=UTF-8\"/>\n");
    8585    source.append("<meta name=\"viewport\" content=\"width=" + String::number(screenWidth));
    86     source.append("; user-scalable=no\" />\n");
     86    source.appendLiteral("; user-scalable=no\" />\n");
    8787    writer->addData(source.toString().utf8().data(), source.toString().utf8().length());
    8888
Note: See TracChangeset for help on using the changeset viewer.