Changeset 128321 in webkit

Timestamp:

Sep 12, 2012 9:06:55 AM (12 years ago)

Author:

zandobersek@gmail.com

Message:

Flakiness dashboard doesn't recognize new Chromium Android test builder
​https://bugs.webkit.org/show_bug.cgi?id=96523

Reviewed by Ojan Vafai.

Properly return 'ANDROID' as the Chromium platform for Android builders.

• TestResultServer/static-dashboards/flakiness_dashboard.js:

(chromiumPlatform):

• TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:

(test):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• TestResultServer/static-dashboards/flakiness_dashboard.js (modified) (2 diffs)
• TestResultServer/static-dashboards/flakiness_dashboard_unittests.js (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2012-09-12  Zan Dobersek  <zandobersek@gmail.com>
+
+        Flakiness dashboard doesn't recognize new Chromium Android test builder
+        https://bugs.webkit.org/show_bug.cgi?id=96523
+
+        Reviewed by Ojan Vafai.
+
+        Properly return 'ANDROID' as the Chromium platform for Android builders.
+
+        * TestResultServer/static-dashboards/flakiness_dashboard.js:
+        (chromiumPlatform):
+        * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
+        (test):
+
 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
 

trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.js

@@ -41 +41 @@
 // FIXME: These platform names should probably be changed to match the directories in LayoutTests/platform
 // instead of matching the values we use in the TestExpectations file.
-var PLATFORMS = ['LION', 'SNOWLEOPARD', 'XP', 'VISTA', 'WIN7', 'LUCID', 'APPLE_LION', 'APPLE_SNOWLEOPARD', 'APPLE_XP', 'APPLE_WIN7', 'GTK_LINUX', 'QT_LINUX', 'EFL'];
+var PLATFORMS = ['LION', 'SNOWLEOPARD', 'XP', 'VISTA', 'WIN7', 'LUCID', 'ANDROID', 'APPLE_LION', 'APPLE_SNOWLEOPARD', 'APPLE_XP', 'APPLE_WIN7', 'GTK_LINUX', 'QT_LINUX', 'EFL'];
 var PLATFORM_UNIONS = {
     'MAC': ['SNOWLEOPARD', 'LION'],
@@ -286 +286 @@
     if (stringContains(builderNameUpperCase, 'LINUX'))
         return 'LUCID';
+    if (stringContains(builderNameUpperCase, 'ANDROID'))
+        return 'ANDROID';
     // The interactive bot is XP, but doesn't have an OS in it's name.
     if (stringContains(builderNameUpperCase, 'INTERACTIVE'))

trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard_unittests.js

@@ -191 +191 @@
 });
 
-test('allTestsWithSamePlatformAndBuildType', 13, function() {
+test('allTestsWithSamePlatformAndBuildType', 14, function() {
     // FIXME: test that allTestsWithSamePlatformAndBuildType actually returns the right set of tests.
     for (var i = 0; i < PLATFORMS.length; i++)