Changeset 128403 in webkit


Ignore:
Timestamp:
Sep 12, 2012 10:09:58 PM (12 years ago)
Author:
commit-queue@webkit.org
Message:

Unreviewed, rolling out r127876.
​http://trac.webkit.org/changeset/127876
​https://bugs.webkit.org/show_bug.cgi?id=96600

mouse click doesn't work for spin button if spin button in
iframe (Requested by yosin on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-09-12

.:

  • Source/autotools/symbols.filter:

Source/WebCore:

  • WebCore.exp.in:
  • WebCore.order:
  • dom/Document.cpp:

(WebCore::Document::nodesFromRect):

  • dom/Document.h:

(Document):

  • page/ContextMenuController.cpp:

(WebCore::ContextMenuController::createContextMenu):

  • page/DragController.cpp:

(WebCore::DragController::canProcessDrag):
(WebCore::DragController::startDrag):

  • page/EventHandler.cpp:

(WebCore::EventHandler::updateAutoscrollRenderer):
(WebCore::EventHandler::hitTestResultAtPoint):
(WebCore::EventHandler::handleMousePressEvent):
(WebCore::EventHandler::handleGestureEvent):
(WebCore::EventHandler::bestClickableNodeForTouchPoint):
(WebCore::EventHandler::bestContextMenuNodeForTouchPoint):
(WebCore::EventHandler::bestZoomableAreaForTouchPoint):
(WebCore::EventHandler::handleTouchEvent):

  • page/EventHandler.h:

(EventHandler):

  • page/FocusController.cpp:

(WebCore::updateFocusCandidateIfNeeded):

  • page/Frame.cpp:

(WebCore::Frame::visiblePositionForPoint):
(WebCore::Frame::documentAtPoint):

  • page/TouchDisambiguation.cpp:

(WebCore::findGoodTouchTargets):

  • rendering/HitTestRequest.h:
  • testing/Internals.cpp:

(WebCore::Internals::nodesFromRect):

Source/WebKit/blackberry:

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::contextNode):
(BlackBerry::WebKit::WebPagePrivate::nodeForZoomUnderPoint):
(BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):
(BlackBerry::WebKit::WebPage::nodeAtPoint):

  • WebKitSupport/FatFingers.cpp:

(BlackBerry::WebKit::FatFingers::getNodesFromRect):
(BlackBerry::WebKit::FatFingers::getRelevantInfoFromPoint):

  • WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::visiblePositionForPointIgnoringClipping):

Source/WebKit/chromium:

  • src/ContextMenuClientImpl.cpp:

(WebKit::selectMisspelledWord):

  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::dispatchDecidePolicyForNavigationAction):

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::characterIndexForPoint):

  • src/WebPluginContainerImpl.cpp:

(WebKit::WebPluginContainerImpl::isRectTopmost):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::handleMouseUp):
(WebKit::WebViewImpl::computeBlockBounds):

Source/WebKit/efl:

  • ewk/ewk_frame.cpp:

(ewk_frame_hit_test_new):

Source/WebKit/mac:

  • WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::actionDictionary):

  • WebView/WebHTMLView.mm:

(-[WebHTMLView elementAtPoint:allowShadowContent:]):

Source/WebKit/qt:

  • Api/qwebframe.cpp:

(QWebFrame::hitTestContent):

  • Api/qwebpage.cpp:

(QWebPagePrivate::handleSoftwareInputPanel):
(QWebPagePrivate::TouchAdjuster::findCandidatePointForTouch):
(QWebPage::updatePositionDependentActions):

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNavigationAction):

Source/WebKit/win:

  • WebActionPropertyBag.cpp:

(WebActionPropertyBag::Read):

  • WebView.cpp:

(WebView::handleContextMenuEvent):
(WebView::elementAtPoint):

Source/WebKit/wx:

  • WebFrame.cpp:

(WebKit::WebFrame::HitTest):

Source/WebKit2:

  • WebProcess/InjectedBundle/InjectedBundleNavigationAction.cpp:

(WebKit::InjectedBundleNavigationAction::InjectedBundleNavigationAction):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::handleContextMenuEvent):
(WebKit::WebPage::highlightPotentialActivation):
(WebKit::WebPage::findZoomableAreaForPoint):

  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::characterIndexForPoint):
(WebKit::WebPage::performDictionaryLookupAtLocation):
(WebKit::WebPage::shouldDelayWindowOrderingEvent):
(WebKit::WebPage::acceptsFirstMouse):

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:
Location:
trunk
Files:
46 edited

Legend:

Unmodified
Added
Removed

  • trunk/ChangeLog

    r128393 r128403  
     12012-09-12  Sheriff Bot  <webkit.review.bot@gmail.com>
     2
     3        Unreviewed, rolling out r127876.
     4        http://trac.webkit.org/changeset/127876
     5        https://bugs.webkit.org/show_bug.cgi?id=96600
     6
     7        mouse click doesn't work for spin button if spin button in
     8        iframe (Requested by yosin on #webkit).
     9
     10        * Source/autotools/symbols.filter:
     11
    1122012-09-12  KyungTae Kim  <ktf.kim@samsung.com>
    213

  • trunk/Source/WebCore/ChangeLog

    r128400 r128403  
     12012-09-12  Sheriff Bot  <webkit.review.bot@gmail.com>
     2
     3        Unreviewed, rolling out r127876.
     4        http://trac.webkit.org/changeset/127876
     5        https://bugs.webkit.org/show_bug.cgi?id=96600
     6
     7        mouse click doesn't work for spin button if spin button in
     8        iframe (Requested by yosin on #webkit).
     9
     10        * WebCore.exp.in:
     11        * WebCore.order:
     12        * dom/Document.cpp:
     13        (WebCore::Document::nodesFromRect):
     14        * dom/Document.h:
     15        (Document):
     16        * page/ContextMenuController.cpp:
     17        (WebCore::ContextMenuController::createContextMenu):
     18        * page/DragController.cpp:
     19        (WebCore::DragController::canProcessDrag):
     20        (WebCore::DragController::startDrag):
     21        * page/EventHandler.cpp:
     22        (WebCore::EventHandler::updateAutoscrollRenderer):
     23        (WebCore::EventHandler::hitTestResultAtPoint):
     24        (WebCore::EventHandler::handleMousePressEvent):
     25        (WebCore::EventHandler::handleGestureEvent):
     26        (WebCore::EventHandler::bestClickableNodeForTouchPoint):
     27        (WebCore::EventHandler::bestContextMenuNodeForTouchPoint):
     28        (WebCore::EventHandler::bestZoomableAreaForTouchPoint):
     29        (WebCore::EventHandler::handleTouchEvent):
     30        * page/EventHandler.h:
     31        (EventHandler):
     32        * page/FocusController.cpp:
     33        (WebCore::updateFocusCandidateIfNeeded):
     34        * page/Frame.cpp:
     35        (WebCore::Frame::visiblePositionForPoint):
     36        (WebCore::Frame::documentAtPoint):
     37        * page/TouchDisambiguation.cpp:
     38        (WebCore::findGoodTouchTargets):
     39        * rendering/HitTestRequest.h:
     40        * testing/Internals.cpp:
     41        (WebCore::Internals::nodesFromRect):
     42
    1432012-09-09  Filip Pizlo  <fpizlo@apple.com>
    244

  • trunk/Source/WebCore/WebCore.exp.in

    r128239 r128403  
    159159__ZN7WebCore12EventHandler16handleWheelEventERKNS_18PlatformWheelEventE
    160160__ZN7WebCore12EventHandler17scrollRecursivelyENS_15ScrollDirectionENS_17ScrollGranularityEPNS_4NodeE
    161 __ZN7WebCore12EventHandler20hitTestResultAtPointERKNS_21FractionalLayoutPointEjRKNS_20FractionalLayoutSizeE
     161__ZN7WebCore12EventHandler20hitTestResultAtPointERKNS_21FractionalLayoutPointEbbNS_17HitTestScrollbarsEjRKNS_20FractionalLayoutSizeE
    162162__ZN7WebCore12EventHandler21handleMousePressEventERKNS_18PlatformMouseEventE
    163163__ZN7WebCore12EventHandler23handleMouseReleaseEventERKNS_18PlatformMouseEventE
    … …  
    13581358__ZNK7WebCore8Document11completeURLERKN3WTF6StringE
    13591359__ZNK7WebCore8Document13axObjectCacheEv
    1360 __ZNK7WebCore8Document13nodesFromRectEiijjjjj
     1360__ZNK7WebCore8Document13nodesFromRectEiijjjjbbb
    13611361__ZNK7WebCore8Document14getElementByIdERKN3WTF12AtomicStringE
    13621362__ZNK7WebCore8Document31displayStringModifiedByEncodingERKN3WTF6StringE

  • trunk/Source/WebCore/WebCore.order

    r127876 r128403  
    2278622786__ZNK7WebCore4Node20traversePreviousNodeEPKS0_
    2278722787__ZN7WebCore37jsNodeIteratorPrototypeFunctionDetachEPN3JSC9ExecStateE
    22788 __ZNK7WebCore8Document13nodesFromRectEiijjjjj
     22788__ZNK7WebCore8Document13nodesFromRectEiijjjjbbb
    2278922789__ZNK7WebCore8Document17handleZeroPaddingERKNS_14HitTestRequestERNS_13HitTestResultE
    2279022790__ZN3WTF21ListHashSetTranslatorINS_6RefPtrIN7WebCore4NodeEEELm256ENS_7PtrHashIS4_EEE9translateERPNS_15ListHashSetNodeIS4_Lm256EEERKS4_PNS_24ListHashSetNodeAllocatorIS4_Lm256EEE

  • trunk/Source/WebCore/dom/Document.cpp

    r127956 r128403  
    13851385// * making it receive the expading size of each direction separately,
    13861386//   i.e. nodesFromRect(x, y, topSize, rightSize, bottomSize, leftSize);
    1387 PassRefPtr<NodeList> Document::nodesFromRect(int centerX, int centerY, unsigned topPadding, unsigned rightPadding, unsigned bottomPadding, unsigned leftPadding, HitTestRequest::HitTestRequestType hitType) const
     1387PassRefPtr<NodeList> Document::nodesFromRect(int centerX, int centerY, unsigned topPadding, unsigned rightPadding, unsigned bottomPadding, unsigned leftPadding, bool ignoreClipping, bool allowShadowContent, bool allowChildFrameContent) const
    13881388{
    13891389    // FIXME: Share code between this, elementFromPoint and caretRangeFromPoint.
    … …  
    14001400    LayoutPoint point = roundedLayoutPoint(FloatPoint(centerX * zoomFactor + view()->scrollX(), centerY * zoomFactor + view()->scrollY()));
    14011401
    1402     HitTestRequest request(hitType);
     1402    int type = HitTestRequest::ReadOnly | HitTestRequest::Active;
    14031403
    14041404    // When ignoreClipping is false, this method returns null for coordinates outside of the viewport.
    1405     if (!request.ignoreClipping() && !frameView->visibleContentRect().intersects(HitTestResult::rectForPoint(point, topPadding, rightPadding, bottomPadding, leftPadding)))
     1405    if (ignoreClipping)
     1406        type |= HitTestRequest::IgnoreClipping;
     1407    else if (!frameView->visibleContentRect().intersects(HitTestResult::rectForPoint(point, topPadding, rightPadding, bottomPadding, leftPadding)))
    14061408        return 0;
     1409    if (allowShadowContent)
     1410        type |= HitTestRequest::AllowShadowContent;
     1411    if (allowChildFrameContent)
     1412        type |= HitTestRequest::AllowChildFrameContent;
     1413
     1414    HitTestRequest request(type);
    14071415
    14081416    // Passing a zero padding will trigger a rect hit test, however for the purposes of nodesFromRect,

  • trunk/Source/WebCore/dom/Document.h

    r127932 r128403  
    3535#include "DocumentEventQueue.h"
    3636#include "DocumentTiming.h"
    37 #include "HitTestRequest.h"
    3837#include "IconURL.h"
    3938#include "InspectorCounters.h"
    … …  
    378377     * @param bottomPadding How much to expand the bottom of the rectangle
    379378     * @param leftPadding How much to expand the left of the rectangle
     379     * @param ignoreClipping whether or not to ignore the root scroll frame when retrieving the element.
     380     *        If false, this method returns null for coordinates outside of the viewport.
    380381     */
    381382    PassRefPtr<NodeList> nodesFromRect(int centerX, int centerY,
    382383                                       unsigned topPadding, unsigned rightPadding, unsigned bottomPadding, unsigned leftPadding,
    383                                        HitTestRequest::HitTestRequestType hitType = HitTestRequest::ReadOnly | HitTestRequest::Active) const;
     384                                       bool ignoreClipping, bool allowShadowContent, bool allowChildFrameContent = false) const;
    384385    Element* elementFromPoint(int x, int y) const;
    385386    PassRefPtr<Range> caretRangeFromPoint(int x, int y);

  • trunk/Source/WebCore/page/ContextMenuController.cpp

    r127876 r128403  
    150150
    151151    if (Frame* frame = event->target()->toNode()->document()->frame())
    152         result = frame->eventHandler()->hitTestResultAtPoint(mouseEvent->absoluteLocation());
     152        result = frame->eventHandler()->hitTestResultAtPoint(mouseEvent->absoluteLocation(), false);
    153153
    154154    if (!result.innerNonSharedNode())

  • trunk/Source/WebCore/page/DragController.cpp

    r127876 r128403  
    545545        return false;
    546546
    547     result = m_page->mainFrame()->eventHandler()->hitTestResultAtPoint(point, HitTestRequest::ReadOnly | HitTestRequest::Active | HitTestRequest::AllowShadowContent);
     547    result = m_page->mainFrame()->eventHandler()->hitTestResultAtPoint(point, true);
    548548
    549549    if (!result.innerNonSharedNode())
    … …  
    727727        return false;
    728728
    729     HitTestResult hitTestResult = src->eventHandler()->hitTestResultAtPoint(dragOrigin, HitTestRequest::ReadOnly | HitTestRequest::Active | HitTestRequest::AllowShadowContent);
     729    HitTestResult hitTestResult = src->eventHandler()->hitTestResultAtPoint(dragOrigin, true);
    730730    if (!state.m_dragSrc->contains(hitTestResult.innerNode()))
    731731        // The original node being dragged isn't under the drag origin anymore... maybe it was

  • trunk/Source/WebCore/page/EventHandler.cpp

    r127876 r128403  
    10081008        return;
    10091009
    1010     HitTestResult hitTest = hitTestResultAtPoint(m_panScrollStartPos, HitTestRequest::ReadOnly | HitTestRequest::Active | HitTestRequest::AllowShadowContent);
     1010    HitTestResult hitTest = hitTestResultAtPoint(m_panScrollStartPos, true);
    10111011
    10121012    if (Node* nodeAtPoint = hitTest.innerNode())
    … …  
    10401040#endif // ENABLE(DRAG_SUPPORT)
    10411041   
    1042 HitTestResult EventHandler::hitTestResultAtPoint(const LayoutPoint& point, HitTestRequest::HitTestRequestType hitType, const LayoutSize& padding)
     1042HitTestResult EventHandler::hitTestResultAtPoint(const LayoutPoint& point, bool allowShadowContent, bool ignoreClipping, HitTestScrollbars testScrollbars, HitTestRequest::HitTestRequestType hitType, const LayoutSize& padding)
    10431043{
    10441044    HitTestResult result(point, padding.height(), padding.width(), padding.height(), padding.width());
    … …  
    10461046    if (!m_frame->contentRenderer())
    10471047        return result;
     1048    if (ignoreClipping)
     1049        hitType |= HitTestRequest::IgnoreClipping;
     1050    if (allowShadowContent)
     1051        hitType |= HitTestRequest::AllowShadowContent;
     1052    if (testScrollbars == ShouldHitTestScrollbars)
     1053        hitType |= HitTestRequest::TestChildFrameScrollBars;
    10481054    // We always need to handle child frame content.
    10491055    hitType |= HitTestRequest::AllowChildFrameContent;
    10501056
    1051     HitTestRequest request(hitType);
    1052     m_frame->contentRenderer()->hitTest(request, result);
     1057    m_frame->contentRenderer()->hitTest(HitTestRequest(hitType), result);
    10531058
    10541059    // If our HitTestResult is not visible, then we started hit testing too far down the frame chain.
    … …  
    10621067            if (resultView && mainView) {
    10631068                IntPoint mainFramePoint = mainView->rootViewToContents(resultView->contentsToRootView(roundedIntPoint(result.point())));
    1064                 result = mainFrame->eventHandler()->hitTestResultAtPoint(mainFramePoint, hitType, padding);
     1069                result = mainFrame->eventHandler()->hitTestResultAtPoint(mainFramePoint, allowShadowContent, ignoreClipping, testScrollbars, hitType, padding);
    10651070            }
    10661071        }
    10671072    }
    10681073
    1069     if (!request.allowsShadowContent())
     1074    if (!allowShadowContent)
    10701075        result.setToNonShadowAncestor();
    10711076
    … …  
    14771482
    14781483    HitTestRequest request(HitTestRequest::Active);
    1479     // Save the document point we generate in case the window coordinate is invalidated by what happens
     1484    // Save the document point we generate in case the window coordinate is invalidated by what happens 
    14801485    // when we dispatch the event.
    14811486    LayoutPoint documentPoint = documentPointForWindowPoint(m_frame, mouseEvent.position());
    … …  
    23772382
    23782383    if (!eventTarget) {
    2379         HitTestResult result = hitTestResultAtPoint(gestureEvent.position());
     2384        HitTestResult result = hitTestResultAtPoint(gestureEvent.position(), false, false, DontHitTestScrollbars, HitTestRequest::ReadOnly | HitTestRequest::Active);
    23802385        eventTarget = result.targetNode();
    23812386    }
    … …  
    24792484bool EventHandler::bestClickableNodeForTouchPoint(const IntPoint& touchCenter, const IntSize& touchRadius, IntPoint& targetPoint, Node*& targetNode)
    24802485{
     2486    HitTestRequest::HitTestRequestType hitType = HitTestRequest::ReadOnly | HitTestRequest::Active;
    24812487    IntPoint hitTestPoint = m_frame->view()->windowToContents(touchCenter);
    2482     HitTestResult result = hitTestResultAtPoint(hitTestPoint, HitTestRequest::ReadOnly | HitTestRequest::Active | HitTestRequest::AllowShadowContent, touchRadius);
     2488    HitTestResult result = hitTestResultAtPoint(hitTestPoint, /*allowShadowContent*/ true, /*ignoreClipping*/ false, DontHitTestScrollbars, hitType, touchRadius);
    24832489
    24842490    IntRect touchRect(touchCenter - touchRadius, touchRadius + touchRadius);
    … …  
    24972503bool EventHandler::bestContextMenuNodeForTouchPoint(const IntPoint& touchCenter, const IntSize& touchRadius, IntPoint& targetPoint, Node*& targetNode)
    24982504{
     2505    HitTestRequest::HitTestRequestType hitType = HitTestRequest::ReadOnly | HitTestRequest::Active;
    24992506    IntPoint hitTestPoint = m_frame->view()->windowToContents(touchCenter);
    2500     HitTestResult result = hitTestResultAtPoint(hitTestPoint, HitTestRequest::ReadOnly | HitTestRequest::Active | HitTestRequest::AllowShadowContent, touchRadius);
     2507    HitTestResult result = hitTestResultAtPoint(hitTestPoint, /*allowShadowContent*/ true, /*ignoreClipping*/ false, DontHitTestScrollbars, hitType, touchRadius);
    25012508
    25022509    IntRect touchRect(touchCenter - touchRadius, touchRadius + touchRadius);
    … …  
    25072514bool EventHandler::bestZoomableAreaForTouchPoint(const IntPoint& touchCenter, const IntSize& touchRadius, IntRect& targetArea, Node*& targetNode)
    25082515{
     2516    HitTestRequest::HitTestRequestType hitType = HitTestRequest::ReadOnly | HitTestRequest::Active;
    25092517    IntPoint hitTestPoint = m_frame->view()->windowToContents(touchCenter);
    2510     HitTestResult result = hitTestResultAtPoint(hitTestPoint, HitTestRequest::ReadOnly | HitTestRequest::Active, touchRadius);
     2518    HitTestResult result = hitTestResultAtPoint(hitTestPoint, /*allowShadowContent*/ false, /*ignoreClipping*/ false, DontHitTestScrollbars, hitType, touchRadius);
    25112519
    25122520    IntRect touchRect(touchCenter - touchRadius, touchRadius + touchRadius);
    … …  
    35503558        RefPtr<EventTarget> touchTarget;
    35513559        if (pointState == PlatformTouchPoint::TouchPressed) {
    3552             HitTestResult result = hitTestResultAtPoint(pagePoint, hitType);
     3560            HitTestResult result = hitTestResultAtPoint(pagePoint, /*allowShadowContent*/ false, false, DontHitTestScrollbars, hitType);
    35533561            Node* node = result.innerNode();
    35543562            ASSERT(node);
    … …  
    35683576        } else if (pointState == PlatformTouchPoint::TouchReleased || pointState == PlatformTouchPoint::TouchCancelled) {
    35693577            // We only perform a hittest on release or cancel to unset :active or :hover state.
    3570             hitTestResultAtPoint(pagePoint, hitType);
     3578            hitTestResultAtPoint(pagePoint, /*allowShadowContent*/ false, false, DontHitTestScrollbars, hitType);
    35713579            // The target should be the original target for this touch, so get it from the hashmap. As it's a release or cancel
    35723580            // we also remove it from the map.

  • trunk/Source/WebCore/page/EventHandler.h

    r127876 r128403  
    8989#endif // ENABLE(DRAG_SUPPORT)
    9090
     91enum HitTestScrollbars { ShouldHitTestScrollbars, DontHitTestScrollbars };
     92
    9193class EventHandler {
    9294    WTF_MAKE_NONCOPYABLE(EventHandler);
    … …  
    114116    void dispatchFakeMouseMoveEventSoonInQuad(const FloatQuad&);
    115117
    116     HitTestResult hitTestResultAtPoint(const LayoutPoint&, HitTestRequest::HitTestRequestType hitType = HitTestRequest::ReadOnly | HitTestRequest::Active,
     118    HitTestResult hitTestResultAtPoint(const LayoutPoint&, bool allowShadowContent, bool ignoreClipping = false,
     119                                       HitTestScrollbars scrollbars = DontHitTestScrollbars,
     120                                       HitTestRequest::HitTestRequestType hitType = HitTestRequest::ReadOnly | HitTestRequest::Active,
    117121                                       const LayoutSize& padding = LayoutSize());
    118122

  • trunk/Source/WebCore/page/FocusController.cpp

    r128134 r128403  
    746746        LayoutUnit x = intersectionRect.x() + intersectionRect.width() / 2;
    747747        LayoutUnit y = intersectionRect.y() + intersectionRect.height() / 2;
    748         HitTestResult result = candidate.visibleNode->document()->page()->mainFrame()->eventHandler()->hitTestResultAtPoint(IntPoint(x, y), HitTestRequest::ReadOnly | HitTestRequest::Active | HitTestRequest::IgnoreClipping);
     748        HitTestResult result = candidate.visibleNode->document()->page()->mainFrame()->eventHandler()->hitTestResultAtPoint(IntPoint(x, y), false, true);
    749749        if (candidate.visibleNode->contains(result.innerNode())) {
    750750            closest = candidate;

  • trunk/Source/WebCore/page/Frame.cpp

    r127876 r128403  
    725725VisiblePosition Frame::visiblePositionForPoint(const IntPoint& framePoint)
    726726{
    727     HitTestResult result = eventHandler()->hitTestResultAtPoint(framePoint, HitTestRequest::ReadOnly | HitTestRequest::Active | HitTestRequest::AllowShadowContent);
     727    HitTestResult result = eventHandler()->hitTestResultAtPoint(framePoint, true);
    728728    Node* node = result.innerNonSharedNode();
    729729    if (!node)
    … …  
    747747
    748748    if (contentRenderer())
    749         result = eventHandler()->hitTestResultAtPoint(pt);
     749        result = eventHandler()->hitTestResultAtPoint(pt, false);
    750750    return result.innerNode() ? result.innerNode()->document() : 0;
    751751}

  • trunk/Source/WebCore/page/TouchDisambiguation.cpp

    r128006 r128403  
    9797    IntPoint contentsPoint = mainFrame->view()->windowToContents(touchPoint);
    9898
    99     HitTestResult result = mainFrame->eventHandler()->hitTestResultAtPoint(contentsPoint, HitTestRequest::ReadOnly | HitTestRequest::Active, IntSize(padding, padding));
     99    HitTestResult result = mainFrame->eventHandler()->hitTestResultAtPoint(contentsPoint, false, false, DontHitTestScrollbars, HitTestRequest::Active | HitTestRequest::ReadOnly, IntSize(padding, padding));
    100100    const ListHashSet<RefPtr<Node> >& hitResults = result.rectBasedTestResult();
    101101

  • trunk/Source/WebCore/rendering/HitTestRequest.h

    r127876 r128403  
    3838        AllowShadowContent = 1 << 8,
    3939        AllowChildFrameContent = 1 << 9,
    40         // FIXME: Get rid of the two options below if possible.
    4140        ChildFrameHitTest = 1 << 10,
    4241        TestChildFrameScrollBars = 1 << 11

  • trunk/Source/WebCore/testing/Internals.cpp

    r127876 r128403  
    973973        return 0;
    974974    }
    975     HitTestRequest::HitTestRequestType hitType = HitTestRequest::ReadOnly | HitTestRequest::Active;
    976     if (ignoreClipping)
    977         hitType |= HitTestRequest::IgnoreClipping;
    978     if (allowShadowContent)
    979         hitType |= HitTestRequest::AllowShadowContent;
    980     if (allowChildFrameContent)
    981         hitType |= HitTestRequest::AllowChildFrameContent;
    982 
    983     return document->nodesFromRect(x, y, topPadding, rightPadding, bottomPadding, leftPadding, hitType);
     975
     976    return document->nodesFromRect(x, y, topPadding, rightPadding, bottomPadding, leftPadding, ignoreClipping, allowShadowContent, allowChildFrameContent);
    984977}
    985978

  • trunk/Source/WebKit/blackberry/Api/WebPage.cpp

    r128200 r128403  
    27672767    }
    27682768
    2769     HitTestResult result = eventHandler->hitTestResultAtPoint(contentPos);
     2769    HitTestResult result = eventHandler->hitTestResultAtPoint(contentPos, false /*allowShadowContent*/);
    27702770    return result.innerNode();
    27712771}
    … …  
    28392839        return 0;
    28402840
    2841     HitTestResult result = m_mainFrame->eventHandler()->hitTestResultAtPoint(mapFromTransformed(point));
     2841    HitTestResult result = m_mainFrame->eventHandler()->hitTestResultAtPoint(mapFromTransformed(point), false);
    28422842
    28432843    Node* node = result.innerNonSharedNode();
    … …  
    40494049
    40504050    if (!node) {
    4051         HitTestResult result = eventHandler->hitTestResultAtPoint(mapFromViewportToContents(mouseEvent.position()));
     4051        HitTestResult result = eventHandler->hitTestResultAtPoint(mapFromViewportToContents(mouseEvent.position()), false /*allowShadowContent*/);
    40524052        node = result.innerNode();
    40534053    }
    … …  
    52125212WebDOMNode WebPage::nodeAtPoint(int x, int y)
    52135213{
    5214     HitTestResult result = d->m_mainFrame->eventHandler()->hitTestResultAtPoint(d->mapFromTransformed(IntPoint(x, y)));
     5214    HitTestResult result = d->m_mainFrame->eventHandler()->hitTestResultAtPoint(d->mapFromTransformed(IntPoint(x, y)), false);
    52155215    Node* node = result.innerNonSharedNode();
    52165216    return WebDOMNode(node);

  • trunk/Source/WebKit/blackberry/ChangeLog

    r128347 r128403  
     12012-09-12  Sheriff Bot  <webkit.review.bot@gmail.com>
     2
     3        Unreviewed, rolling out r127876.
     4        http://trac.webkit.org/changeset/127876
     5        https://bugs.webkit.org/show_bug.cgi?id=96600
     6
     7        mouse click doesn't work for spin button if spin button in
     8        iframe (Requested by yosin on #webkit).
     9
     10        * Api/WebPage.cpp:
     11        (BlackBerry::WebKit::WebPagePrivate::contextNode):
     12        (BlackBerry::WebKit::WebPagePrivate::nodeForZoomUnderPoint):
     13        (BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):
     14        (BlackBerry::WebKit::WebPage::nodeAtPoint):
     15        * WebKitSupport/FatFingers.cpp:
     16        (BlackBerry::WebKit::FatFingers::getNodesFromRect):
     17        (BlackBerry::WebKit::FatFingers::getRelevantInfoFromPoint):
     18        * WebKitSupport/SelectionHandler.cpp:
     19        (BlackBerry::WebKit::visiblePositionForPointIgnoringClipping):
     20
    1212012-09-12  Sami Kyostila  <skyostil@google.com>
    222

  • trunk/Source/WebKit/blackberry/WebKitSupport/FatFingers.cpp

    r127876 r128403  
    492492    getPaddings(topPadding, rightPadding, bottomPadding, leftPadding);
    493493
     494    HitTestRequest request(HitTestRequest::ReadOnly | HitTestRequest::Active | HitTestRequest::IgnoreClipping);
    494495    // The user functions checkForText() and findIntersectingRegions() uses the Node.wholeText() to checkFingerIntersection()
    495496    // not the text in its shadow tree.
    496     HitTestRequest request = HitTestRequest::ReadOnly | HitTestRequest::Active | HitTestRequest::IgnoreClipping;
    497     if (m_targetType != Text)
    498         request |= HitTestRequest::AllowShadowContent;
    499     HitTestResult result(contentPos, topPadding, rightPadding, bottomPadding, leftPadding);
     497    ShadowContentFilterPolicy allowShadow = m_targetType == Text ? DoNotAllowShadowContent : AllowShadowContent;
     498    HitTestResult result(contentPos, topPadding, rightPadding, bottomPadding, leftPadding, allowShadow);
    500499
    501500    document->renderView()->layer()->hitTest(request, result);
    … …  
    512511        return;
    513512
    514     HitTestResult result  = document->frame()->eventHandler()->hitTestResultAtPoint(contentPos, HitTestRequest::ReadOnly | HitTestRequest::Active | HitTestRequest::AllowShadowContent);
     513    HitTestResult result  = document->frame()->eventHandler()->hitTestResultAtPoint(contentPos, true /*allowShadowContent*/);
    515514    Node* node = result.innerNode();
    516515    while (node && !node->isElementNode())

  • trunk/Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp

    r128183 r128403  
    161161    // visiblePositionAtPoint which which passes ignoreClipping=true.
    162162    // See RIM Bug #4315.
    163     HitTestResult result = frame.eventHandler()->hitTestResultAtPoint(framePoint, HitTestRequest::ReadOnly | HitTestRequest::Active | HitTestRequest::AllowShadowContent | HitTestRequest::IgnoreClipping);
     163    HitTestResult result = frame.eventHandler()->hitTestResultAtPoint(framePoint, true /* allowShadowContent */, true /* ignoreClipping */);
    164164
    165165    Node* node = result.innerNode();

  • trunk/Source/WebKit/chromium/ChangeLog

    r128378 r128403  
     12012-09-12  Sheriff Bot  <webkit.review.bot@gmail.com>
     2
     3        Unreviewed, rolling out r127876.
     4        http://trac.webkit.org/changeset/127876
     5        https://bugs.webkit.org/show_bug.cgi?id=96600
     6
     7        mouse click doesn't work for spin button if spin button in
     8        iframe (Requested by yosin on #webkit).
     9
     10        * src/ContextMenuClientImpl.cpp:
     11        (WebKit::selectMisspelledWord):
     12        * src/FrameLoaderClientImpl.cpp:
     13        (WebKit::FrameLoaderClientImpl::dispatchDecidePolicyForNavigationAction):
     14        * src/WebFrameImpl.cpp:
     15        (WebKit::WebFrameImpl::characterIndexForPoint):
     16        * src/WebPluginContainerImpl.cpp:
     17        (WebKit::WebPluginContainerImpl::isRectTopmost):
     18        * src/WebViewImpl.cpp:
     19        (WebKit::WebViewImpl::handleMouseUp):
     20        (WebKit::WebViewImpl::computeBlockBounds):
     21
    1222012-09-12  Rick Byers  <rbyers@chromium.org>
    223

  • trunk/Source/WebKit/chromium/src/ContextMenuClientImpl.cpp

    r127876 r128403  
    123123    // Selection is empty, so change the selection to the word under the cursor.
    124124    HitTestResult hitTestResult = selectedFrame->eventHandler()->
    125         hitTestResultAtPoint(selectedFrame->page()->contextMenuController()->hitTestResult().point(), HitTestRequest::ReadOnly | HitTestRequest::Active | HitTestRequest::AllowShadowContent);
     125        hitTestResultAtPoint(selectedFrame->page()->contextMenuController()->hitTestResult().point(), true);
    126126    Node* innerNode = hitTestResult.innerNode();
    127127    VisiblePosition pos(innerNode->renderer()->positionForPoint(

  • trunk/Source/WebKit/chromium/src/FrameLoaderClientImpl.cpp

    r127876 r128403  
    998998                    const MouseEvent* mouseEvent =
    999999                        static_cast<const MouseEvent*>(event);
    1000                     node = m_webFrame->frame()->eventHandler()->hitTestResultAtPoint(mouseEvent->absoluteLocation()).innerNonSharedNode();
     1000                    node = m_webFrame->frame()->eventHandler()->hitTestResultAtPoint(
     1001                        mouseEvent->absoluteLocation(), false).innerNonSharedNode();
    10011002                    break;
    10021003                }

  • trunk/Source/WebKit/chromium/src/WebFrameImpl.cpp

    r128377 r128403  
    12661266
    12671267    IntPoint point = frame()->view()->windowToContents(webPoint);
    1268     HitTestResult result = frame()->eventHandler()->hitTestResultAtPoint(point);
     1268    HitTestResult result = frame()->eventHandler()->hitTestResultAtPoint(point, false);
    12691269    RefPtr<Range> range = frame()->rangeForPoint(result.roundedPoint());
    12701270    if (!range)

  • trunk/Source/WebKit/chromium/src/WebPluginContainerImpl.cpp

    r127952 r128403  
    508508    // Make the rect we're checking (the point surrounded by padding rects) contained inside the requested rect. (Note that -1/2 is 0.)
    509509    LayoutSize padding((documentRect.width() - 1) / 2, (documentRect.height() - 1) / 2);
    510     HitTestResult result = frame->eventHandler()->hitTestResultAtPoint(center, HitTestRequest::ReadOnly | HitTestRequest::Active, padding);
     510    HitTestResult result = frame->eventHandler()->hitTestResultAtPoint(center, false, false, DontHitTestScrollbars, HitTestRequest::ReadOnly | HitTestRequest::Active, padding);
    511511    const HitTestResult::NodeSet& nodes = result.rectBasedTestResult();
    512512    if (nodes.size() != 1)

  • trunk/Source/WebKit/chromium/src/WebViewImpl.cpp

    r128273 r128403  
    639639        IntPoint clickPoint(m_lastMouseDownPoint.x, m_lastMouseDownPoint.y);
    640640        IntPoint contentPoint = view->windowToContents(clickPoint);
    641         HitTestResult hitTestResult = focused->eventHandler()->hitTestResultAtPoint(contentPoint, HitTestRequest::ReadOnly | HitTestRequest::Active | HitTestRequest::TestChildFrameScrollBars);
     641        HitTestResult hitTestResult = focused->eventHandler()->hitTestResultAtPoint(contentPoint, false, false, ShouldHitTestScrollbars);
    642642        // We don't want to send a paste when middle clicking a scroll bar or a
    643643        // link (which will navigate later in the code).  The main scrollbars
    … …  
    10081008    // Use the rect-based hit test to find the node.
    10091009    IntPoint point = mainFrameImpl()->frameView()->windowToContents(IntPoint(rect.x, rect.y));
    1010     HitTestRequest::HitTestRequestType hitType = HitTestRequest::ReadOnly | HitTestRequest::Active | ((zoomType == FindInPage) ? HitTestRequest::IgnoreClipping : 0);
    1011     HitTestResult result = mainFrameImpl()->frame()->eventHandler()->hitTestResultAtPoint(point, hitType, IntSize(rect.width, rect.height));
     1010    HitTestResult result = mainFrameImpl()->frame()->eventHandler()->hitTestResultAtPoint(point,
     1011            false, zoomType == FindInPage, DontHitTestScrollbars, HitTestRequest::Active | HitTestRequest::ReadOnly,
     1012            IntSize(rect.width, rect.height));
    10121013
    10131014    Node* node = result.innerNonSharedNode();

  • trunk/Source/WebKit/efl/ChangeLog

    r128393 r128403  
     12012-09-12  Sheriff Bot  <webkit.review.bot@gmail.com>
     2
     3        Unreviewed, rolling out r127876.
     4        http://trac.webkit.org/changeset/127876
     5        https://bugs.webkit.org/show_bug.cgi?id=96600
     6
     7        mouse click doesn't work for spin button if spin button in
     8        iframe (Requested by yosin on #webkit).
     9
     10        * ewk/ewk_frame.cpp:
     11        (ewk_frame_hit_test_new):
     12
    1132012-09-12  KyungTae Kim  <ktf.kim@samsung.com>
    214

  • trunk/Source/WebKit/efl/ewk/ewk_frame.cpp

    r128006 r128403  
    3939#include "HTMLPlugInElement.h"
    4040#include "HistoryItem.h"
    41 #include "HitTestRequest.h"
    4241#include "HitTestResult.h"
    4342#include "IntSize.h"
    … …  
    695694
    696695    WebCore::HitTestResult result = smartData->frame->eventHandler()->hitTestResultAtPoint
    697                                         (view->windowToContents(WebCore::IntPoint(x, y)), 
    698                                         WebCore::HitTestRequest::ReadOnly | WebCore::HitTestRequest::Active | WebCore::HitTestRequest::IgnoreClipping);
     696                                        (view->windowToContents(WebCore::IntPoint(x, y)),
     697                                        /*allowShadowContent*/ false, /*ignoreClipping*/ true);
    699698
    700699    if (result.scrollbar())

  • trunk/Source/WebKit/mac/ChangeLog

    r128267 r128403  
     12012-09-12  Sheriff Bot  <webkit.review.bot@gmail.com>
     2
     3        Unreviewed, rolling out r127876.
     4        http://trac.webkit.org/changeset/127876
     5        https://bugs.webkit.org/show_bug.cgi?id=96600
     6
     7        mouse click doesn't work for spin button if spin button in
     8        iframe (Requested by yosin on #webkit).
     9
     10        * WebCoreSupport/WebFrameLoaderClient.mm:
     11        (WebFrameLoaderClient::actionDictionary):
     12        * WebView/WebHTMLView.mm:
     13        (-[WebHTMLView elementAtPoint:allowShadowContent:]):
     14
    1152012-09-11  Geoffrey Garen  <ggaren@apple.com>
    216

  • trunk/Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm

    r128129 r128403  
    13331333    if (const MouseEvent* mouseEvent = findMouseEvent(event)) {
    13341334        WebElementDictionary *element = [[WebElementDictionary alloc]
    1335             initWithHitTestResult:core(m_webFrame.get())->eventHandler()->hitTestResultAtPoint(mouseEvent->absoluteLocation())];
     1335            initWithHitTestResult:core(m_webFrame.get())->eventHandler()->hitTestResultAtPoint(mouseEvent->absoluteLocation(), false)];
    13361336        [result setObject:element forKey:WebActionElementKey];
    13371337        [element release];

  • trunk/Source/WebKit/mac/WebView/WebHTMLView.mm

    r127876 r128403  
    62076207    if (!coreFrame)
    62086208        return nil;
    6209     HitTestRequest::HitTestRequestType hitType = HitTestRequest::ReadOnly | HitTestRequest::Active | (allow ? HitTestRequest::AllowShadowContent : 0);
    6210     return [[[WebElementDictionary alloc] initWithHitTestResult:coreFrame->eventHandler()->hitTestResultAtPoint(IntPoint(point), hitType)] autorelease];
     6209    return [[[WebElementDictionary alloc] initWithHitTestResult:coreFrame->eventHandler()->hitTestResultAtPoint(IntPoint(point), allow)] autorelease];
    62116210}
    62126211

  • trunk/Source/WebKit/qt/Api/qwebframe.cpp

    r127876 r128403  
    14071407        return QWebHitTestResult();
    14081408
    1409     HitTestResult result = d->frame->eventHandler()->hitTestResultAtPoint(d->frame->view()->windowToContents(pos), HitTestRequest::ReadOnly | HitTestRequest::Active | HitTestRequest::IgnoreClipping);
     1409    HitTestResult result = d->frame->eventHandler()->hitTestResultAtPoint(d->frame->view()->windowToContents(pos), /*allowShadowContent*/ false, /*ignoreClipping*/ true);
    14101410
    14111411    if (result.scrollbar())

  • trunk/Source/WebKit/qt/Api/qwebpage.cpp

    r128006 r128403  
    801801            client->ownerWidget()->style()->styleHint(QStyle::SH_RequestSoftwareInputPanel));
    802802        if (!clickCausedFocus || behavior == QStyle::RSIP_OnMouseClick) {
    803             HitTestResult result = frame->eventHandler()->hitTestResultAtPoint(frame->view()->windowToContents(pos));
     803            HitTestResult result = frame->eventHandler()->hitTestResultAtPoint(frame->view()->windowToContents(pos), false);
    804804            if (result.isContentEditable()) {
    805805                QEvent event(QEvent::RequestSoftwareInputPanel);
    … …  
    15581558    int y = touchPoint.y();
    15591559
    1560     RefPtr<NodeList> intersectedNodes = document->nodesFromRect(x, y, m_topPadding, m_rightPadding, m_bottomPadding, m_leftPadding);
     1560    RefPtr<NodeList> intersectedNodes = document->nodesFromRect(x, y, m_topPadding, m_rightPadding, m_bottomPadding, m_leftPadding, false /*ignoreClipping*/, false /*allowShadowContent*/);
    15611561    if (!intersectedNodes)
    15621562        return IntPoint();
    … …  
    33643364    WebCore::Frame* focusedFrame = d->page->focusController()->focusedOrMainFrame();
    33653365
    3366     HitTestResult result = focusedFrame->eventHandler()->hitTestResultAtPoint(focusedFrame->view()->windowToContents(pos));
     3366    HitTestResult result = focusedFrame->eventHandler()->hitTestResultAtPoint(focusedFrame->view()->windowToContents(pos), /*allowShadowContent*/ false);
    33673367    if (result.scrollbar())
    33683368        d->hitTestResult = QWebHitTestResult();

  • trunk/Source/WebKit/qt/ChangeLog

    r128315 r128403  
     12012-09-12  Sheriff Bot  <webkit.review.bot@gmail.com>
     2
     3        Unreviewed, rolling out r127876.
     4        http://trac.webkit.org/changeset/127876
     5        https://bugs.webkit.org/show_bug.cgi?id=96600
     6
     7        mouse click doesn't work for spin button if spin button in
     8        iframe (Requested by yosin on #webkit).
     9
     10        * Api/qwebframe.cpp:
     11        (QWebFrame::hitTestContent):
     12        * Api/qwebpage.cpp:
     13        (QWebPagePrivate::handleSoftwareInputPanel):
     14        (QWebPagePrivate::TouchAdjuster::findCandidatePointForTouch):
     15        (QWebPage::updatePositionDependentActions):
     16        * WebCoreSupport/FrameLoaderClientQt.cpp:
     17        (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNavigationAction):
     18
    1192012-09-12  Roland Takacs  <rtakacs@inf.u-szeged.hu>
    220

  • trunk/Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp

    r127876 r128403  
    12731273                const MouseEvent* mouseEvent =  static_cast<const MouseEvent*>(event);
    12741274                node = QWebFramePrivate::core(m_webFrame)->eventHandler()->hitTestResultAtPoint(
    1275                     mouseEvent->absoluteLocation()).innerNonSharedNode();
     1275                    mouseEvent->absoluteLocation(), false).innerNonSharedNode();
    12761276                break;
    12771277            }

  • trunk/Source/WebKit/win/ChangeLog

    r128134 r128403  
     12012-09-12  Sheriff Bot  <webkit.review.bot@gmail.com>
     2
     3        Unreviewed, rolling out r127876.
     4        http://trac.webkit.org/changeset/127876
     5        https://bugs.webkit.org/show_bug.cgi?id=96600
     6
     7        mouse click doesn't work for spin button if spin button in
     8        iframe (Requested by yosin on #webkit).
     9
     10        * WebActionPropertyBag.cpp:
     11        (WebActionPropertyBag::Read):
     12        * WebView.cpp:
     13        (WebView::handleContextMenuEvent):
     14        (WebView::elementAtPoint):
     15
    1162012-09-10  Beth Dakin  <bdakin@apple.com>
    217

  • trunk/Source/WebKit/win/WebActionPropertyBag.cpp

    r127876 r128403  
    122122        if (const MouseEvent* mouseEvent = findMouseEvent(m_action.event())) {
    123123            V_VT(pVar) = VT_UNKNOWN;
    124             V_UNKNOWN(pVar) = WebElementPropertyBag::createInstance(m_frame->eventHandler()->hitTestResultAtPoint(mouseEvent->absoluteLocation()));
     124            V_UNKNOWN(pVar) = WebElementPropertyBag::createInstance(m_frame->eventHandler()->hitTestResultAtPoint(mouseEvent->absoluteLocation(), false));
    125125            return S_OK;
    126126        }

  • trunk/Source/WebKit/win/WebView.cpp

    r127876 r128403  
    13231323
    13241324    IntPoint documentPoint(m_page->mainFrame()->view()->windowToContents(coords));
    1325     HitTestResult result = m_page->mainFrame()->eventHandler()->hitTestResultAtPoint(documentPoint);
     1325    HitTestResult result = m_page->mainFrame()->eventHandler()->hitTestResultAtPoint(documentPoint, false);
    13261326    Frame* targetFrame = result.innerNonSharedNode() ? result.innerNonSharedNode()->document()->frame() : m_page->focusController()->focusedOrMainFrame();
    13271327
    … …  
    35983598    HitTestResult result = HitTestResult(webCorePoint);
    35993599    if (frame->contentRenderer())
    3600         result = frame->eventHandler()->hitTestResultAtPoint(webCorePoint);
     3600        result = frame->eventHandler()->hitTestResultAtPoint(webCorePoint, false);
    36013601    *elementDictionary = WebElementPropertyBag::createInstance(result);
    36023602    return S_OK;

  • trunk/Source/WebKit/wx/ChangeLog

    r127876 r128403  
     12012-09-12  Sheriff Bot  <webkit.review.bot@gmail.com>
     2
     3        Unreviewed, rolling out r127876.
     4        http://trac.webkit.org/changeset/127876
     5        https://bugs.webkit.org/show_bug.cgi?id=96600
     6
     7        mouse click doesn't work for spin button if spin button in
     8        iframe (Requested by yosin on #webkit).
     9
     10        * WebFrame.cpp:
     11        (WebKit::WebFrame::HitTest):
     12
    1132012-09-07  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
    214

  • trunk/Source/WebKit/wx/WebFrame.cpp

    r127876 r128403  
    690690
    691691    if (m_impl->frame->view()) {
    692         WebCore::HitTestResult result = m_impl->frame->eventHandler()->hitTestResultAtPoint(m_impl->frame->view()->windowToContents(pos));
     692        WebCore::HitTestResult result = m_impl->frame->eventHandler()->hitTestResultAtPoint(m_impl->frame->view()->windowToContents(pos), false);
    693693        if (result.innerNode()) {
    694694            domInfo.SetLink(result.absoluteLinkURL().string());

  • trunk/Source/WebKit2/ChangeLog

    r128388 r128403  
     12012-09-12  Sheriff Bot  <webkit.review.bot@gmail.com>
     2
     3        Unreviewed, rolling out r127876.
     4        http://trac.webkit.org/changeset/127876
     5        https://bugs.webkit.org/show_bug.cgi?id=96600
     6
     7        mouse click doesn't work for spin button if spin button in
     8        iframe (Requested by yosin on #webkit).
     9
     10        * WebProcess/InjectedBundle/InjectedBundleNavigationAction.cpp:
     11        (WebKit::InjectedBundleNavigationAction::InjectedBundleNavigationAction):
     12        * WebProcess/WebPage/WebPage.cpp:
     13        (WebKit::handleContextMenuEvent):
     14        (WebKit::WebPage::highlightPotentialActivation):
     15        (WebKit::WebPage::findZoomableAreaForPoint):
     16        * WebProcess/WebPage/mac/WebPageMac.mm:
     17        (WebKit::WebPage::characterIndexForPoint):
     18        (WebKit::WebPage::performDictionaryLookupAtLocation):
     19        (WebKit::WebPage::shouldDelayWindowOrderingEvent):
     20        (WebKit::WebPage::acceptsFirstMouse):
     21        * win/WebKit2.def:
     22        * win/WebKit2CFLite.def:
     23
    1242012-09-12  Brady Eidson  <beidson@apple.com>
    225

  • trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundleNavigationAction.cpp

    r127876 r128403  
    9292{
    9393    if (const MouseEvent* mouseEvent = mouseEventForNavigationAction(navigationAction)) {
    94         m_hitTestResult = InjectedBundleHitTestResult::create(frame->coreFrame()->eventHandler()->hitTestResultAtPoint(mouseEvent->absoluteLocation()));
     94        m_hitTestResult = InjectedBundleHitTestResult::create(frame->coreFrame()->eventHandler()->hitTestResultAtPoint(mouseEvent->absoluteLocation(), false));
    9595        m_mouseButton   = mouseButtonForMouseEvent(mouseEvent);
    9696    }

  • trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp

    r128245 r128403  
    13161316{
    13171317    IntPoint point = page->corePage()->mainFrame()->view()->windowToContents(platformMouseEvent.position());
    1318     HitTestResult result = page->corePage()->mainFrame()->eventHandler()->hitTestResultAtPoint(point);
     1318    HitTestResult result = page->corePage()->mainFrame()->eventHandler()->hitTestResultAtPoint(point, false);
    13191319
    13201320    Frame* frame = page->corePage()->mainFrame();
    … …  
    15671567
    15681568#else
    1569         HitTestResult result = mainframe->eventHandler()->hitTestResultAtPoint(mainframe->view()->windowToContents(point), HitTestRequest::ReadOnly | HitTestRequest::Active | HitTestRequest::AllowShadowContent);
     1569        HitTestResult result = mainframe->eventHandler()->hitTestResultAtPoint(mainframe->view()->windowToContents(point), /*allowShadowContent*/ false, /*ignoreClipping*/ true);
    15701570        adjustedNode = result.innerNode();
    15711571#endif
    … …  
    27282728    UNUSED_PARAM(area);
    27292729    Frame* mainframe = m_mainFrame->coreFrame();
    2730     HitTestResult result = mainframe->eventHandler()->hitTestResultAtPoint(mainframe->view()->windowToContents(point), HitTestRequest::ReadOnly | HitTestRequest::Active | HitTestRequest::IgnoreClipping);
     2730    HitTestResult result = mainframe->eventHandler()->hitTestResultAtPoint(mainframe->view()->windowToContents(point), /*allowShadowContent*/ false, /*ignoreClipping*/ true);
    27312731
    27322732    Node* node = result.innerNode();

  • trunk/Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm

    r127876 r128403  
    376376        return;
    377377
    378     HitTestResult result = frame->eventHandler()->hitTestResultAtPoint(point);
     378    HitTestResult result = frame->eventHandler()->hitTestResultAtPoint(point, false);
    379379    frame = result.innerNonSharedNode() ? result.innerNonSharedNode()->document()->frame() : m_page->focusController()->focusedOrMainFrame();
    380380   
    … …  
    465465    // Find the frame the point is over.
    466466    IntPoint point = roundedIntPoint(floatPoint);
    467     HitTestResult result = frame->eventHandler()->hitTestResultAtPoint(frame->view()->windowToContents(point));
     467    HitTestResult result = frame->eventHandler()->hitTestResultAtPoint(frame->view()->windowToContents(point), false);
    468468    frame = result.innerNonSharedNode() ? result.innerNonSharedNode()->document()->frame() : m_page->focusController()->focusedOrMainFrame();
    469469
    … …  
    728728
    729729#if ENABLE(DRAG_SUPPORT)
    730     HitTestResult hitResult = frame->eventHandler()->hitTestResultAtPoint(frame->view()->windowToContents(event.position()), HitTestRequest::ReadOnly | HitTestRequest::Active | HitTestRequest::AllowShadowContent);
     730    HitTestResult hitResult = frame->eventHandler()->hitTestResultAtPoint(frame->view()->windowToContents(event.position()), true);
    731731    if (hitResult.isSelected())
    732732        result = frame->eventHandler()->eventMayStartDrag(platform(event));
    … …  
    741741        return;
    742742   
    743     HitTestResult hitResult = frame->eventHandler()->hitTestResultAtPoint(frame->view()->windowToContents(event.position()), HitTestRequest::ReadOnly | HitTestRequest::Active | HitTestRequest::AllowShadowContent);
     743    HitTestResult hitResult = frame->eventHandler()->hitTestResultAtPoint(frame->view()->windowToContents(event.position()), true);
    744744    frame->eventHandler()->setActivationEventNumber(eventNumber);
    745745#if ENABLE(DRAG_SUPPORT)

  • trunk/Source/WebKit2/win/WebKit2.def

    r128326 r128403  
    264264        ?contextDestroyed@ContextDestructionObserver@WebCore@@UAEXXZ
    265265        ??0ContextDestructionObserver@WebCore@@QAE@PAVScriptExecutionContext@1@@Z
    266         ?nodesFromRect@Document@WebCore@@QBE?AV?$PassRefPtr@VNodeList@WebCore@@@WTF@@HHIIIII@Z
     266        ?nodesFromRect@Document@WebCore@@QBE?AV?$PassRefPtr@VNodeList@WebCore@@@WTF@@HHIIII_N00@Z
    267267        ?selectionStartHasMarkerFor@Editor@WebCore@@QBE_NW4MarkerType@DocumentMarker@2@HH@Z
    268268        ?webkitWillEnterFullScreenForElement@Document@WebCore@@QAEXPAVElement@2@@Z

  • trunk/Source/WebKit2/win/WebKit2CFLite.def

    r128326 r128403  
    257257        ?utf8@String@WTF@@QBE?AVCString@2@_N@Z
    258258        ?view@Document@WebCore@@QBEPAVFrameView@2@XZ
    259         ?nodesFromRect@Document@WebCore@@QBE?AV?$PassRefPtr@VNodeList@WebCore@@@WTF@@HHIIIII@Z
     259        ?nodesFromRect@Document@WebCore@@QBE?AV?$PassRefPtr@VNodeList@WebCore@@@WTF@@HHIIII_N00@Z
    260260        ?selectionStartHasMarkerFor@Editor@WebCore@@QBE_NW4MarkerType@DocumentMarker@2@HH@Z
    261261        ?restrictScaleFactorToInitialScaleIfNotUserScalable@WebCore@@YAXAAUViewportAttributes@1@@Z

  • trunk/Source/autotools/symbols.filter

    r128210 r128403  
    164164_ZN7WebCore22RuntimeEnabledFeatures22isDialogElementEnabledE;
    165165_ZN7WebCore22RuntimeEnabledFeatures37isAuthorShadowDOMForAnyElementEnabledE;
    166 _ZNK7WebCore8Document13nodesFromRectEiijjjjj;
     166_ZNK7WebCore8Document13nodesFromRectEiijjjjbbb;
    167167_ZN7WebCore4toJSEPN3JSC9ExecStateEPNS_17JSDOMGlobalObjectEPNS_8NodeListE;
    168168_ZNK7WebCore6Editor26selectionStartHasMarkerForENS_14DocumentMarker10MarkerTypeEii;
Note: See TracChangeset for help on using the changeset viewer.