Changeset 128583 in webkit

Timestamp:

Sep 14, 2012 4:11:17 AM (12 years ago)

Author:

keishi@webkit.org

Message:

Add runtime flag that enables lang attribute for form controls in LayoutTests
​https://bugs.webkit.org/show_bug.cgi?id=96636

Reviewed by Kent Tamura.

.:

• Source/autotools/symbols.filter:

Source/WebCore:

Lang attribute support for form controls will be incomplete and just for LayoutTests.

No new tests. No behavior change.

• WebCore.exp.in:
• bindings/generic/RuntimeEnabledFeatures.cpp:

(WebCore):

• bindings/generic/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::langAttributeAwareFormControlUIEnabled):
(WebCore::RuntimeEnabledFeatures::setLangAttributeAwareFormControlUIEnabled):
(RuntimeEnabledFeatures):

• testing/InternalSettings.cpp:

(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::setLangAttributeAwareFormControlUIEnabled):
(WebCore):

• testing/InternalSettings.h:

(Backup):
(InternalSettings):

• testing/InternalSettings.idl:

Source/WebKit2:

• win/WebKit2.def:
• win/WebKit2CFLite.def:

Location:

trunk

Files:

• ChangeLog (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/WebCore.exp.in (modified) (1 diff)
• Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp (modified) (1 diff)
• Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h (modified) (2 diffs)
• Source/WebCore/testing/InternalSettings.cpp (modified) (3 diffs)
• Source/WebCore/testing/InternalSettings.h (modified) (2 diffs)
• Source/WebCore/testing/InternalSettings.idl (modified) (1 diff)
• Source/WebKit2/ChangeLog (modified) (1 diff)
• Source/WebKit2/win/WebKit2.def (modified) (1 diff)
• Source/WebKit2/win/WebKit2CFLite.def (modified) (1 diff)
• Source/autotools/symbols.filter (modified) (1 diff)

trunk/ChangeLog

@@ +1 @@
+2012-09-14  Keishi Hattori  <keishi@webkit.org>
+
+        Add runtime flag that enables lang attribute for form controls in LayoutTests
+        https://bugs.webkit.org/show_bug.cgi?id=96636
+
+        Reviewed by Kent Tamura.
+
+        * Source/autotools/symbols.filter:
+
 2012-09-13  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-09-14  Keishi Hattori  <keishi@webkit.org>
+
+        Add runtime flag that enables lang attribute for form controls in LayoutTests
+        https://bugs.webkit.org/show_bug.cgi?id=96636
+
+        Reviewed by Kent Tamura.
+
+        Lang attribute support for form controls will be incomplete and just for LayoutTests.
+
+        No new tests. No behavior change.
+
+        * WebCore.exp.in:
+        * bindings/generic/RuntimeEnabledFeatures.cpp:
+        (WebCore):
+        * bindings/generic/RuntimeEnabledFeatures.h:
+        (WebCore::RuntimeEnabledFeatures::langAttributeAwareFormControlUIEnabled):
+        (WebCore::RuntimeEnabledFeatures::setLangAttributeAwareFormControlUIEnabled):
+        (RuntimeEnabledFeatures):
+        * testing/InternalSettings.cpp:
+        (WebCore::InternalSettings::Backup::Backup):
+        (WebCore::InternalSettings::Backup::restoreTo):
+        (WebCore::InternalSettings::setLangAttributeAwareFormControlUIEnabled):
+        (WebCore):
+        * testing/InternalSettings.h:
+        (Backup):
+        (InternalSettings):
+        * testing/InternalSettings.idl:
+
 2012-09-14  Keishi Hattori  <keishi@webkit.org>
 

trunk/Source/WebCore/WebCore.exp.in

@@ -562 +562 @@
 __ZN7WebCore21setPlatformStrategiesEPNS_18PlatformStrategiesE
 __ZN7WebCore22RuntimeEnabledFeatures22isCSSExclusionsEnabledE
+__ZN7WebCore22RuntimeEnabledFeatures40isLangAttributeAwareFormControlUIEnabledE
 __ZN7WebCore22ScriptExecutionContext26canSuspendActiveDOMObjectsEv
 __ZN7WebCore22URLWithUserTypedStringEP8NSStringP5NSURL

trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp

@@ -56 +56 @@
 bool RuntimeEnabledFeatures::isSpeechInputEnabled = true;
 bool RuntimeEnabledFeatures::isCSSExclusionsEnabled = false;
+bool RuntimeEnabledFeatures::isLangAttributeAwareFormControlUIEnabled = false;
 
 #if ENABLE(SCRIPTED_SPEECH)

trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h

@@ -261 +261 @@
 #endif
 
+    static bool langAttributeAwareFormControlUIEnabled() { return isLangAttributeAwareFormControlUIEnabled; }
+    // The lang attribute support is incomplete and should only be turned on for tests.
+    static void setLangAttributeAwareFormControlUIEnabled(bool isEnabled) { isLangAttributeAwareFormControlUIEnabled = isEnabled; }
+
 private:
     // Never instantiate.
@@ -278 +282 @@
     static bool isSpeechInputEnabled;
     static bool isCSSExclusionsEnabled;
+    static bool isLangAttributeAwareFormControlUIEnabled;
 #if ENABLE(SCRIPTED_SPEECH)
     static bool isScriptedSpeechEnabled;

trunk/Source/WebCore/testing/InternalSettings.cpp

@@ -99 +99 @@
     , m_canStartMedia(page->canStartMedia())
     , m_originalMockScrollbarsEnabled(settings->mockScrollbarsEnabled())
+    , m_langAttributeAwareFormControlUIEnabled(RuntimeEnabledFeatures::langAttributeAwareFormControlUIEnabled())
 {
 }
@@ -132 +133 @@
     page->setCanStartMedia(m_canStartMedia);
     settings->setMockScrollbarsEnabled(m_originalMockScrollbarsEnabled);
+    RuntimeEnabledFeatures::setLangAttributeAwareFormControlUIEnabled(m_langAttributeAwareFormControlUIEnabled);
 }
 
@@ -645 +647 @@
 }
 
-}
+void InternalSettings::setLangAttributeAwareFormControlUIEnabled(bool enabled)
+{
+    RuntimeEnabledFeatures::setLangAttributeAwareFormControlUIEnabled(enabled);
+}
+
+}

trunk/Source/WebCore/testing/InternalSettings.h

@@ -81 +81 @@
         bool m_canStartMedia;
         bool m_originalMockScrollbarsEnabled;
+        bool m_langAttributeAwareFormControlUIEnabled;
     };
 
@@ -144 +145 @@
     void setMemoryInfoEnabled(bool, ExceptionCode&);
     void setStorageBlockingPolicy(const String&, ExceptionCode&);
+    void setLangAttributeAwareFormControlUIEnabled(bool);
 private:
     explicit InternalSettings(Page*);

trunk/Source/WebCore/testing/InternalSettings.idl

@@ -69 +69 @@
         void setWindowFocusRestricted(in boolean restricted) raises(DOMException);
         void setDialogElementEnabled(in boolean enabled) raises(DOMException);
+        void setLangAttributeAwareFormControlUIEnabled(in boolean enabled);
 
         void setPagination(in DOMString mode, in long gap, in [Optional] long pageLength) raises(DOMException);

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2012-09-14  Keishi Hattori  <keishi@webkit.org>
+
+        Add runtime flag that enables lang attribute for form controls in LayoutTests
+        https://bugs.webkit.org/show_bug.cgi?id=96636
+
+        Reviewed by Kent Tamura.
+
+        * win/WebKit2.def:
+        * win/WebKit2CFLite.def:
+
 2012-09-14  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
 

trunk/Source/WebKit2/win/WebKit2.def

@@ -187 +187 @@
         ?isActiveInsertionPoint@WebCore@@YA_NPBVNode@1@@Z
         ?isCSSExclusionsEnabled@RuntimeEnabledFeatures@WebCore@@0_NA
+        ?isLangAttributeAwareFormControlUIEnabled@RuntimeEnabledFeatures@WebCore@@0_NA
         ?isPreloaded@CachedResourceLoader@WebCore@@QBE_NABVString@WTF@@@Z
         ?jsArray@WebCore@@YA?AVJSValue@JSC@@PAVExecState@3@PAVJSDOMGlobalObject@1@V?$PassRefPtr@VDOMStringList@WebCore@@@WTF@@@Z

trunk/Source/WebKit2/win/WebKit2CFLite.def

@@ -180 +180 @@
         ?isActiveInsertionPoint@WebCore@@YA_NPBVNode@1@@Z
         ?isCSSExclusionsEnabled@RuntimeEnabledFeatures@WebCore@@0_NA
+        ?isLangAttributeAwareFormControlUIEnabled@RuntimeEnabledFeatures@WebCore@@0_NA
         ?isPreloaded@CachedResourceLoader@WebCore@@QBE_NABVString@WTF@@@Z
         ?jsArray@WebCore@@YA?AVJSValue@JSC@@PAVExecState@3@PAVJSDOMGlobalObject@1@V?$PassRefPtr@VDOMStringList@WebCore@@@WTF@@@Z

trunk/Source/autotools/symbols.filter

@@ -162 +162 @@
 _ZN7WebCore22RuntimeEnabledFeatures18isShadowDOMEnabledE;
 _ZN7WebCore22RuntimeEnabledFeatures22isCSSExclusionsEnabledE;
+_ZN7WebCore22RuntimeEnabledFeatures40isLangAttributeAwareFormControlUIEnabledE;
 _ZN7WebCore22RuntimeEnabledFeatures22isDialogElementEnabledE;
 _ZN7WebCore22RuntimeEnabledFeatures37isAuthorShadowDOMForAnyElementEnabledE;