Changeset 128678 in webkit
- Timestamp:
- Sep 14, 2012 6:38:05 PM (12 years ago)
- Location:
- trunk/Source/WebKit2
- Files:
-
- 3 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebKit2/ChangeLog
r128677 r128678 1 2012-09-14 Beth Dakin <bdakin@apple.com> 2 3 https://bugs.webkit.org/show_bug.cgi?id=96846 4 Tests failing on WK2 bots after giving fixed positioning its own 5 stacking context 6 7 Reviewed by Geoffrey Garen. 8 9 Tests are failing because I checked in updated results that expect 10 fixed positioning to create a stacking context. However, 11 WebKitTestRunner does not enable ScrollingCoordinator, so the code 12 that I added to enable stacking contexts for fixedPos is never 13 actually running. This patch moves that code to a place where it will 14 run for the testing tools, which matches the patch for WK1. 15 * WebProcess/WebPage/DrawingAreaImpl.cpp: 16 (WebKit::DrawingAreaImpl::updatePreferences): 17 * WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm: 18 (WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea): 19 1 20 2012-09-14 Julien Chaffraix <jchaffraix@webkit.org> 2 21 -
trunk/Source/WebKit2/WebProcess/WebPage/DrawingAreaImpl.cpp
r128245 r128678 262 262 void DrawingAreaImpl::updatePreferences(const WebPreferencesStore& store) 263 263 { 264 #if PLATFORM(MAC) 265 // Soon we want pages with fixed positioned elements to be able to be scrolled by the ScrollingCoordinator. 266 // As a part of that work, we have to composite fixed position elements, and we have to allow those 267 // elements to create a stacking context. 268 m_webPage->corePage()->settings()->setAcceleratedCompositingForFixedPositionEnabled(true); 269 m_webPage->corePage()->settings()->setFixedPositionCreatesStackingContext(true); 270 264 271 // <rdar://problem/10697417>: It is necessary to force compositing when accelerate drawing 265 272 // is enabled on Mac so that scrollbars are always in their own layers. 266 #if PLATFORM(MAC)267 273 if (m_webPage->corePage()->settings()->acceleratedDrawingEnabled()) 268 274 m_webPage->corePage()->settings()->setForceCompositingMode(LayerTreeHost::supportsAcceleratedCompositing()); -
trunk/Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm
r128652 r128678 77 77 page->settings()->setForceCompositingMode(true); 78 78 79 // Soon we want pages with fixed positioned elements to be able to be scrolled by the ScrollingCoordinator.80 // As a part of that work, we have to composite fixed position elements, and we have to allow those81 // elements to create a stacking context.82 page->settings()->setAcceleratedCompositingForFixedPositionEnabled(true);83 page->settings()->setFixedPositionCreatesStackingContext(true);84 85 79 WebProcess::shared().eventDispatcher().addScrollingTreeForPage(webPage); 86 80
Note: See TracChangeset
for help on using the changeset viewer.