Changeset 128795 in webkit


Ignore:
Timestamp:
Sep 17, 2012 1:00:11 PM (12 years ago)
Author:
jsbell@chromium.org
Message:

IndexedDB: Result of IDBFactory.deleteDatabase() should be undefined, not null
​https://bugs.webkit.org/show_bug.cgi?id=96538

Reviewed by Tony Chang.

Source/WebCore:

Trivial implementation change to match the spec.

Tests: storage/indexeddb/factory-deletedatabase-expected.html

storage/indexeddb/intversion-long-queue-expected.html

  • Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::deleteDatabase):

LayoutTests:

Check result of IDBFactory.deleteDatabase() - one updated assertion, one added assertion.

  • storage/indexeddb/factory-deletedatabase-expected.txt:
  • storage/indexeddb/intversion-long-queue-expected.txt:
  • storage/indexeddb/resources/factory-deletedatabase.js: Add new assertion.

(reopenDatabase):

  • storage/indexeddb/resources/intversion-long-queue.js: Update existing assertion.

(deleteDatabaseSuccessCallback):

Location:
trunk
Files:
7 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r128793 r128795  
     12012-09-17  Joshua Bell  <jsbell@chromium.org>
     2
     3        IndexedDB: Result of IDBFactory.deleteDatabase() should be undefined, not null
     4        https://bugs.webkit.org/show_bug.cgi?id=96538
     5
     6        Reviewed by Tony Chang.
     7
     8        Check result of IDBFactory.deleteDatabase() - one updated assertion, one added assertion.
     9
     10        * storage/indexeddb/factory-deletedatabase-expected.txt:
     11        * storage/indexeddb/intversion-long-queue-expected.txt:
     12        * storage/indexeddb/resources/factory-deletedatabase.js: Add new assertion.
     13        (reopenDatabase):
     14        * storage/indexeddb/resources/intversion-long-queue.js: Update existing assertion.
     15        (deleteDatabaseSuccessCallback):
     16
    1172012-09-17  Alexey Proskuryakov  <ap@apple.com>
    218

  • trunk/LayoutTests/storage/indexeddb/factory-deletedatabase-expected.txt

    r128642 r128795  
    2121db.setVersion('new version')
    2222request = indexedDB.deleteDatabase('database-to-delete')
     23PASS request.result is undefined.
    2324indexedDB.open('database-to-delete')
    2425db = event.target.result

  • trunk/LayoutTests/storage/indexeddb/intversion-long-queue-expected.txt

    r128642 r128795  
    6464FAIL event.oldVersion should be non-null. Was undefined
    6565FAIL event.newVersion should be null (of type object). Was undefined (of type undefined).
    66 PASS event.target.result is null
     66PASS event.target.result is undefined.
    6767
    6868upgradeNeededCallback():

  • trunk/LayoutTests/storage/indexeddb/resources/factory-deletedatabase.js

    r117702 r128795  
    6868function reopenDatabase()
    6969{
     70    shouldBeUndefined("request.result");
    7071    request = evalAndLog("indexedDB.open('database-to-delete')");
    7172    request.onsuccess = startSetVersionAgain;

  • trunk/LayoutTests/storage/indexeddb/resources/intversion-long-queue.js

    r124383 r128795  
    110110    shouldBeNonNull("event.oldVersion");
    111111    shouldBeNull("event.newVersion");
    112     shouldBeNull("event.target.result");
     112    shouldBeUndefined("event.target.result");
    113113}
    114114

  • trunk/Source/WebCore/ChangeLog

    r128794 r128795  
     12012-09-17  Joshua Bell  <jsbell@chromium.org>
     2
     3        IndexedDB: Result of IDBFactory.deleteDatabase() should be undefined, not null
     4        https://bugs.webkit.org/show_bug.cgi?id=96538
     5
     6        Reviewed by Tony Chang.
     7
     8        Trivial implementation change to match the spec.
     9
     10        Tests: storage/indexeddb/factory-deletedatabase-expected.html
     11               storage/indexeddb/intversion-long-queue-expected.html
     12
     13        * Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
     14        (WebCore::IDBDatabaseBackendImpl::deleteDatabase):
     15
    1162012-09-17  Rick Byers  <rbyers@chromium.org>
    217

  • trunk/Source/WebCore/Modules/indexeddb/IDBDatabaseBackendImpl.cpp

    r128674 r128795  
    551551    m_intVersion = IDBDatabaseMetadata::NoIntVersion;
    552552    m_objectStores.clear();
    553     callbacks->onSuccess(SerializedScriptValue::nullValue());
     553    callbacks->onSuccess(SerializedScriptValue::undefinedValue());
    554554}
    555555
Note: See TracChangeset for help on using the changeset viewer.