Changeset 128842 in webkit
- Timestamp:
- Sep 17, 2012 7:25:35 PM (12 years ago)
- Location:
- trunk/Tools
- Files:
-
- 2 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Tools/ChangeLog
r128834 r128842 1 2012-09-17 Dirk Pranke <dpranke@chromium.org> 2 3 nrwt: remove "unexpected EOF" warnings 4 https://bugs.webkit.org/show_bug.cgi?id=96970 5 6 Reviewed by Ojan Vafai. 7 8 After debugging this a bit, it looks like there aren't any cases 9 that I can reproduce where a read() of zero indicates something 10 actually wrong; either it is a prelude to a crash, or a false 11 negative. So, I'm removing these warnings and adding a comment. 12 13 * Scripts/webkitpy/layout_tests/port/server_process.py: 14 (ServerProcess._wait_for_data_and_update_buffers_using_select): 15 1 16 2012-09-17 Dirk Pranke <dpranke@chromium.org> 2 17 -
trunk/Tools/Scripts/webkitpy/layout_tests/port/server_process.py
r126607 r128842 229 229 230 230 try: 231 # Note that we may get no data during read() even though 232 # select says we got something; see the select() man page 233 # on linux. I don't know if this happens on Mac OS and 234 # other Unixen as well, but we don't bother special-casing 235 # Linux because it's relatively harmless either way. 231 236 if out_fd in read_fds: 232 237 data = self._proc.stdout.read() 233 if not data and not stopping: 234 if self._treat_no_data_as_crash or self._proc.poll() is not None: 235 _log.warning('unexpected EOF of stdout, %s crashed' % self._name) 236 self._crashed = True 237 else: 238 _log.warning('unexpected EOF of stdout, %s is still alive' % self._name) 238 if not data and not stopping and (self._treat_no_data_as_crash or self._proc.poll()): 239 self._crashed = True 239 240 self._output += data 240 241 241 242 if err_fd in read_fds: 242 243 data = self._proc.stderr.read() 243 if not data and not stopping: 244 if self._treat_no_data_as_crash or self._proc.poll() is not None: 245 _log.warning('unexpected EOF on stderr, %s crashed' % self._name) 246 self._crashed = True 247 else: 248 _log.warning('unexpected EOF on stderr, %s is still alive' % self._name) 244 if not data and not stopping and (self._treat_no_data_as_crash or self._proc.poll()): 245 self._crashed = True 249 246 self._error += data 250 247 except IOError, e:
Note: See TracChangeset
for help on using the changeset viewer.