Changeset 128852 in webkit


Ignore:
Timestamp:
Sep 17, 2012 11:34:55 PM (12 years ago)
Author:
psolanki@apple.com
Message:

DumpRenderTree and WebKitTestRunner should compile with -Wundef on Mac
​https://bugs.webkit.org/show_bug.cgi?id=96973

Reviewed by Dan Bernstein.

  • DumpRenderTree/mac/Configurations/Base.xcconfig:
  • WebKitTestRunner/Configurations/Base.xcconfig:
  • WebKitTestRunner/PlatformWebView.h: Use #ifdef OBJC and not #if.
Location:
trunk/Tools
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/Tools/ChangeLog

    r128842 r128852  
     12012-09-17  Pratik Solanki  <psolanki@apple.com>
     2
     3        DumpRenderTree and WebKitTestRunner should compile with -Wundef on Mac
     4        https://bugs.webkit.org/show_bug.cgi?id=96973
     5
     6        Reviewed by Dan Bernstein.
     7
     8        * DumpRenderTree/mac/Configurations/Base.xcconfig:
     9        * WebKitTestRunner/Configurations/Base.xcconfig:
     10        * WebKitTestRunner/PlatformWebView.h: Use #ifdef __OBJC__ and not #if.
     11
    1122012-09-17  Dirk Pranke  <dpranke@chromium.org>
    213

  • trunk/Tools/DumpRenderTree/mac/Configurations/Base.xcconfig

    r122404 r128852  
    3838GCC_WARN_UNUSED_FUNCTION = YES
    3939GCC_WARN_UNUSED_VARIABLE = YES
    40 WARNING_CFLAGS = -Wall -W -Wno-unused-parameter
     40WARNING_CFLAGS = -Wall -W -Wno-unused-parameter -Wundef
    4141LINKER_DISPLAYS_MANGLED_NAMES = YES;
    4242

  • trunk/Tools/WebKitTestRunner/Configurations/Base.xcconfig

    r122404 r128852  
    3838GCC_WARN_UNUSED_FUNCTION = YES
    3939GCC_WARN_UNUSED_VARIABLE = YES
    40 WARNING_CFLAGS = -Wall -W -Wno-unused-parameter
     40WARNING_CFLAGS = -Wall -W -Wno-unused-parameter -Wundef
    4141LINKER_DISPLAYS_MANGLED_NAMES = YES;
    4242VALID_ARCHS = i386 x86_64;

  • trunk/Tools/WebKitTestRunner/PlatformWebView.h

    r123456 r128852  
    3838typedef QQuickView* PlatformWindow;
    3939#elif defined(__APPLE__) && __APPLE__
    40 #if __OBJC__
     40#ifdef __OBJC__
    4141@class WKView;
    4242@class WebKitTestRunnerWindow;
Note: See TracChangeset for help on using the changeset viewer.