Changeset 128854 in webkit

Timestamp:

Sep 17, 2012 11:56:36 PM (12 years ago)

Author:

zandobersek@gmail.com

Message:

[GTK] fast/loader/display-image-unset-can-block-image-and-can-reload-in-place.html failing after r128645
​https://bugs.webkit.org/show_bug.cgi?id=96899

Reviewed by Martin Robinson.

Tools:

When overriding the 'WebKitDisplayImageKey' preference, use the
'auto-load-images' property of WebKitWebSettings as the property which
should be updated with the corresponding preference value.

• DumpRenderTree/gtk/DumpRenderTree.cpp:

(resetDefaultsToConsistentValues):

• DumpRenderTree/gtk/TestRunnerGtk.cpp:

(TestRunner::overridePreference):

LayoutTests:

Remove failure expectation for the test in title.

• platform/gtk/TestExpectations:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/gtk/TestExpectations (modified) (1 diff)
• Tools/ChangeLog (modified) (1 diff)
• Tools/DumpRenderTree/gtk/TestRunnerGtk.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2012-09-17  Zan Dobersek  <zandobersek@gmail.com>
+
+        [GTK] fast/loader/display-image-unset-can-block-image-and-can-reload-in-place.html failing after r128645
+        https://bugs.webkit.org/show_bug.cgi?id=96899
+
+        Reviewed by Martin Robinson.
+
+        Remove failure expectation for the test in title.
+
+        * platform/gtk/TestExpectations:
+
 2012-09-17  Shinya Kawanaka  <shinyak@chromium.org>
 

trunk/LayoutTests/platform/gtk/TestExpectations

@@ -1359 +1359 @@
 BUGWK50740 DEBUG : editing/spelling/spellcheck-queue.html = TEXT
 
-BUGWK96899 : fast/loader/display-image-unset-can-block-image-and-can-reload-in-place.html = TEXT
-
 BUGWK96900 : fast/text/stale-TextLayout-from-first-line.html = IMAGE
 

trunk/Tools/ChangeLog

@@ +1 @@
+2012-09-17  Zan Dobersek  <zandobersek@gmail.com>
+
+        [GTK] fast/loader/display-image-unset-can-block-image-and-can-reload-in-place.html failing after r128645
+        https://bugs.webkit.org/show_bug.cgi?id=96899
+
+        Reviewed by Martin Robinson.
+
+        When overriding the 'WebKitDisplayImageKey' preference, use the
+        'auto-load-images' property of WebKitWebSettings as the property which
+        should be updated with the corresponding preference value.
+
+        * DumpRenderTree/gtk/DumpRenderTree.cpp:
+        (resetDefaultsToConsistentValues):
+        * DumpRenderTree/gtk/TestRunnerGtk.cpp:
+        (TestRunner::overridePreference):
+
 2012-09-17  Pratik Solanki  <psolanki@apple.com>
 

trunk/Tools/DumpRenderTree/gtk/TestRunnerGtk.cpp

@@ -777 +777 @@
     else if (g_str_equal(originalName.get(), "WebKitWebAudioEnabled"))
         propertyName = "enable-webaudio";
+    else if (g_str_equal(originalName.get(), "WebKitDisplayImagesKey"))
+        propertyName = "auto-load-images";
     else if (g_str_equal(originalName.get(), "WebKitTabToLinksPreferenceKey")) {
         DumpRenderTreeSupportGtk::setLinksIncludedInFocusChain(booleanFromValue(valueAsString.get()));