Changeset 128856 in webkit


Ignore:
Timestamp:
Sep 18, 2012 12:28:23 AM (12 years ago)
Author:
shinyak@chromium.org
Message:

Disable adding an AuthorShadowRoot to replaced elements.
​https://bugs.webkit.org/show_bug.cgi?id=96978

Reviewed by Hajime Morita.

Source/WebCore:

We (people who implement Shadow DOM) have concluded that we don't support adding AuthorShadowRoot to
replaced elements in the current spec, since it turned out that a lot of difficulties exist and it brings
a lot of mess to our codebase.

For now, we just disable adding AuthorShadowRoot to these replaced elements.

Test: fast/dom/shadow/shadow-disable.html

  • html/HTMLImageElement.h:
  • html/HTMLKeygenElement.h:
  • html/HTMLMeterElement.h:
  • html/HTMLProgressElement.h:
  • html/HTMLTextAreaElement.h:

LayoutTests:

Since we don't support AuthorShadowRoot for replaced elements for now, we enable a flat to
support AuthorShadowRoot in these tests.

Also, we have a test to check to reject adding ShadowRoot to repalced elements.

  • fast/dom/shadow/select-image-with-shadow.html:
  • fast/dom/shadow/shadow-disable-expected.txt:
  • fast/dom/shadow/shadow-disable.html: Checks WebKit rejects adding ShadowRoot to repalced elements.
  • fast/dom/shadow/shadowdom-for-fieldset-only-shadow.html:
  • fast/dom/shadow/shadowdom-for-image-alt-update.html:
  • fast/dom/shadow/shadowdom-for-image-alt.html:
  • fast/dom/shadow/shadowdom-for-image-content.html:
  • fast/dom/shadow/shadowdom-for-image-dynamic.html:
  • fast/dom/shadow/shadowdom-for-image-event-click.html:
  • fast/dom/shadow/shadowdom-for-image-event.html:
  • fast/dom/shadow/shadowdom-for-image-in-shadowdom.html:
  • fast/dom/shadow/shadowdom-for-image-map.html:
  • fast/dom/shadow/shadowdom-for-image-style.html:
  • fast/dom/shadow/shadowdom-for-image-with-multiple-shadow.html:
  • fast/dom/shadow/shadowdom-for-image-with-pseudo-id.html:
  • fast/dom/shadow/shadowdom-for-image-with-width-and-height.html:
  • fast/dom/shadow/shadowdom-for-image.html:
  • fast/dom/shadow/shadowdom-for-keygen-complex-shadow.html:
  • fast/dom/shadow/shadowdom-for-keygen-without-shadow.html:
  • fast/dom/shadow/shadowdom-for-meter-dynamic.html:
  • fast/dom/shadow/shadowdom-for-meter-multiple.html:
  • fast/dom/shadow/shadowdom-for-meter-with-style.html:
  • fast/dom/shadow/shadowdom-for-meter-without-appearance.html:
  • fast/dom/shadow/shadowdom-for-meter-without-shadow-element.html:
  • fast/dom/shadow/shadowdom-for-meter.html:
  • fast/dom/shadow/shadowdom-for-object-only-shadow.html:
  • fast/dom/shadow/shadowdom-for-progress-dynamic.html:
  • fast/dom/shadow/shadowdom-for-progress-multiple.html:
  • fast/dom/shadow/shadowdom-for-progress-with-style.html:
  • fast/dom/shadow/shadowdom-for-progress-without-appearance.html:
  • fast/dom/shadow/shadowdom-for-progress-without-shadow-element.html:
  • fast/dom/shadow/shadowdom-for-progress.html:
  • fast/dom/shadow/shadowdom-for-textarea-complex-shadow.html:
  • fast/dom/shadow/shadowdom-for-textarea-with-placeholder.html:
  • fast/dom/shadow/shadowdom-for-textarea-without-shadow.html:
  • fast/dom/shadow/shadowdom-for-textarea.html:
Location:
trunk
Files:
43 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r128854 r128856  
     12012-09-18  Shinya Kawanaka  <shinyak@chromium.org>
     2
     3        Disable adding an AuthorShadowRoot to replaced elements.
     4        https://bugs.webkit.org/show_bug.cgi?id=96978
     5
     6        Reviewed by Hajime Morita.
     7
     8        Since we don't support AuthorShadowRoot for replaced elements for now, we enable a flat to
     9        support AuthorShadowRoot in these tests.
     10
     11        Also, we have a test to check to reject adding ShadowRoot to repalced elements.
     12
     13        * fast/dom/shadow/select-image-with-shadow.html:
     14        * fast/dom/shadow/shadow-disable-expected.txt:
     15        * fast/dom/shadow/shadow-disable.html: Checks WebKit rejects adding ShadowRoot to repalced elements.
     16        * fast/dom/shadow/shadowdom-for-fieldset-only-shadow.html:
     17        * fast/dom/shadow/shadowdom-for-image-alt-update.html:
     18        * fast/dom/shadow/shadowdom-for-image-alt.html:
     19        * fast/dom/shadow/shadowdom-for-image-content.html:
     20        * fast/dom/shadow/shadowdom-for-image-dynamic.html:
     21        * fast/dom/shadow/shadowdom-for-image-event-click.html:
     22        * fast/dom/shadow/shadowdom-for-image-event.html:
     23        * fast/dom/shadow/shadowdom-for-image-in-shadowdom.html:
     24        * fast/dom/shadow/shadowdom-for-image-map.html:
     25        * fast/dom/shadow/shadowdom-for-image-style.html:
     26        * fast/dom/shadow/shadowdom-for-image-with-multiple-shadow.html:
     27        * fast/dom/shadow/shadowdom-for-image-with-pseudo-id.html:
     28        * fast/dom/shadow/shadowdom-for-image-with-width-and-height.html:
     29        * fast/dom/shadow/shadowdom-for-image.html:
     30        * fast/dom/shadow/shadowdom-for-keygen-complex-shadow.html:
     31        * fast/dom/shadow/shadowdom-for-keygen-without-shadow.html:
     32        * fast/dom/shadow/shadowdom-for-meter-dynamic.html:
     33        * fast/dom/shadow/shadowdom-for-meter-multiple.html:
     34        * fast/dom/shadow/shadowdom-for-meter-with-style.html:
     35        * fast/dom/shadow/shadowdom-for-meter-without-appearance.html:
     36        * fast/dom/shadow/shadowdom-for-meter-without-shadow-element.html:
     37        * fast/dom/shadow/shadowdom-for-meter.html:
     38        * fast/dom/shadow/shadowdom-for-object-only-shadow.html:
     39        * fast/dom/shadow/shadowdom-for-progress-dynamic.html:
     40        * fast/dom/shadow/shadowdom-for-progress-multiple.html:
     41        * fast/dom/shadow/shadowdom-for-progress-with-style.html:
     42        * fast/dom/shadow/shadowdom-for-progress-without-appearance.html:
     43        * fast/dom/shadow/shadowdom-for-progress-without-shadow-element.html:
     44        * fast/dom/shadow/shadowdom-for-progress.html:
     45        * fast/dom/shadow/shadowdom-for-textarea-complex-shadow.html:
     46        * fast/dom/shadow/shadowdom-for-textarea-with-placeholder.html:
     47        * fast/dom/shadow/shadowdom-for-textarea-without-shadow.html:
     48        * fast/dom/shadow/shadowdom-for-textarea.html:
     49
    1502012-09-17  Zan Dobersek  <zandobersek@gmail.com>
    251

  • trunk/LayoutTests/fast/dom/shadow/select-image-with-shadow.html

    r125397 r128856  
    77
    88<script>
     9if (window.internals)
     10    internals.settings.setAuthorShadowDOMForAnyElementEnabled(true);
     11
    912var shadowRoot = new WebKitShadowRoot(host);
    1013shadowRoot.innerHTML = "<span id='span1'>Kotori</span><shadow></shadow><span id='span2'>Piyo</span>";

  • trunk/LayoutTests/fast/dom/shadow/shadow-disable-expected.txt

    r128323 r128856  
    1212SECTION
    1313PASS new WebKitShadowRoot(element) is not null
    14 TEXTAREA
    15 PASS new WebKitShadowRoot(element) is not null
    1614INPUT
    1715PASS new WebKitShadowRoot(element) threw exception Error: HIERARCHY_REQUEST_ERR: DOM Exception 3.
    … …  
    2422SELECT
    2523PASS new WebKitShadowRoot(element) threw exception Error: HIERARCHY_REQUEST_ERR: DOM Exception 3.
     24IMG
     25PASS new WebKitShadowRoot(element) threw exception Error: HIERARCHY_REQUEST_ERR: DOM Exception 3.
     26TEXTAREA
     27PASS new WebKitShadowRoot(element) threw exception Error: HIERARCHY_REQUEST_ERR: DOM Exception 3.
     28IFRAME
     29PASS new WebKitShadowRoot(element) threw exception Error: HIERARCHY_REQUEST_ERR: DOM Exception 3.
     30CANVAS
     31PASS new WebKitShadowRoot(element) threw exception Error: HIERARCHY_REQUEST_ERR: DOM Exception 3.
     32METER
     33PASS new WebKitShadowRoot(element) threw exception Error: HIERARCHY_REQUEST_ERR: DOM Exception 3.
     34PROGRESS
     35PASS new WebKitShadowRoot(element) threw exception Error: HIERARCHY_REQUEST_ERR: DOM Exception 3.
     36OBJECT
     37PASS new WebKitShadowRoot(element) threw exception Error: HIERARCHY_REQUEST_ERR: DOM Exception 3.
     38EMBED
     39PASS new WebKitShadowRoot(element) threw exception Error: HIERARCHY_REQUEST_ERR: DOM Exception 3.
     40KEYGEN
     41PASS new WebKitShadowRoot(element) threw exception Error: HIERARCHY_REQUEST_ERR: DOM Exception 3.
     42VIDEO
     43PASS new WebKitShadowRoot(element) threw exception Error: HIERARCHY_REQUEST_ERR: DOM Exception 3.
     44AUDIO
     45PASS new WebKitShadowRoot(element) threw exception Error: HIERARCHY_REQUEST_ERR: DOM Exception 3.
     46FIELDSET
     47PASS new WebKitShadowRoot(element) threw exception Error: HIERARCHY_REQUEST_ERR: DOM Exception 3.
    2648PASS successfullyParsed is true
    2749

  • trunk/LayoutTests/fast/dom/shadow/shadow-disable.html

    r128323 r128856  
    2525    document.createElement('a'),
    2626    document.createElement('section'),
    27     document.createElement('textarea')
    2827];
    2928
    … …  
    3332    document.createElement('audio'),
    3433    document.createElement('video'),
    35     document.createElement('select')
     34    document.createElement('select'),
     35    document.createElement('img'),
     36    document.createElement('textarea'),
     37    document.createElement('iframe'),
     38    document.createElement('canvas'),
     39    document.createElement('meter'),
     40    document.createElement('progress'),
     41    document.createElement('object'),
     42    document.createElement('embed'),
     43    document.createElement('keygen'),
     44    document.createElement('video'),
     45    document.createElement('audio'),
     46    document.createElement('fieldset'),
    3647];
    3748

  • trunk/LayoutTests/fast/dom/shadow/shadowdom-for-fieldset-only-shadow.html

    r123713 r128856  
    1212
    1313<script>
     14if (window.internals)
     15    internals.settings.setAuthorShadowDOMForAnyElementEnabled(true);
     16
    1417var host = document.getElementById('host');
    1518var shadowRoot = new WebKitShadowRoot(host);

  • trunk/LayoutTests/fast/dom/shadow/shadowdom-for-image-alt-update.html

    r122824 r128856  
    1111
    1212<script>
     13if (window.internals)
     14    internals.settings.setAuthorShadowDOMForAnyElementEnabled(true);
     15
    1316function addShadowDOM(host) {
    1417    var shadowRoot = new WebKitShadowRoot(host);

  • trunk/LayoutTests/fast/dom/shadow/shadowdom-for-image-alt.html

    r122824 r128856  
    1111
    1212<script>
     13if (window.internals)
     14    internals.settings.setAuthorShadowDOMForAnyElementEnabled(true);
     15
    1316function addShadowDOM(host) {
    1417    var shadowRoot = new WebKitShadowRoot(host);

  • trunk/LayoutTests/fast/dom/shadow/shadowdom-for-image-content.html

    r122824 r128856  
    1111
    1212<script>
     13if (window.internals)
     14    internals.settings.setAuthorShadowDOMForAnyElementEnabled(true);
     15
    1316function addShadowDOM(host) {
    1417    var shadowRoot = new WebKitShadowRoot(host);

  • trunk/LayoutTests/fast/dom/shadow/shadowdom-for-image-dynamic.html

    r122824 r128856  
    1111
    1212<script>
     13if (window.internals)
     14    internals.settings.setAuthorShadowDOMForAnyElementEnabled(true);
     15
    1316function addShadowDOM(host) {
    1417    var shadowRoot = new WebKitShadowRoot(host);

  • trunk/LayoutTests/fast/dom/shadow/shadowdom-for-image-event-click.html

    r122824 r128856  
    1212
    1313<script>
     14if (window.internals)
     15    internals.settings.setAuthorShadowDOMForAnyElementEnabled(true);
     16
    1417if (window.testRunner) {
    1518    testRunner.dumpAsText();

  • trunk/LayoutTests/fast/dom/shadow/shadowdom-for-image-event.html

    r125727 r128856  
    88</div>
    99<script>
     10if (window.internals)
     11    internals.settings.setAuthorShadowDOMForAnyElementEnabled(true);
     12
    1013description("Tests to ensure that an img element receives a load event, but an inner image element in shadow DOM subtree does not receive.");
    1114

  • trunk/LayoutTests/fast/dom/shadow/shadowdom-for-image-in-shadowdom.html

    r122824 r128856  
    99
    1010<script>
     11if (window.internals)
     12    internals.settings.setAuthorShadowDOMForAnyElementEnabled(true);
     13
    1114var shadowRoot = new WebKitShadowRoot(host);
    1215shadowRoot.innerHTML = "before<img id='img' src='../resources/apple.gif'>after";

  • trunk/LayoutTests/fast/dom/shadow/shadowdom-for-image-map.html

    r122824 r128856  
    2020
    2121<script>
     22if (window.internals)
     23    internals.settings.setAuthorShadowDOMForAnyElementEnabled(true);
     24
    2225if (window.testRunner)
    2326    testRunner.dumpAsText();

  • trunk/LayoutTests/fast/dom/shadow/shadowdom-for-image-style.html

    r122824 r128856  
    2323
    2424<script>
     25if (window.internals)
     26    internals.settings.setAuthorShadowDOMForAnyElementEnabled(true);
     27
    2528function addShadowDOM(host) {
    2629    var shadowRoot = new WebKitShadowRoot(host);

  • trunk/LayoutTests/fast/dom/shadow/shadowdom-for-image-with-multiple-shadow.html

    r122824 r128856  
    1111
    1212<script>
     13if (window.internals)
     14    internals.settings.setAuthorShadowDOMForAnyElementEnabled(true);
     15
    1316function addShadowDOM(host) {
    1417    var shadowRoot = new WebKitShadowRoot(host);

  • trunk/LayoutTests/fast/dom/shadow/shadowdom-for-image-with-pseudo-id.html

    r123192 r128856  
    1717
    1818<script>
     19if (window.internals)
     20    internals.settings.setAuthorShadowDOMForAnyElementEnabled(true);
     21
    1922function addShadowDOM(host) {
    2023    var shadowRoot = new WebKitShadowRoot(host);

  • trunk/LayoutTests/fast/dom/shadow/shadowdom-for-image-with-width-and-height.html

    r122824 r128856  
    1111
    1212<script>
     13if (window.internals)
     14    internals.settings.setAuthorShadowDOMForAnyElementEnabled(true);
     15
    1316function addShadowDOM(host) {
    1417    var shadowRoot = new WebKitShadowRoot(host);

  • trunk/LayoutTests/fast/dom/shadow/shadowdom-for-image.html

    r122824 r128856  
    1111
    1212<script>
     13if (window.internals)
     14    internals.settings.setAuthorShadowDOMForAnyElementEnabled(true);
     15
    1316function addShadowDOM(host) {
    1417    var shadowRoot = new WebKitShadowRoot(host);

  • trunk/LayoutTests/fast/dom/shadow/shadowdom-for-keygen-complex-shadow.html

    r126525 r128856  
    88
    99<script>
     10if (window.internals)
     11    internals.settings.setAuthorShadowDOMForAnyElementEnabled(true);
     12
    1013host.appendChild(document.createTextNode('foobar'));
    1114

  • trunk/LayoutTests/fast/dom/shadow/shadowdom-for-keygen-without-shadow.html

    r126525 r128856  
    1111
    1212<script>
     13if (window.internals)
     14    internals.settings.setAuthorShadowDOMForAnyElementEnabled(true);
     15
    1316var shadowRoot = new WebKitShadowRoot(host);
    1417</script>

  • trunk/LayoutTests/fast/dom/shadow/shadowdom-for-meter-dynamic.html

    r125659 r128856  
    99
    1010<script>
     11if (window.internals)
     12    internals.settings.setAuthorShadowDOMForAnyElementEnabled(true);
     13
    1114if (window.testRunner)
    1215    testRunner.waitUntilDone();

  • trunk/LayoutTests/fast/dom/shadow/shadowdom-for-meter-multiple.html

    r125659 r128856  
    1515
    1616<script>
     17if (window.internals)
     18    internals.settings.setAuthorShadowDOMForAnyElementEnabled(true);
     19
    1720var shadowRoot = new WebKitShadowRoot(host);
    1821shadowRoot.innerHTML = "<shadow></shadow><span>(after)</span>";

  • trunk/LayoutTests/fast/dom/shadow/shadowdom-for-meter-with-style.html

    r125659 r128856  
    2626
    2727<script>
     28if (window.internals)
     29    internals.settings.setAuthorShadowDOMForAnyElementEnabled(true);
     30
    2831var shadowRoot = new WebKitShadowRoot(host);
    2932shadowRoot.innerHTML = "<div style='margin-left: 100px'><shadow></shadow><span>(after)</span></div>";

  • trunk/LayoutTests/fast/dom/shadow/shadowdom-for-meter-without-appearance.html

    r125659 r128856  
    1818
    1919<script>
     20if (window.internals)
     21    internals.settings.setAuthorShadowDOMForAnyElementEnabled(true);
     22
    2023var shadowRoot = new WebKitShadowRoot(host);
    2124shadowRoot.innerHTML = "<shadow></shadow><span>(after)</span>";

  • trunk/LayoutTests/fast/dom/shadow/shadowdom-for-meter-without-shadow-element.html

    r125659 r128856  
    99
    1010<script>
     11if (window.internals)
     12    internals.settings.setAuthorShadowDOMForAnyElementEnabled(true);
     13
    1114var shadowRoot = new WebKitShadowRoot(host);
    1215shadowRoot.innerHTML = "<span>no progress</span>"

  • trunk/LayoutTests/fast/dom/shadow/shadowdom-for-meter.html

    r125659 r128856  
    99
    1010<script>
     11if (window.internals)
     12    internals.settings.setAuthorShadowDOMForAnyElementEnabled(true);
     13
    1114var shadowRoot = new WebKitShadowRoot(host);
    1215shadowRoot.innerHTML = "<shadow></shadow><span>(after)</span>";

  • trunk/LayoutTests/fast/dom/shadow/shadowdom-for-object-only-shadow.html

    r123713 r128856  
    99
    1010<script>
     11if (window.internals)
     12    internals.settings.setAuthorShadowDOMForAnyElementEnabled(true);
     13
    1114var host = document.getElementById('host');
    1215var shadowRoot = new WebKitShadowRoot(host)

  • trunk/LayoutTests/fast/dom/shadow/shadowdom-for-progress-dynamic.html

    r124754 r128856  
    1111
    1212<script>
     13if (window.internals)
     14    internals.settings.setAuthorShadowDOMForAnyElementEnabled(true);
     15
    1316if (window.testRunner)
    1417    testRunner.waitUntilDone();

  • trunk/LayoutTests/fast/dom/shadow/shadowdom-for-progress-multiple.html

    r124754 r128856  
    1414
    1515<script>
     16if (window.internals)
     17    internals.settings.setAuthorShadowDOMForAnyElementEnabled(true);
     18
    1619var shadowRoot = new WebKitShadowRoot(host);
    1720shadowRoot.innerHTML = "<shadow></shadow><span>(after)</span>";

  • trunk/LayoutTests/fast/dom/shadow/shadowdom-for-progress-with-style.html

    r124754 r128856  
    2626
    2727<script>
     28if (window.internals)
     29    internals.settings.setAuthorShadowDOMForAnyElementEnabled(true);
     30
    2831var shadowRoot = new WebKitShadowRoot(host);
    2932shadowRoot.innerHTML = "<div style='margin-left: 100px'><shadow></shadow><span>(after)</span></div>";

  • trunk/LayoutTests/fast/dom/shadow/shadowdom-for-progress-without-appearance.html

    r124754 r128856  
    1818
    1919<script>
     20if (window.internals)
     21    internals.settings.setAuthorShadowDOMForAnyElementEnabled(true);
     22
    2023var shadowRoot = new WebKitShadowRoot(host);
    2124shadowRoot.innerHTML = "<shadow></shadow><span>(after)</span>";

  • trunk/LayoutTests/fast/dom/shadow/shadowdom-for-progress-without-shadow-element.html

    r124754 r128856  
    1212
    1313<script>
     14if (window.internals)
     15    internals.settings.setAuthorShadowDOMForAnyElementEnabled(true);
     16
    1417var shadowRoot = new WebKitShadowRoot(host);
    1518shadowRoot.innerHTML = "<span>no progress</span>"

  • trunk/LayoutTests/fast/dom/shadow/shadowdom-for-progress.html

    r124754 r128856  
    1212
    1313<script>
     14if (window.internals)
     15    internals.settings.setAuthorShadowDOMForAnyElementEnabled(true);
     16
    1417var shadowRoot = new WebKitShadowRoot(host);
    1518shadowRoot.innerHTML = "<shadow></shadow><span>(after)</span>";

  • trunk/LayoutTests/fast/dom/shadow/shadowdom-for-textarea-complex-shadow.html

    r127108 r128856  
    1717
    1818<script>
     19if (window.internals)
     20    internals.settings.setAuthorShadowDOMForAnyElementEnabled(true);
     21
    1922var p = document.createElement('p');
    2023p.innerHTML = "paragraph<b>bold</b>paragraph";

  • trunk/LayoutTests/fast/dom/shadow/shadowdom-for-textarea-with-placeholder.html

    r127108 r128856  
    1010
    1111<script>
     12if (window.internals)
     13    internals.settings.setAuthorShadowDOMForAnyElementEnabled(true);
     14
    1215var shadowRoot1 = new WebKitShadowRoot(host);
    1316shadowRoot1.appendChild(document.createTextNode('before'));

  • trunk/LayoutTests/fast/dom/shadow/shadowdom-for-textarea-without-shadow.html

    r127108 r128856  
    99
    1010<script>
     11if (window.internals)
     12    internals.settings.setAuthorShadowDOMForAnyElementEnabled(true);
     13
    1114var shadowRoot = new WebKitShadowRoot(host);
    1215</script>

  • trunk/LayoutTests/fast/dom/shadow/shadowdom-for-textarea.html

    r127108 r128856  
    99
    1010<script>
     11if (window.internals)
     12    internals.settings.setAuthorShadowDOMForAnyElementEnabled(true);
     13
    1114var shadowRoot = new WebKitShadowRoot(host);
    1215

  • trunk/Source/WebCore/ChangeLog

    r128851 r128856  
     12012-09-18  Shinya Kawanaka  <shinyak@chromium.org>
     2
     3        Disable adding an AuthorShadowRoot to replaced elements.
     4        https://bugs.webkit.org/show_bug.cgi?id=96978
     5
     6        Reviewed by Hajime Morita.
     7
     8        We (people who implement Shadow DOM) have concluded that we don't support adding AuthorShadowRoot to
     9        replaced elements in the current spec, since it turned out that a lot of difficulties exist and it brings
     10        a lot of mess to our codebase.
     11
     12        For now, we just disable adding AuthorShadowRoot to these replaced elements.
     13
     14        Test: fast/dom/shadow/shadow-disable.html
     15
     16        * html/HTMLImageElement.h:
     17        * html/HTMLKeygenElement.h:
     18        * html/HTMLMeterElement.h:
     19        * html/HTMLProgressElement.h:
     20        * html/HTMLTextAreaElement.h:
     21
    1222012-09-17  Csaba Osztrogonác  <ossy@webkit.org>
    223

  • trunk/Source/WebCore/html/HTMLImageElement.h

    r128730 r128856  
    9898    virtual void createShadowSubtree();
    9999
     100    virtual bool areAuthorShadowsAllowed() const OVERRIDE { return false; }
     101
    100102    // Implementation of ImageLoaderClient
    101103    Element* sourceElement() { return this; }

  • trunk/Source/WebCore/html/HTMLKeygenElement.h

    r122414 r128856  
    4040    HTMLKeygenElement(const QualifiedName&, Document*, HTMLFormElement*);
    4141
     42    virtual bool areAuthorShadowsAllowed() const OVERRIDE { return false; }
     43
    4244    virtual bool canStartSelection() const { return false; }
    4345

  • trunk/Source/WebCore/html/HTMLMeterElement.h

    r125659 r128856  
    7070
    7171    virtual void willAddAuthorShadowRoot() OVERRIDE;
     72    virtual bool areAuthorShadowsAllowed() const OVERRIDE { return false; }
    7273    RenderMeter* renderMeter() const;
    7374

  • trunk/Source/WebCore/html/HTMLProgressElement.h

    r125985 r128856  
    5656
    5757    virtual void willAddAuthorShadowRoot() OVERRIDE;
     58    virtual bool areAuthorShadowsAllowed() const OVERRIDE { return false; }
    5859
    5960    virtual bool supportLabels() const OVERRIDE { return true; }

  • trunk/Source/WebCore/html/HTMLTextAreaElement.h

    r126842 r128856  
    6767
    6868    void createShadowSubtree();
     69    virtual bool areAuthorShadowsAllowed() const OVERRIDE { return false; }
    6970
    7071    void handleBeforeTextInsertedEvent(BeforeTextInsertedEvent*) const;
Note: See TracChangeset for help on using the changeset viewer.