Changeset 128876 in webkit


Ignore:
Timestamp:
Sep 18, 2012 5:05:31 AM (12 years ago)
Author:
commit-queue@webkit.org
Message:

[EFL] Remove background view on EWebLauncher and MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=96905

Patch by Seokju Kwon <seokju.kwon@samsung.com> on 2012-09-18
Reviewed by Gyuyoung Kim.

The size of webview was changed after adding url bar.
And the background view is not necessary anymore, since it was used for debugging back in the day.

  • EWebLauncher/main.c:

(_ELauncher):
(on_ecore_evas_resize):
(browserCreate):

  • MiniBrowser/efl/main.c:

(_MiniBrowser):
(on_ecore_evas_resize):
(browserCreate):

Location:
trunk/Tools
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/Tools/ChangeLog

    r128874 r128876  
     12012-09-18  Seokju Kwon  <seokju.kwon@samsung.com>
     2
     3        [EFL] Remove background view on EWebLauncher and MiniBrowser
     4        https://bugs.webkit.org/show_bug.cgi?id=96905
     5
     6        Reviewed by Gyuyoung Kim.
     7
     8        The size of webview was changed after adding url bar.
     9        And the background view is not necessary anymore, since it was used for debugging back in the day.
     10
     11        * EWebLauncher/main.c:
     12        (_ELauncher):
     13        (on_ecore_evas_resize):
     14        (browserCreate):
     15        * MiniBrowser/efl/main.c:
     16        (_MiniBrowser):
     17        (on_ecore_evas_resize):
     18        (browserCreate):
     19
    1202012-09-18  Sergio Villar Senin  <svillar@igalia.com>
    221
  • trunk/Tools/EWebLauncher/main.c

    r128535 r128876  
    156156    Ecore_Evas *ee;
    157157    Evas *evas;
    158     Evas_Object *bg;
    159158    Evas_Object *browser;
    160159    Url_Bar *url_bar;
     
    243242    ELauncher *app;
    244243    Evas_Object *webview;
    245     Evas_Object *bg;
    246244    int w, h;
    247245
     
    251249    app = find_app_from_ee(ee);
    252250    url_bar_width_set(app->url_bar, w);
    253 
    254     bg = evas_object_name_find(ecore_evas_get(ee), "bg");
    255     evas_object_move(bg, 0, 0);
    256     evas_object_resize(bg, w, h);
    257251
    258252    webview = evas_object_name_find(ecore_evas_get(ee), "browser");
     
    692686        return quit(EINA_FALSE, "ERROR: could not get evas from evas-ecore\n");
    693687
    694     app->bg = evas_object_rectangle_add(app->evas);
    695     evas_object_name_set(app->bg, "bg");
    696     evas_object_color_set(app->bg, 255, 0, 255, 255);
    697     evas_object_move(app->bg, 0, 0);
    698     evas_object_resize(app->bg, geometry.w, geometry.h);
    699     evas_object_layer_set(app->bg, EVAS_LAYER_MIN);
    700     evas_object_show(app->bg);
    701 
    702688    if (userArgs->backingStore && !strcasecmp(userArgs->backingStore, "tiled")) {
    703689        app->browser = ewk_view_tiled_add(app->evas);
  • trunk/Tools/MiniBrowser/efl/main.c

    r127729 r128876  
    4242    Ecore_Evas *ee;
    4343    Evas *evas;
    44     Evas_Object *bg;
    4544    Evas_Object *browser;
    4645    Url_Bar *url_bar;
     
    8685{
    8786    Evas_Object *webview;
    88     Evas_Object *bg;
    8987    int w, h;
    9088
     
    9391    /* Resize URL bar */
    9492    url_bar_width_set(browser->url_bar, w);
    95 
    96     bg = evas_object_name_find(ecore_evas_get(ee), "bg");
    97     evas_object_move(bg, 0, 0);
    98     evas_object_resize(bg, w, h);
    9993
    10094    webview = evas_object_name_find(ecore_evas_get(ee), "browser");
     
    234228    app->evas = ecore_evas_get(app->ee);
    235229
    236     app->bg = evas_object_rectangle_add(app->evas);
    237     evas_object_name_set(app->bg, "bg");
    238     evas_object_size_hint_weight_set(app->bg, EVAS_HINT_EXPAND, EVAS_HINT_EXPAND);
    239 
    240     evas_object_move(app->bg, 0, 0);
    241     evas_object_resize(app->bg, DEFAULT_WIDTH, DEFAULT_HEIGHT);
    242     evas_object_color_set(app->bg, 255, 150, 150, 255);
    243     evas_object_show(app->bg);
    244 
    245230    /* Create webview */
    246231    app->browser = ewk_view_add(app->evas);
Note: See TracChangeset for help on using the changeset viewer.