Changeset 128906 in webkit
- Timestamp:
- Sep 18, 2012 10:51:22 AM (12 years ago)
- Location:
- trunk
- Files:
-
- 4 added
- 58 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r128904 r128906 1 2012-09-18 Julien Chaffraix <jchaffraix@webkit.org> 2 3 Tables without any descendant and auto logical width should have a 0px logical width 4 https://bugs.webkit.org/show_bug.cgi?id=95521 5 6 Reviewed by Abhishek Arya. 7 8 * fast/table/empty-table-should-take-no-space-expected.html: Added. 9 * fast/table/empty-table-should-take-no-space.html: Added. 10 * fast/table/fixed-table-layout/empty-table-should-take-no-space-fixed-layout-expected.html: Added. 11 * fast/table/fixed-table-layout/empty-table-should-take-no-space-fixed-layout.html: Added. 12 2 new tests to check that empty tables have 0px logical width. 13 14 * platform/chromium-linux/tables/mozilla/bugs/bug56563-expected.png: 15 * platform/chromium-win/tables/mozilla/bugs/bug56563-expected.txt: 16 * platform/mac/tables/mozilla/bugs/bug56563-expected.txt: 17 * platform/qt/tables/mozilla/bugs/bug56563-expected.txt: 18 * tables/mozilla/bugs/bug56563-expected.txt: 19 Progression. The table now is 2px wide as it has a 1px right & left border. 20 21 * platform/chromium-linux/fast/invalid/residual-style-expected.txt: 22 Progression. The changes are due to the tables shrinking which is expected. 23 24 * platform/chromium-linux/fast/forms/file/file-input-disabled-expected.txt: 25 * platform/chromium-mac/fast/forms/file/file-input-disabled-expected.txt: 26 * platform/chromium-mac/tables/mozilla/bugs/bug113235-2-expected.txt: 27 * platform/chromium-win-xp/fast/forms/file-input-disabled-expected.txt: 28 * platform/chromium-win/fast/forms/file/file-input-disabled-expected.txt: 29 * platform/chromium-win/fast/invalid/017-expected.txt: 30 * platform/chromium-win/fast/invalid/018-expected.txt: 31 * platform/chromium-win/fast/invalid/020-expected.txt: 32 * platform/chromium-win/fast/invalid/table-inside-stray-table-content-expected.txt: 33 * platform/chromium-win/tables/mozilla/bugs/bug113235-2-expected.txt: 34 * platform/chromium-win/tables/mozilla/bugs/bug23994-expected.txt: 35 * platform/chromium-win/tables/mozilla/bugs/bug56405-expected.txt: 36 * platform/efl/fast/forms/file/file-input-disabled-expected.txt: 37 * platform/efl/fast/invalid/017-expected.txt: 38 * platform/efl/fast/invalid/018-expected.txt: 39 * platform/efl/fast/invalid/020-expected.txt: 40 * platform/efl/fast/invalid/table-inside-stray-table-content-expected.txt: 41 * platform/efl/fast/invalid/table-residual-style-crash-expected.txt: 42 * platform/efl/tables/mozilla/bugs/bug23994-expected.txt: 43 * platform/efl/tables/mozilla/bugs/bug56405-expected.txt: 44 * platform/gtk/fast/forms/file/file-input-disabled-expected.txt: 45 * platform/gtk/fast/invalid/017-expected.txt: 46 * platform/gtk/fast/invalid/018-expected.txt: 47 * platform/gtk/fast/invalid/020-expected.txt: 48 * platform/gtk/fast/invalid/table-inside-stray-table-content-expected.txt: 49 * platform/gtk/fast/invalid/table-residual-style-crash-expected.txt: 50 * platform/gtk/tables/mozilla/bugs/bug23994-expected.txt: 51 * platform/gtk/tables/mozilla/bugs/bug56405-expected.txt: 52 * platform/mac/fast/forms/file/file-input-disabled-expected.txt: 53 * platform/mac/fast/invalid/017-expected.txt: 54 * platform/mac/fast/invalid/018-expected.txt: 55 * platform/mac/fast/invalid/020-expected.txt: 56 * platform/mac/fast/invalid/table-inside-stray-table-content-expected.txt: 57 * platform/mac/fast/invalid/table-residual-style-crash-expected.txt: 58 * platform/mac/tables/mozilla/bugs/bug113235-2-expected.txt: 59 * platform/mac/tables/mozilla/bugs/bug23994-expected.txt: 60 * platform/mac/tables/mozilla/bugs/bug56405-expected.txt: 61 * platform/qt/fast/forms/file/file-input-disabled-expected.txt: 62 * platform/qt/fast/invalid/017-expected.txt: 63 * platform/qt/fast/invalid/018-expected.txt: 64 * platform/qt/fast/invalid/020-expected.txt: 65 * platform/qt/fast/invalid/table-inside-stray-table-content-expected.txt: 66 * platform/qt/fast/invalid/table-residual-style-crash-expected.txt: 67 * platform/qt/tables/mozilla/bugs/bug113235-2-expected.txt: 68 * platform/qt/tables/mozilla/bugs/bug23994-expected.txt: 69 * platform/qt/tables/mozilla/bugs/bug56405-expected.txt: 70 * platform/win/fast/forms/file-input-disabled-expected.txt: 71 * platform/win/fast/forms/file/file-input-disabled-expected.txt: 72 * tables/mozilla/bugs/bug113235-2-expected.txt: 73 Progression. The tables now have a 0px logical width. In some cases, we add the border-spacing in the 74 block-flow direction if we have a row. This is not consistently handled by browsers and not very well 75 defined in CSS. 76 1 77 2012-09-18 Zan Dobersek <zandobersek@gmail.com> 2 78 -
trunk/LayoutTests/platform/chromium-linux/fast/forms/file/file-input-disabled-expected.txt
r102411 r128906 20 20 text run at (0,0) width 69: "Choose File" 21 21 RenderBR {BR} at (324,59) size 0x0 22 RenderTable {TABLE} at (0,67) size 2x022 RenderTable {TABLE} at (0,67) size 0x0 -
trunk/LayoutTests/platform/chromium-linux/fast/invalid/residual-style-expected.txt
r117821 r128906 142 142 RenderText {#text} at (0,0) size 76x19 143 143 text run at (0,0) width 76: "CAPTION: " 144 RenderInline {FONT} at (0,0) size 16 2x19 [color=#008000]145 RenderTable {TABLE} at (76,15) size 2x0146 RenderBlock {CAPTION} at (0,0) size 2x0144 RenderInline {FONT} at (0,0) size 160x19 [color=#008000] 145 RenderTable {TABLE} at (76,15) size 0x0 146 RenderBlock {CAPTION} at (0,0) size 0x0 147 147 RenderInline {FONT} at (0,0) size 0x0 [color=#FF0000] 148 RenderText {#text} at (7 8,0) size 160x19149 text run at (7 8,0) width 160: "All of this should be green."148 RenderText {#text} at (76,0) size 160x19 149 text run at (76,0) width 160: "All of this should be green." 150 150 RenderText {#text} at (0,0) size 0x0 151 151 RenderBlock {HR} at (0,641) size 769x3 [border: (1px inset #000000)] … … 183 183 RenderText {#text} at (0,0) size 39x19 184 184 text run at (0,0) width 39: "COL: " 185 RenderInline {FONT} at (0,0) size 16 2x19 [color=#008000]185 RenderInline {FONT} at (0,0) size 160x19 [color=#008000] 186 186 RenderInline {FONT} at (0,0) size 0x19 [color=#FF0000] 187 RenderTable {TABLE} at (39,15) size 2x0187 RenderTable {TABLE} at (39,15) size 0x0 188 188 RenderTableCol {COLGROUP} at (0,0) size 0x0 189 189 RenderTableCol {COL} at (0,0) size 0x0 190 190 RenderInline {FONT} at (0,0) size 160x19 [color=#FF0000] 191 RenderText {#text} at ( 41,0) size 160x19192 text run at ( 41,0) width 160: "All of this should be green."191 RenderText {#text} at (39,0) size 160x19 192 text run at (39,0) width 160: "All of this should be green." 193 193 RenderText {#text} at (0,0) size 0x0 194 194 RenderBlock {HR} at (0,793) size 769x3 [border: (1px inset #000000)] … … 196 196 RenderText {#text} at (0,0) size 92x19 197 197 text run at (0,0) width 92: "COLGROUP: " 198 RenderInline {FONT} at (0,0) size 16 2x19 [color=#008000]198 RenderInline {FONT} at (0,0) size 160x19 [color=#008000] 199 199 RenderInline {FONT} at (0,0) size 0x19 [color=#FF0000] 200 RenderTable {TABLE} at (92,15) size 2x0200 RenderTable {TABLE} at (92,15) size 0x0 201 201 RenderTableCol {COLGROUP} at (0,0) size 0x0 202 202 RenderInline {FONT} at (0,0) size 160x19 [color=#FF0000] 203 RenderText {#text} at (9 4,0) size 160x19204 text run at (9 4,0) width 160: "All of this should be green."203 RenderText {#text} at (92,0) size 160x19 204 text run at (92,0) width 160: "All of this should be green." 205 205 RenderText {#text} at (0,0) size 0x0 206 206 RenderBlock {HR} at (0,831) size 769x3 [border: (1px inset #000000)] … … 720 720 RenderText {#text} at (0,0) size 55x19 721 721 text run at (0,0) width 55: "TABLE: " 722 RenderInline {FONT} at (0,0) size 16 2x19 [color=#008000]722 RenderInline {FONT} at (0,0) size 160x19 [color=#008000] 723 723 RenderInline {FONT} at (0,0) size 0x19 [color=#FF0000] 724 RenderTable {TABLE} at (55,15) size 2x0724 RenderTable {TABLE} at (55,15) size 0x0 725 725 RenderInline {FONT} at (0,0) size 160x19 [color=#FF0000] 726 RenderText {#text} at (5 7,0) size 160x19727 text run at (5 7,0) width 160: "All of this should be green."726 RenderText {#text} at (55,0) size 160x19 727 text run at (55,0) width 160: "All of this should be green." 728 728 RenderText {#text} at (0,0) size 0x0 729 729 RenderBlock (anonymous) at (0,3223) size 769x3 [color=#008000] 730 730 RenderBlock {HR} at (0,0) size 769x2 [border: (1px inset #008000)] 731 731 RenderBlock (anonymous) at (0,3233) size 769x21 732 RenderInline {FONT} at (0,0) size 22 2x19 [color=#008000]732 RenderInline {FONT} at (0,0) size 220x19 [color=#008000] 733 733 RenderText {#text} at (0,0) size 60x19 734 734 text run at (0,0) width 60: "TBODY: " 735 RenderInline {FONT} at (0,0) size 16 2x19735 RenderInline {FONT} at (0,0) size 160x19 736 736 RenderInline {FONT} at (0,0) size 0x19 737 RenderTable {TABLE} at (60,13) size 2x2738 RenderTableSection {TBODY} at (0,0) size 2x2737 RenderTable {TABLE} at (60,13) size 0x2 738 RenderTableSection {TBODY} at (0,0) size 0x2 739 739 RenderInline {FONT} at (0,0) size 160x19 740 RenderText {#text} at (6 2,0) size 160x19741 text run at (6 2,0) width 160: "All of this should be green."740 RenderText {#text} at (60,0) size 160x19 741 text run at (60,0) width 160: "All of this should be green." 742 742 RenderText {#text} at (0,0) size 0x0 743 743 RenderBlock (anonymous) at (0,3261) size 769x3 [color=#008000] … … 760 760 RenderBlock {HR} at (0,0) size 769x2 [border: (1px inset #008000)] 761 761 RenderBlock (anonymous) at (0,3309) size 769x21 762 RenderInline {FONT} at (0,0) size 2 20x19 [color=#008000]763 RenderInline {FONT} at (0,0) size 2 20x19762 RenderInline {FONT} at (0,0) size 218x19 [color=#008000] 763 RenderInline {FONT} at (0,0) size 218x19 764 764 RenderText {#text} at (0,0) size 58x19 765 765 text run at (0,0) width 58: "TFOOT: " 766 RenderInline {FONT} at (0,0) size 16 2x19766 RenderInline {FONT} at (0,0) size 160x19 767 767 RenderInline {FONT} at (0,0) size 0x19 768 RenderTable {TABLE} at (58,13) size 2x2769 RenderTableSection {TFOOT} at (0,0) size 2x2768 RenderTable {TABLE} at (58,13) size 0x2 769 RenderTableSection {TFOOT} at (0,0) size 0x2 770 770 RenderInline {FONT} at (0,0) size 160x19 771 RenderText {#text} at ( 60,0) size 160x19772 text run at ( 60,0) width 160: "All of this should be green."771 RenderText {#text} at (58,0) size 160x19 772 text run at (58,0) width 160: "All of this should be green." 773 773 RenderText {#text} at (0,0) size 0x0 774 774 RenderBlock (anonymous) at (0,3337) size 769x3 [color=#008000] 775 775 RenderBlock {HR} at (0,0) size 769x2 [border: (1px inset #008000)] 776 776 RenderBlock (anonymous) at (0,3347) size 769x21 777 RenderInline {FONT} at (0,0) size 2 20x19 [color=#008000]778 RenderInline {FONT} at (0,0) size 2 20x19779 RenderInline {FONT} at (0,0) size 2 20x19777 RenderInline {FONT} at (0,0) size 218x19 [color=#008000] 778 RenderInline {FONT} at (0,0) size 218x19 779 RenderInline {FONT} at (0,0) size 218x19 780 780 RenderText {#text} at (0,0) size 58x19 781 781 text run at (0,0) width 58: "THEAD: " 782 RenderInline {FONT} at (0,0) size 16 2x19782 RenderInline {FONT} at (0,0) size 160x19 783 783 RenderInline {FONT} at (0,0) size 0x19 784 RenderTable {TABLE} at (58,13) size 2x2785 RenderTableSection {THEAD} at (0,0) size 2x2784 RenderTable {TABLE} at (58,13) size 0x2 785 RenderTableSection {THEAD} at (0,0) size 0x2 786 786 RenderInline {FONT} at (0,0) size 160x19 787 RenderText {#text} at ( 60,0) size 160x19788 text run at ( 60,0) width 160: "All of this should be green."787 RenderText {#text} at (58,0) size 160x19 788 text run at (58,0) width 160: "All of this should be green." 789 789 RenderText {#text} at (0,0) size 0x0 790 790 RenderBlock (anonymous) at (0,3375) size 769x3 [color=#008000] 791 791 RenderBlock {HR} at (0,0) size 769x2 [border: (1px inset #008000)] 792 792 RenderBlock (anonymous) at (0,3385) size 769x21 793 RenderInline {FONT} at (0,0) size 18 8x19 [color=#008000]794 RenderInline {FONT} at (0,0) size 18 8x19795 RenderInline {FONT} at (0,0) size 18 8x19796 RenderInline {FONT} at (0,0) size 18 8x19793 RenderInline {FONT} at (0,0) size 186x19 [color=#008000] 794 RenderInline {FONT} at (0,0) size 186x19 795 RenderInline {FONT} at (0,0) size 186x19 796 RenderInline {FONT} at (0,0) size 186x19 797 797 RenderText {#text} at (0,0) size 26x19 798 798 text run at (0,0) width 26: "TR: " 799 RenderInline {FONT} at (0,0) size 16 2x19799 RenderInline {FONT} at (0,0) size 160x19 800 800 RenderInline {FONT} at (0,0) size 0x19 801 RenderTable {TABLE} at (26,11) size 2x4802 RenderTableSection {TBODY} at (0,0) size 2x4803 RenderTableRow {TR} at (0,2) size 2x0801 RenderTable {TABLE} at (26,11) size 0x4 802 RenderTableSection {TBODY} at (0,0) size 0x4 803 RenderTableRow {TR} at (0,2) size 0x0 804 804 RenderInline {FONT} at (0,0) size 160x19 805 RenderText {#text} at (2 8,0) size 160x19806 text run at (2 8,0) width 160: "All of this should be green."805 RenderText {#text} at (26,0) size 160x19 806 text run at (26,0) width 160: "All of this should be green." 807 807 RenderText {#text} at (0,0) size 0x0 808 808 RenderBlock (anonymous) at (0,3413) size 769x3 [color=#008000] -
trunk/LayoutTests/platform/chromium-mac/fast/forms/file/file-input-disabled-expected.txt
r117818 r128906 20 20 text run at (0,0) width 62: "Choose File" 21 21 RenderBR {BR} at (327,52) size 0x0 22 RenderTable {TABLE} at (0,59) size 2x022 RenderTable {TABLE} at (0,59) size 0x0 -
trunk/LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug113235-2-expected.txt
r117818 r128906 16 16 RenderText {#text} at (0,0) size 169x22 17 17 text run at (0,0) width 169: "Table of Contents" 18 RenderTable {TABLE} at (0,39) size 2x519 RenderTableSection {TBODY} at (0,0) size 2x420 RenderTableRow {TR} at (0,2) size 2x018 RenderTable {TABLE} at (0,39) size 0x5 19 RenderTableSection {TBODY} at (0,0) size 0x4 20 RenderTableRow {TR} at (0,2) size 0x0 21 21 RenderBlock (anonymous) at (0,74) size 784x1 22 22 RenderInline {FONT} at (0,0) size 0x0 -
trunk/LayoutTests/platform/chromium-win-xp/fast/forms/file-input-disabled-expected.txt
r96516 r128906 20 20 text run at (0,0) width 69: "Choose File" 21 21 RenderBR {BR} at (324,59) size 0x0 22 RenderTable {TABLE} at (0,67) size 2x022 RenderTable {TABLE} at (0,67) size 0x0 -
trunk/LayoutTests/platform/chromium-win/fast/forms/file/file-input-disabled-expected.txt
r102411 r128906 20 20 text run at (0,0) width 69: "Choose File" 21 21 RenderBR {BR} at (324,59) size 0x0 22 RenderTable {TABLE} at (0,67) size 2x022 RenderTable {TABLE} at (0,67) size 0x0 -
trunk/LayoutTests/platform/chromium-win/fast/invalid/017-expected.txt
r96509 r128906 10 10 RenderText {#text} at (0,0) size 147x19 11 11 text run at (0,0) width 147: "You should see this text." 12 RenderTable {TABLE} at (0,36) size 2x413 RenderTableSection {TBODY} at (0,0) size 2x414 RenderTableRow {TR} at (0,2) size 2x012 RenderTable {TABLE} at (0,36) size 0x4 13 RenderTableSection {TBODY} at (0,0) size 0x4 14 RenderTableRow {TR} at (0,2) size 0x0 -
trunk/LayoutTests/platform/chromium-win/fast/invalid/018-expected.txt
r96509 r128906 14 14 RenderTableCell {TD} at (2,2) size 2x2 [r=0 c=0 rs=1 cs=1] 15 15 RenderTableRow {TR} at (0,6) size 6x0 16 RenderTable {TABLE} at (0,8) size 2x417 RenderTableSection {TBODY} at (0,0) size 2x418 RenderTableRow {TR} at (0,2) size 2x016 RenderTable {TABLE} at (0,8) size 0x4 17 RenderTableSection {TBODY} at (0,0) size 0x4 18 RenderTableRow {TR} at (0,2) size 0x0 19 19 RenderBlock (anonymous) at (0,12) size 784x0 20 20 RenderInline {FONT} at (0,0) size 0x0 -
trunk/LayoutTests/platform/chromium-win/fast/invalid/020-expected.txt
r96509 r128906 7 7 RenderText {#text} at (0,0) size 27x19 8 8 text run at (0,0) width 27: "Text" 9 RenderTable {table} at (0,20) size 2x09 RenderTable {table} at (0,20) size 0x0 10 10 RenderTable at (0,20) size 0x0 11 11 RenderTableCol {colgroup} at (0,0) size 0x0 -
trunk/LayoutTests/platform/chromium-win/fast/invalid/table-inside-stray-table-content-expected.txt
r96509 r128906 10 10 RenderBlock {DIV} at (2,2) size 780x50 [border: (10px solid #008000)] 11 11 RenderBlock {DIV} at (10,10) size 760x14 [border: (2px solid #0000FF)] 12 RenderTable {TABLE} at (2,52) size 2x012 RenderTable {TABLE} at (2,52) size 0x0 13 13 RenderTable {TABLE} at (2,52) size 46x32 [border: (2px outset #808080)] 14 14 RenderTableSection {TBODY} at (2,2) size 42x28 -
trunk/LayoutTests/platform/chromium-win/tables/mozilla/bugs/bug113235-2-expected.txt
r117821 r128906 16 16 RenderText {#text} at (0,0) size 169x24 17 17 text run at (0,0) width 169: "Table of Contents" 18 RenderTable {TABLE} at (0,41) size 2x519 RenderTableSection {TBODY} at (0,0) size 2x420 RenderTableRow {TR} at (0,2) size 2x018 RenderTable {TABLE} at (0,41) size 0x5 19 RenderTableSection {TBODY} at (0,0) size 0x4 20 RenderTableRow {TR} at (0,2) size 0x0 21 21 RenderBlock (anonymous) at (0,77) size 784x1 22 22 RenderInline {FONT} at (0,0) size 0x0 -
trunk/LayoutTests/platform/chromium-win/tables/mozilla/bugs/bug23994-expected.txt
r96509 r128906 7 7 RenderText {#text} at (0,0) size 9x19 8 8 text run at (0,0) width 9: ">" 9 RenderTable {TABLE} at (0,20) size 2x010 RenderBlock {CAPTION} at (0,0) size 2x09 RenderTable {TABLE} at (0,20) size 0x0 10 RenderBlock {CAPTION} at (0,0) size 0x0 -
trunk/LayoutTests/platform/chromium-win/tables/mozilla/bugs/bug56405-expected.txt
r96509 r128906 4 4 RenderBlock {HTML} at (0,0) size 785x1140 5 5 RenderBody {BODY} at (8,8) size 769x1124 6 RenderTable {TABLE} at (0,0) size 2x10786 RenderTable {TABLE} at (0,0) size 0x1078 7 7 RenderTable {TABLE} at (0,1078) size 98x26 8 8 RenderTableSection {TBODY} at (0,0) size 98x26 -
trunk/LayoutTests/platform/chromium-win/tables/mozilla/bugs/bug56563-expected.txt
r96509 r128906 14 14 RenderImage {IMG} at (0,0) size 126x40 15 15 RenderText {#text} at (0,0) size 0x0 16 RenderTable {TABLE} at (0,92) size 4x2 [border: (1px outset #808080)]16 RenderTable {TABLE} at (0,92) size 2x2 [border: (1px outset #808080)] -
trunk/LayoutTests/platform/efl/fast/forms/file/file-input-disabled-expected.txt
r126750 r128906 20 20 text run at (0,0) width 87: "Choose File" 21 21 RenderBR {BR} at (396,66) size 0x0 22 RenderTable {TABLE} at (0,83) size 2x022 RenderTable {TABLE} at (0,83) size 0x0 -
trunk/LayoutTests/platform/efl/fast/invalid/017-expected.txt
r106181 r128906 10 10 RenderText {#text} at (0,0) size 155x19 11 11 text run at (0,0) width 155: "You should see this text." 12 RenderTable {TABLE} at (0,34) size 2x413 RenderTableSection {TBODY} at (0,0) size 2x414 RenderTableRow {TR} at (0,2) size 2x012 RenderTable {TABLE} at (0,34) size 0x4 13 RenderTableSection {TBODY} at (0,0) size 0x4 14 RenderTableRow {TR} at (0,2) size 0x0 -
trunk/LayoutTests/platform/efl/fast/invalid/018-expected.txt
r106181 r128906 14 14 RenderTableCell {TD} at (2,2) size 2x2 [r=0 c=0 rs=1 cs=1] 15 15 RenderTableRow {TR} at (0,6) size 6x0 16 RenderTable {TABLE} at (0,8) size 2x417 RenderTableSection {TBODY} at (0,0) size 2x418 RenderTableRow {TR} at (0,2) size 2x016 RenderTable {TABLE} at (0,8) size 0x4 17 RenderTableSection {TBODY} at (0,0) size 0x4 18 RenderTableRow {TR} at (0,2) size 0x0 19 19 RenderBlock (anonymous) at (0,12) size 784x0 20 20 RenderInline {FONT} at (0,0) size 0x0 -
trunk/LayoutTests/platform/efl/fast/invalid/020-expected.txt
r106181 r128906 7 7 RenderText {#text} at (0,0) size 29x19 8 8 text run at (0,0) width 29: "Text" 9 RenderTable {table} at (0,18) size 2x09 RenderTable {table} at (0,18) size 0x0 10 10 RenderTable at (0,18) size 0x0 11 11 RenderTableCol {colgroup} at (0,0) size 0x0 -
trunk/LayoutTests/platform/efl/fast/invalid/table-inside-stray-table-content-expected.txt
r106181 r128906 10 10 RenderBlock {DIV} at (2,2) size 780x50 [border: (10px solid #008000)] 11 11 RenderBlock {DIV} at (10,10) size 760x14 [border: (2px solid #0000FF)] 12 RenderTable {TABLE} at (2,52) size 2x012 RenderTable {TABLE} at (2,52) size 0x0 13 13 RenderTable {TABLE} at (2,52) size 48x30 [border: (2px outset #808080)] 14 14 RenderTableSection {TBODY} at (2,2) size 44x26 -
trunk/LayoutTests/platform/efl/fast/invalid/table-residual-style-crash-expected.txt
r97999 r128906 11 11 RenderBlock (anonymous) at (0,0) size 784x0 12 12 RenderInline {FONT} at (0,0) size 0x0 13 RenderTable {TABLE} at (0,0) size 2x013 RenderTable {TABLE} at (0,0) size 0x0 -
trunk/LayoutTests/platform/efl/tables/mozilla/bugs/bug23994-expected.txt
r106182 r128906 7 7 RenderText {#text} at (0,0) size 9x19 8 8 text run at (0,0) width 9: ">" 9 RenderTable {TABLE} at (0,18) size 2x010 RenderBlock {CAPTION} at (0,0) size 2x09 RenderTable {TABLE} at (0,18) size 0x0 10 RenderBlock {CAPTION} at (0,0) size 0x0 -
trunk/LayoutTests/platform/efl/tables/mozilla/bugs/bug56405-expected.txt
r106182 r128906 4 4 RenderBlock {HTML} at (0,0) size 785x1136 5 5 RenderBody {BODY} at (8,8) size 769x1120 6 RenderTable {TABLE} at (0,0) size 2x10786 RenderTable {TABLE} at (0,0) size 0x1078 7 7 RenderTable {TABLE} at (0,1078) size 102x24 8 8 RenderTableSection {TBODY} at (0,0) size 102x24 -
trunk/LayoutTests/platform/gtk/fast/forms/file/file-input-disabled-expected.txt
r114833 r128906 20 20 text run at (0,0) width 87: "Choose File" 21 21 RenderBR {BR} at (396,61) size 0x0 22 RenderTable {TABLE} at (0,71) size 2x022 RenderTable {TABLE} at (0,71) size 0x0 -
trunk/LayoutTests/platform/gtk/fast/invalid/017-expected.txt
r114836 r128906 10 10 RenderText {#text} at (0,0) size 155x19 11 11 text run at (0,0) width 155: "You should see this text." 12 RenderTable {TABLE} at (0,34) size 2x413 RenderTableSection {TBODY} at (0,0) size 2x414 RenderTableRow {TR} at (0,2) size 2x012 RenderTable {TABLE} at (0,34) size 0x4 13 RenderTableSection {TBODY} at (0,0) size 0x4 14 RenderTableRow {TR} at (0,2) size 0x0 -
trunk/LayoutTests/platform/gtk/fast/invalid/018-expected.txt
r114836 r128906 14 14 RenderTableCell {TD} at (2,2) size 2x2 [r=0 c=0 rs=1 cs=1] 15 15 RenderTableRow {TR} at (0,6) size 6x0 16 RenderTable {TABLE} at (0,8) size 2x417 RenderTableSection {TBODY} at (0,0) size 2x418 RenderTableRow {TR} at (0,2) size 2x016 RenderTable {TABLE} at (0,8) size 0x4 17 RenderTableSection {TBODY} at (0,0) size 0x4 18 RenderTableRow {TR} at (0,2) size 0x0 19 19 RenderBlock (anonymous) at (0,12) size 784x0 20 20 RenderInline {FONT} at (0,0) size 0x0 -
trunk/LayoutTests/platform/gtk/fast/invalid/020-expected.txt
r114836 r128906 7 7 RenderText {#text} at (0,0) size 29x19 8 8 text run at (0,0) width 29: "Text" 9 RenderTable {table} at (0,18) size 2x09 RenderTable {table} at (0,18) size 0x0 10 10 RenderTable at (0,18) size 0x0 11 11 RenderTableCol {colgroup} at (0,0) size 0x0 -
trunk/LayoutTests/platform/gtk/fast/invalid/table-inside-stray-table-content-expected.txt
r114836 r128906 10 10 RenderBlock {DIV} at (2,2) size 780x50 [border: (10px solid #008000)] 11 11 RenderBlock {DIV} at (10,10) size 760x14 [border: (2px solid #0000FF)] 12 RenderTable {TABLE} at (2,52) size 2x012 RenderTable {TABLE} at (2,52) size 0x0 13 13 RenderTable {TABLE} at (2,52) size 48x30 [border: (2px outset #808080)] 14 14 RenderTableSection {TBODY} at (2,2) size 44x26 -
trunk/LayoutTests/platform/gtk/fast/invalid/table-residual-style-crash-expected.txt
r96509 r128906 11 11 RenderBlock (anonymous) at (0,0) size 784x0 12 12 RenderInline {FONT} at (0,0) size 0x0 13 RenderTable {TABLE} at (0,0) size 2x013 RenderTable {TABLE} at (0,0) size 0x0 -
trunk/LayoutTests/platform/gtk/tables/mozilla/bugs/bug23994-expected.txt
r114836 r128906 7 7 RenderText {#text} at (0,0) size 9x19 8 8 text run at (0,0) width 9: ">" 9 RenderTable {TABLE} at (0,18) size 2x010 RenderBlock {CAPTION} at (0,0) size 2x09 RenderTable {TABLE} at (0,18) size 0x0 10 RenderBlock {CAPTION} at (0,0) size 0x0 -
trunk/LayoutTests/platform/gtk/tables/mozilla/bugs/bug56405-expected.txt
r114836 r128906 4 4 RenderBlock {HTML} at (0,0) size 785x1136 5 5 RenderBody {BODY} at (8,8) size 769x1120 6 RenderTable {TABLE} at (0,0) size 2x10786 RenderTable {TABLE} at (0,0) size 0x1078 7 7 RenderTable {TABLE} at (0,1078) size 102x24 8 8 RenderTableSection {TBODY} at (0,0) size 102x24 -
trunk/LayoutTests/platform/mac/fast/forms/file/file-input-disabled-expected.txt
r96918 r128906 20 20 text run at (0,0) width 62: "Choose File" 21 21 RenderBR {BR} at (327,52) size 0x0 22 RenderTable {TABLE} at (0,59) size 2x022 RenderTable {TABLE} at (0,59) size 0x0 -
trunk/LayoutTests/platform/mac/fast/invalid/017-expected.txt
r96573 r128906 10 10 RenderText {#text} at (0,0) size 155x18 11 11 text run at (0,0) width 155: "You should see this text." 12 RenderTable {TABLE} at (0,34) size 2x413 RenderTableSection {TBODY} at (0,0) size 2x414 RenderTableRow {TR} at (0,2) size 2x012 RenderTable {TABLE} at (0,34) size 0x4 13 RenderTableSection {TBODY} at (0,0) size 0x4 14 RenderTableRow {TR} at (0,2) size 0x0 -
trunk/LayoutTests/platform/mac/fast/invalid/018-expected.txt
r96573 r128906 14 14 RenderTableCell {TD} at (2,2) size 2x2 [r=0 c=0 rs=1 cs=1] 15 15 RenderTableRow {TR} at (0,6) size 6x0 16 RenderTable {TABLE} at (0,8) size 2x417 RenderTableSection {TBODY} at (0,0) size 2x418 RenderTableRow {TR} at (0,2) size 2x016 RenderTable {TABLE} at (0,8) size 0x4 17 RenderTableSection {TBODY} at (0,0) size 0x4 18 RenderTableRow {TR} at (0,2) size 0x0 19 19 RenderBlock (anonymous) at (0,12) size 784x0 20 20 RenderInline {FONT} at (0,0) size 0x0 -
trunk/LayoutTests/platform/mac/fast/invalid/020-expected.txt
r96573 r128906 7 7 RenderText {#text} at (0,0) size 29x18 8 8 text run at (0,0) width 29: "Text" 9 RenderTable {table} at (0,18) size 2x09 RenderTable {table} at (0,18) size 0x0 10 10 RenderTable at (0,18) size 0x0 11 11 RenderTableCol {colgroup} at (0,0) size 0x0 -
trunk/LayoutTests/platform/mac/fast/invalid/table-inside-stray-table-content-expected.txt
r96573 r128906 10 10 RenderBlock {DIV} at (2,2) size 780x50 [border: (10px solid #008000)] 11 11 RenderBlock {DIV} at (10,10) size 760x14 [border: (2px solid #0000FF)] 12 RenderTable {TABLE} at (2,52) size 2x012 RenderTable {TABLE} at (2,52) size 0x0 13 13 RenderTable {TABLE} at (2,52) size 48x30 [border: (2px outset #808080)] 14 14 RenderTableSection {TBODY} at (2,2) size 44x26 -
trunk/LayoutTests/platform/mac/fast/invalid/table-residual-style-crash-expected.txt
r96509 r128906 11 11 RenderBlock (anonymous) at (0,0) size 784x0 12 12 RenderInline {FONT} at (0,0) size 0x0 13 RenderTable {TABLE} at (0,0) size 2x013 RenderTable {TABLE} at (0,0) size 0x0 -
trunk/LayoutTests/platform/mac/tables/mozilla/bugs/bug113235-2-expected.txt
r96573 r128906 16 16 RenderText {#text} at (0,0) size 169x22 17 17 text run at (0,0) width 169: "Table of Contents" 18 RenderTable {TABLE} at (0,39) size 2x419 RenderTableSection {TBODY} at (0,0) size 2x420 RenderTableRow {TR} at (0,2) size 2x018 RenderTable {TABLE} at (0,39) size 0x4 19 RenderTableSection {TBODY} at (0,0) size 0x4 20 RenderTableRow {TR} at (0,2) size 0x0 21 21 RenderBlock (anonymous) at (0,74) size 784x0 22 22 RenderInline {FONT} at (0,0) size 0x0 -
trunk/LayoutTests/platform/mac/tables/mozilla/bugs/bug23994-expected.txt
r96573 r128906 7 7 RenderText {#text} at (0,0) size 9x18 8 8 text run at (0,0) width 9: ">" 9 RenderTable {TABLE} at (0,18) size 2x010 RenderBlock {CAPTION} at (0,0) size 2x09 RenderTable {TABLE} at (0,18) size 0x0 10 RenderBlock {CAPTION} at (0,0) size 0x0 -
trunk/LayoutTests/platform/mac/tables/mozilla/bugs/bug56405-expected.txt
r96573 r128906 4 4 RenderBlock {HTML} at (0,0) size 785x1136 5 5 RenderBody {BODY} at (8,8) size 769x1120 6 RenderTable {TABLE} at (0,0) size 2x10786 RenderTable {TABLE} at (0,0) size 0x1078 7 7 RenderTable {TABLE} at (0,1078) size 102x24 8 8 RenderTableSection {TBODY} at (0,0) size 102x24 -
trunk/LayoutTests/platform/mac/tables/mozilla/bugs/bug56563-expected.txt
r96573 r128906 14 14 RenderImage {IMG} at (0,0) size 126x40 15 15 RenderText {#text} at (0,0) size 0x0 16 RenderTable {TABLE} at (0,90) size 4x2 [border: (1px outset #808080)]16 RenderTable {TABLE} at (0,90) size 2x2 [border: (1px outset #808080)] -
trunk/LayoutTests/platform/qt/fast/forms/file/file-input-disabled-expected.txt
r122879 r128906 20 20 text run at (0,0) width 73: "Choose File" 21 21 RenderBR {BR} at (358,62) size 0x0 22 RenderTable {TABLE} at (0,74) size 2x022 RenderTable {TABLE} at (0,74) size 0x0 -
trunk/LayoutTests/platform/qt/fast/invalid/017-expected.txt
r123100 r128906 10 10 RenderText {#text} at (0,0) size 147x19 11 11 text run at (0,0) width 147: "You should see this text." 12 RenderTable {TABLE} at (0,35) size 2x413 RenderTableSection {TBODY} at (0,0) size 2x414 RenderTableRow {TR} at (0,2) size 2x012 RenderTable {TABLE} at (0,35) size 0x4 13 RenderTableSection {TBODY} at (0,0) size 0x4 14 RenderTableRow {TR} at (0,2) size 0x0 -
trunk/LayoutTests/platform/qt/fast/invalid/018-expected.txt
r123100 r128906 14 14 RenderTableCell {TD} at (2,2) size 2x2 [r=0 c=0 rs=1 cs=1] 15 15 RenderTableRow {TR} at (0,6) size 6x0 16 RenderTable {TABLE} at (0,8) size 2x417 RenderTableSection {TBODY} at (0,0) size 2x418 RenderTableRow {TR} at (0,2) size 2x016 RenderTable {TABLE} at (0,8) size 0x4 17 RenderTableSection {TBODY} at (0,0) size 0x4 18 RenderTableRow {TR} at (0,2) size 0x0 19 19 RenderBlock (anonymous) at (0,12) size 784x0 20 20 RenderInline {FONT} at (0,0) size 0x0 -
trunk/LayoutTests/platform/qt/fast/invalid/020-expected.txt
r124189 r128906 7 7 RenderText {#text} at (0,0) size 27x19 8 8 text run at (0,0) width 27: "Text" 9 RenderTable {table} at (0,19) size 2x09 RenderTable {table} at (0,19) size 0x0 10 10 RenderTable at (0,19) size 0x0 11 11 RenderTableCol {colgroup} at (0,0) size 0x0 -
trunk/LayoutTests/platform/qt/fast/invalid/table-inside-stray-table-content-expected.txt
r123100 r128906 10 10 RenderBlock {DIV} at (2,2) size 780x50 [border: (10px solid #008000)] 11 11 RenderBlock {DIV} at (10,10) size 760x14 [border: (2px solid #0000FF)] 12 RenderTable {TABLE} at (2,52) size 2x012 RenderTable {TABLE} at (2,52) size 0x0 13 13 RenderTable {TABLE} at (2,52) size 46x31 [border: (2px outset #808080)] 14 14 RenderTableSection {TBODY} at (2,2) size 42x27 -
trunk/LayoutTests/platform/qt/fast/invalid/table-residual-style-crash-expected.txt
r96509 r128906 11 11 RenderBlock (anonymous) at (0,0) size 784x0 12 12 RenderInline {FONT} at (0,0) size 0x0 13 RenderTable {TABLE} at (0,0) size 2x013 RenderTable {TABLE} at (0,0) size 0x0 -
trunk/LayoutTests/platform/qt/tables/mozilla/bugs/bug113235-2-expected.txt
r122719 r128906 16 16 RenderText {#text} at (0,0) size 169x24 17 17 text run at (0,0) width 169: "Table of Contents" 18 RenderTable {TABLE} at (0,40) size 2x419 RenderTableSection {TBODY} at (0,0) size 2x420 RenderTableRow {TR} at (0,2) size 2x018 RenderTable {TABLE} at (0,40) size 0x4 19 RenderTableSection {TBODY} at (0,0) size 0x4 20 RenderTableRow {TR} at (0,2) size 0x0 21 21 RenderBlock (anonymous) at (0,75) size 784x0 22 22 RenderInline {FONT} at (0,0) size 0x0 -
trunk/LayoutTests/platform/qt/tables/mozilla/bugs/bug23994-expected.txt
r123670 r128906 7 7 RenderText {#text} at (0,0) size 9x19 8 8 text run at (0,0) width 9: ">" 9 RenderTable {TABLE} at (0,19) size 2x010 RenderBlock {CAPTION} at (0,0) size 2x09 RenderTable {TABLE} at (0,19) size 0x0 10 RenderBlock {CAPTION} at (0,0) size 0x0 -
trunk/LayoutTests/platform/qt/tables/mozilla/bugs/bug56405-expected.txt
r123670 r128906 4 4 RenderBlock {HTML} at (0,0) size 784x1138 5 5 RenderBody {BODY} at (8,8) size 768x1122 6 RenderTable {TABLE} at (0,0) size 2x10786 RenderTable {TABLE} at (0,0) size 0x1078 7 7 RenderTable {TABLE} at (0,1078) size 98x25 8 8 RenderTableSection {TBODY} at (0,0) size 98x25 -
trunk/LayoutTests/platform/qt/tables/mozilla/bugs/bug56563-expected.txt
r122719 r128906 14 14 RenderImage {IMG} at (0,0) size 126x40 15 15 RenderText {#text} at (0,0) size 0x0 16 RenderTable {TABLE} at (0,91) size 4x2 [border: (1px outset #808080)]16 RenderTable {TABLE} at (0,91) size 2x2 [border: (1px outset #808080)] -
trunk/LayoutTests/platform/win/fast/forms/file-input-disabled-expected.txt
r80778 r128906 20 20 text run at (0,0) width 62: "Choose File" 21 21 RenderBR {BR} at (327,52) size 0x0 22 RenderTable {TABLE} at (0,59) size 4x022 RenderTable {TABLE} at (0,59) size 0x0 -
trunk/LayoutTests/platform/win/fast/forms/file/file-input-disabled-expected.txt
r119166 r128906 20 20 text run at (0,0) width 62: "Choose File" 21 21 RenderBR {BR} at (327,52) size 0x0 22 RenderTable {TABLE} at (0,59) size 2x022 RenderTable {TABLE} at (0,59) size 0x0 -
trunk/LayoutTests/tables/mozilla/bugs/bug113235-2-expected.txt
r117900 r128906 16 16 RenderText {#text} at (0,0) size 169x24 17 17 text run at (0,0) width 169: "Table of Contents" 18 RenderTable {TABLE} at (0,39) size 2x419 RenderTableSection {TBODY} at (0,0) size 2x420 RenderTableRow {TR} at (0,2) size 2x018 RenderTable {TABLE} at (0,39) size 0x4 19 RenderTableSection {TBODY} at (0,0) size 0x4 20 RenderTableRow {TR} at (0,2) size 0x0 21 21 RenderBlock (anonymous) at (0,74) size 784x0 22 22 RenderInline {FONT} at (0,0) size 0x0 -
trunk/LayoutTests/tables/mozilla/bugs/bug56563-expected.txt
r116839 r128906 14 14 RenderImage {IMG} at (0,0) size 126x40 15 15 RenderText {#text} at (0,0) size 0x0 16 RenderTable {TABLE} at (0,90) size 4x2 [border: (1px outset #808080)]16 RenderTable {TABLE} at (0,90) size 2x2 [border: (1px outset #808080)] -
trunk/Source/WebCore/ChangeLog
r128905 r128906 1 2012-09-18 Julien Chaffraix <jchaffraix@webkit.org> 2 3 Tables without any descendant and auto logical width should have a 0px logical width 4 https://bugs.webkit.org/show_bug.cgi?id=95521 5 6 Reviewed by Abhishek Arya. 7 8 The code would wrongly add the border-spacing in the row direction to the table's logical 9 width even if we didn't have a column. The new behavior matches FireFox and Opera. IE 10 matches our old behavior for inline tables but our new behavior for normal tables which 11 is a bug on their side. 12 13 Tests: fast/table/empty-table-should-take-no-space.html 14 fast/table/fixed-table-layout/empty-table-should-take-no-space-fixed-layout.html 15 16 * rendering/RenderTable.h: 17 (WebCore::RenderTable::borderSpacingInRowDirection): 18 Added this new helper function to return the right border-spacing. Added a FIXME as the code always 19 return the horizontal dimension which is wrong in vertical-writing mode. 20 21 (WebCore::RenderTable::bordersPaddingAndSpacingInRowDirection): 22 Changed to call borderSpacingInRowDirection. Added a comment as to why we don't add border-spacing on 23 border-collapse: separate tables. 24 1 25 2012-09-18 Zan Dobersek <zandobersek@gmail.com> 2 26 -
trunk/Source/WebCore/rendering/RenderTable.h
r128110 r128906 48 48 int getColumnPos(unsigned col) const { return m_columnPos[col]; } 49 49 50 // Per CSS 3 writing-mode: "The first and second values of the 'border-spacing' property represent spacing between columns 51 // and rows respectively, not necessarily the horizontal and vertical spacing respectively". 50 52 int hBorderSpacing() const { return m_hSpacing; } 51 53 int vBorderSpacing() const { return m_vSpacing; } … … 179 181 } 180 182 183 LayoutUnit borderSpacingInRowDirection() const 184 { 185 if (unsigned effectiveColumnCount = numEffCols()) 186 return static_cast<LayoutUnit>(effectiveColumnCount + 1) * hBorderSpacing(); 187 188 return ZERO_LAYOUT_UNIT; 189 } 190 181 191 LayoutUnit bordersPaddingAndSpacingInRowDirection() const 182 192 { 193 // 'border-spacing' only applies to separate borders (see 17.6.1 The separated borders model). 183 194 return borderStart() + borderEnd() + 184 (collapseBorders() ? ZERO_LAYOUT_UNIT : (paddingStart() + paddingEnd() + static_cast<LayoutUnit>(numEffCols() + 1) * hBorderSpacing()));195 (collapseBorders() ? ZERO_LAYOUT_UNIT : (paddingStart() + paddingEnd() + borderSpacingInRowDirection())); 185 196 } 186 197
Note: See TracChangeset
for help on using the changeset viewer.