Changeset 128910 in webkit


Ignore:
Timestamp:
Sep 18, 2012 11:02:36 AM (12 years ago)
Author:
commit-queue@webkit.org
Message:

Web Inspector: Set focus on the ExtensionPanel's iframe when it is selected
https://bugs.webkit.org/show_bug.cgi?id=96148

Patch by John J. Barton <johnjbarton@chromium.org> on 2012-09-18
Reviewed by Vsevolod Vlasov.

Source/WebCore:

ExtensionView ctor calls setDefaultFocusedElement with its iframe,
ExtensionPanel ctor calls setDefaultFocusedElement with the extensionView
and ExtensionPanel's setDefaultFocusedElement calls its grandparent impl

Tests: Added hasFocus test to extensions/extension-panel.html

  • inspector/front-end/ExtensionPanel.js:

(WebInspector.ExtensionPanel):
(WebInspector.ExtensionPanel.prototype.defaultFocusedElement):

  • inspector/front-end/ExtensionView.js:

(WebInspector.ExtensionView):

LayoutTests:

Add one line to verify that the panel's document has focus after show

  • inspector/extensions/extensions-panel-expected.txt:
  • inspector/extensions/extensions-panel.html:
Location:
trunk
Files:
6 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r128909 r128910  
     12012-09-18  John J. Barton  <johnjbarton@chromium.org>
     2
     3        Web Inspector: Set focus on the ExtensionPanel's iframe when it is selected
     4        https://bugs.webkit.org/show_bug.cgi?id=96148
     5
     6        Reviewed by Vsevolod Vlasov.
     7
     8        Add one line to verify that the panel's document has focus after show
     9
     10        * inspector/extensions/extensions-panel-expected.txt:
     11        * inspector/extensions/extensions-panel.html:
     12
    1132012-09-18  Ojan Vafai  <ojan@chromium.org>
    214
  • trunk/LayoutTests/inspector/extensions/extensions-panel-expected.txt

    r127147 r128910  
    2323}
    2424Panel shown
     25focused: true
    2526Extension panel size correct
    2627RUNNING TEST: extension_testSearch
  • trunk/LayoutTests/inspector/extensions/extensions-panel.html

    r125871 r128910  
    6666        }
    6767        output("Panel shown");
     68        output("focused: " + window.document.hasFocus());
    6869        panel.onShown.removeListener(onPanelShown);
    6970        evaluateOnFrontend("reply(InspectorTest.getPanelSize())", function(result) {
  • trunk/Source/WebCore/ChangeLog

    r128907 r128910  
     12012-09-18  John J. Barton  <johnjbarton@chromium.org>
     2
     3        Web Inspector: Set focus on the ExtensionPanel's iframe when it is selected
     4        https://bugs.webkit.org/show_bug.cgi?id=96148
     5
     6        Reviewed by Vsevolod Vlasov.
     7
     8        ExtensionView ctor calls setDefaultFocusedElement with its iframe,
     9        ExtensionPanel ctor calls setDefaultFocusedElement with the extensionView
     10        and ExtensionPanel's setDefaultFocusedElement calls its grandparent impl
     11
     12        Tests: Added hasFocus test to extensions/extension-panel.html
     13
     14        * inspector/front-end/ExtensionPanel.js:
     15        (WebInspector.ExtensionPanel):
     16        (WebInspector.ExtensionPanel.prototype.defaultFocusedElement):
     17        * inspector/front-end/ExtensionView.js:
     18        (WebInspector.ExtensionView):
     19
    1202012-09-18  Martin Robinson  <mrobinson@igalia.com>
    221
  • trunk/Source/WebCore/inspector/front-end/ExtensionPanel.js

    r125871 r128910  
    4242    var extensionView = new WebInspector.ExtensionView(id, pageURL, "extension panel");
    4343    extensionView.show(this.element);
     44    this.setDefaultFocusedElement(extensionView.defaultFocusedElement());
    4445}
    4546
     
    4748    defaultFocusedElement: function()
    4849    {
    49         return this.sidebarTreeElement || this.element;
     50        return WebInspector.View.prototype.defaultFocusedElement.call(this);
    5051    },
    5152
  • trunk/Source/WebCore/inspector/front-end/ExtensionView.js

    r123753 r128910  
    4646    this._iframe.src = src;
    4747    this._iframe.className = className;
     48    this.setDefaultFocusedElement(this._iframe);
    4849
    4950    this.element.appendChild(this._iframe);
Note: See TracChangeset for help on using the changeset viewer.