Changeset 128910 in webkit
- Timestamp:
- Sep 18, 2012 11:02:36 AM (12 years ago)
- Location:
- trunk
- Files:
-
- 6 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r128909 r128910 1 2012-09-18 John J. Barton <johnjbarton@chromium.org> 2 3 Web Inspector: Set focus on the ExtensionPanel's iframe when it is selected 4 https://bugs.webkit.org/show_bug.cgi?id=96148 5 6 Reviewed by Vsevolod Vlasov. 7 8 Add one line to verify that the panel's document has focus after show 9 10 * inspector/extensions/extensions-panel-expected.txt: 11 * inspector/extensions/extensions-panel.html: 12 1 13 2012-09-18 Ojan Vafai <ojan@chromium.org> 2 14 -
trunk/LayoutTests/inspector/extensions/extensions-panel-expected.txt
r127147 r128910 23 23 } 24 24 Panel shown 25 focused: true 25 26 Extension panel size correct 26 27 RUNNING TEST: extension_testSearch -
trunk/LayoutTests/inspector/extensions/extensions-panel.html
r125871 r128910 66 66 } 67 67 output("Panel shown"); 68 output("focused: " + window.document.hasFocus()); 68 69 panel.onShown.removeListener(onPanelShown); 69 70 evaluateOnFrontend("reply(InspectorTest.getPanelSize())", function(result) { -
trunk/Source/WebCore/ChangeLog
r128907 r128910 1 2012-09-18 John J. Barton <johnjbarton@chromium.org> 2 3 Web Inspector: Set focus on the ExtensionPanel's iframe when it is selected 4 https://bugs.webkit.org/show_bug.cgi?id=96148 5 6 Reviewed by Vsevolod Vlasov. 7 8 ExtensionView ctor calls setDefaultFocusedElement with its iframe, 9 ExtensionPanel ctor calls setDefaultFocusedElement with the extensionView 10 and ExtensionPanel's setDefaultFocusedElement calls its grandparent impl 11 12 Tests: Added hasFocus test to extensions/extension-panel.html 13 14 * inspector/front-end/ExtensionPanel.js: 15 (WebInspector.ExtensionPanel): 16 (WebInspector.ExtensionPanel.prototype.defaultFocusedElement): 17 * inspector/front-end/ExtensionView.js: 18 (WebInspector.ExtensionView): 19 1 20 2012-09-18 Martin Robinson <mrobinson@igalia.com> 2 21 -
trunk/Source/WebCore/inspector/front-end/ExtensionPanel.js
r125871 r128910 42 42 var extensionView = new WebInspector.ExtensionView(id, pageURL, "extension panel"); 43 43 extensionView.show(this.element); 44 this.setDefaultFocusedElement(extensionView.defaultFocusedElement()); 44 45 } 45 46 … … 47 48 defaultFocusedElement: function() 48 49 { 49 return this.sidebarTreeElement || this.element;50 return WebInspector.View.prototype.defaultFocusedElement.call(this); 50 51 }, 51 52 -
trunk/Source/WebCore/inspector/front-end/ExtensionView.js
r123753 r128910 46 46 this._iframe.src = src; 47 47 this._iframe.className = className; 48 this.setDefaultFocusedElement(this._iframe); 48 49 49 50 this.element.appendChild(this._iframe);
Note: See TracChangeset
for help on using the changeset viewer.