Changeset 129016 in webkit


Ignore:
Timestamp:
Sep 19, 2012 10:45:55 AM (12 years ago)
Author:
pilgrim@chromium.org
Message:

[Chromium] Remove unused popupsAllowed function from PlatformSupport
​https://bugs.webkit.org/show_bug.cgi?id=96521

Reviewed by Eric Seidel.

Part of a refactoring series. See tracking bug 82948.

Source/WebCore:

  • bindings/v8/NPV8Object.cpp:

(WebCore::v8ObjectToNPObject):
(_NPN_Evaluate):
(_NPN_GetProperty):

  • platform/chromium/PlatformSupport.h:

(PlatformSupport):

Source/WebKit/chromium:

  • src/PlatformSupport.cpp:

(WebCore):

Location:
trunk/Source
Files:
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r129010 r129016  
     12012-09-19  Mark Pilgrim  <pilgrim@chromium.org>
     2
     3        [Chromium] Remove unused popupsAllowed function from PlatformSupport
     4        https://bugs.webkit.org/show_bug.cgi?id=96521
     5
     6        Reviewed by Eric Seidel.
     7
     8        Part of a refactoring series. See tracking bug 82948.
     9
     10        * bindings/v8/NPV8Object.cpp:
     11        (WebCore::v8ObjectToNPObject):
     12        (_NPN_Evaluate):
     13        (_NPN_GetProperty):
     14        * platform/chromium/PlatformSupport.h:
     15        (PlatformSupport):
     16
    1172012-09-19  Jonathan Dong  <jonathan.dong@torchmobile.com.cn>
    218

  • trunk/Source/WebCore/bindings/v8/NPV8Object.cpp

    r128138 r129016  
    2929#include "NPV8Object.h"
    3030
    31 #include "PlatformSupport.h"
    3231#include "DOMWindow.h"
    3332#include "Frame.h"
    … …  
    297296bool _NPN_Evaluate(NPP npp, NPObject* npObject, NPString* npScript, NPVariant* result)
    298297{
    299     bool popupsAllowed = PlatformSupport::popupsAllowed(npp);
     298    // FIXME: Give the embedder a way to control this.
     299    bool popupsAllowed = false;
    300300    return _NPN_EvaluateHelper(npp, popupsAllowed, npObject, npScript, result);
    301301}

  • trunk/Source/WebCore/platform/chromium/PlatformSupport.h

    r128337 r129016  
    120120    static bool plugins(bool refresh, Vector<PluginInfo>*);
    121121    static NPObject* pluginScriptableObject(Widget*);
    122     static bool popupsAllowed(NPP);
    123122
    124123    // Screen -------------------------------------------------------------

  • trunk/Source/WebKit/chromium/ChangeLog

    r128972 r129016  
     12012-09-19  Mark Pilgrim  <pilgrim@chromium.org>
     2
     3        [Chromium] Remove unused popupsAllowed function from PlatformSupport
     4        https://bugs.webkit.org/show_bug.cgi?id=96521
     5
     6        Reviewed by Eric Seidel.
     7
     8        Part of a refactoring series. See tracking bug 82948.
     9
     10        * src/PlatformSupport.cpp:
     11        (WebCore):
     12
    1132012-09-19  Kent Tamura  <tkent@chromium.org>
    214

  • trunk/Source/WebKit/chromium/src/PlatformSupport.cpp

    r127623 r129016  
    567567}
    568568
    569 bool PlatformSupport::popupsAllowed(NPP npp)
    570 {
    571     // FIXME: Give the embedder a way to control this.
    572     return false;
    573 }
    574 
    575569#if ENABLE(WORKERS)
    576570WorkerContextProxy* WorkerContextProxy::create(Worker* worker)
Note: See TracChangeset for help on using the changeset viewer.