Changeset 129019 in webkit


Ignore:
Timestamp:
Sep 19, 2012 10:52:14 AM (12 years ago)
Author:
commit-queue@webkit.org
Message:

[EFL][WK2] fast/forms/select-writing-direction-natural.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=97082

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-19
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

WebChromeClient::selectItemWritingDirectionIsNatural() now returns
true for EFL-WK2, consistently with EFL-WK1, so that the style
is properly adjusted in RenderMenuList::adjustInnerStyle().

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::selectItemWritingDirectionIsNatural):

LayoutTests:

Rebaseline fast/forms/select-writing-direction-natural.html and
unskip it for efl-wk2.

  • platform/efl-wk2/TestExpectations:
  • platform/efl/fast/forms/select-writing-direction-natural-expected.png:
Location:
trunk
Files:
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r129018 r129019  
     12012-09-19  Christophe Dumez  <christophe.dumez@intel.com>
     2
     3        [EFL][WK2] fast/forms/select-writing-direction-natural.html is failing
     4        https://bugs.webkit.org/show_bug.cgi?id=97082
     5
     6        Reviewed by Kenneth Rohde Christiansen.
     7
     8        Rebaseline fast/forms/select-writing-direction-natural.html and
     9        unskip it for efl-wk2.
     10
     11        * platform/efl-wk2/TestExpectations:
     12        * platform/efl/fast/forms/select-writing-direction-natural-expected.png:
     13
    1142012-09-18  Dirk Schulze  <krit@webkit.org>
    215

  • trunk/LayoutTests/platform/efl-wk2/TestExpectations

    r128879 r129019  
    195195BUGWKEFL : fast/block/float/float-in-float-hit-testing.html = TEXT
    196196BUGWKEFL : fast/dom/Window/mozilla-focus-blur.html = TEXT
    197 BUGWKEFL : fast/forms/select-writing-direction-natural.html = TEXT
    198197BUGWKEFL : fast/frames/flattening/iframe-tiny.html = TEXT
    199198BUGWKEFL : fast/replaced/no-focus-ring-embed.html = TEXT

  • trunk/Source/WebKit2/ChangeLog

    r128989 r129019  
     12012-09-19  Christophe Dumez  <christophe.dumez@intel.com>
     2
     3        [EFL][WK2] fast/forms/select-writing-direction-natural.html is failing
     4        https://bugs.webkit.org/show_bug.cgi?id=97082
     5
     6        Reviewed by Kenneth Rohde Christiansen.
     7
     8        WebChromeClient::selectItemWritingDirectionIsNatural() now returns
     9        true for EFL-WK2, consistently with EFL-WK1, so that the style
     10        is properly adjusted in RenderMenuList::adjustInnerStyle().
     11
     12        * WebProcess/WebCoreSupport/WebChromeClient.cpp:
     13        (WebKit::WebChromeClient::selectItemWritingDirectionIsNatural):
     14
    1152012-09-19  Carlos Garcia Campos  <cgarcia@igalia.com>
    216

  • trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp

    r128623 r129019  
    659659bool WebChromeClient::selectItemWritingDirectionIsNatural()
    660660{
    661 #if PLATFORM(WIN)
     661#if PLATFORM(WIN) || PLATFORM(EFL)
    662662    return true;
    663663#else
Note: See TracChangeset for help on using the changeset viewer.