Changeset 129055 in webkit

Timestamp:

Sep 19, 2012 3:48:03 PM (12 years ago)

Author:

rniwa@webkit.org

Message:

REGRESSION: run-perf-tests no longer reports the total test time
​https://bugs.webkit.org/show_bug.cgi?id=97138

Reviewed by Tony Chang.

Report the finished time as a info-level log as opposed to a debug level log.

• Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner._run_single_test):

• Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:

(MainTest.normalizeFinishedTime): Added. It replaces all finished times by 0.1 seconds.
(test_run_test_pause_before_testing):
(test_run_test_set_for_parser_tests):
(test_run_memory_test):
(_test_run_with_json_output):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/performance_tests/perftestsrunner.py (modified) (1 diff)
• Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py (modified) (7 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2012-09-19  Ryosuke Niwa  <rniwa@webkit.org>
+
+        REGRESSION: run-perf-tests no longer reports the total test time
+        https://bugs.webkit.org/show_bug.cgi?id=97138
+
+        Reviewed by Tony Chang.
+
+        Report the finished time as a info-level log as opposed to a debug level log.
+
+        * Scripts/webkitpy/performance_tests/perftestsrunner.py:
+        (PerfTestsRunner._run_single_test):
+        * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
+        (MainTest.normalizeFinishedTime): Added. It replaces all finished times by 0.1 seconds.
+        (test_run_test_pause_before_testing):
+        (test_run_test_set_for_parser_tests):
+        (test_run_memory_test):
+        (_test_run_with_json_output):
+
 2012-09-19  Dirk Pranke  <dpranke@chromium.org>
 

trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py

@@ -318 +318 @@
             _log.error('FAILED')
 
-        _log.debug("Finished: %f s" % (time.time() - start_time))
+        _log.info("Finished: %f s" % (time.time() - start_time))
 
         return new_results != None

trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py

@@ -32 +32 @@
 import StringIO
 import json
+import re
 import unittest
 
@@ -48 +49 @@
     def assertWritten(self, stream, contents):
         self.assertEquals(stream.buflist, contents)
+
+    def normalizeFinishedTime(self, log):
+        return re.sub(r'Finished: [0-9\.]+ s', 'Finished: 0.1 s', log)
 
     class TestDriver:
@@ -235 +239 @@
             stdout, stderr, log = output.restore_output()
         self.assertEqual(stderr, "Ready to run test?\n")
-        self.assertEqual(log, "Running inspector/pass.html (1 of 1)\nRESULT group_name: test_name= 42 ms\n\n")
+        self.assertEqual(self.normalizeFinishedTime(log),
+            "Running inspector/pass.html (1 of 1)\nRESULT group_name: test_name= 42 ms\nFinished: 0.1 s\n\n")
 
     def test_run_test_set_for_parser_tests(self):
@@ -247 +252 @@
             stdout, stderr, log = output.restore_output()
         self.assertEqual(unexpected_result_count, 0)
-        self.assertEqual(log, '\n'.join(['Running Bindings/event-target-wrapper.html (1 of 2)',
+        self.assertEqual(self.normalizeFinishedTime(log), '\n'.join(['Running Bindings/event-target-wrapper.html (1 of 2)',
         'RESULT Bindings: event-target-wrapper= 1489.05 ms',
         'median= 1487.0 ms, stdev= 14.46 ms, min= 1471.0 ms, max= 1510.0 ms',
+        'Finished: 0.1 s',
         '',
         'Running Parser/some-parser.html (2 of 2)',
         'RESULT Parser: some-parser= 1100.0 ms',
         'median= 1101.0 ms, stdev= 11.0 ms, min= 1080.0 ms, max= 1120.0 ms',
+        'Finished: 0.1 s',
         '', '']))
 
@@ -268 +275 @@
             stdout, stderr, log = output.restore_output()
         self.assertEqual(unexpected_result_count, 0)
-        self.assertEqual(log, '\n'.join([
+        self.assertEqual(self.normalizeFinishedTime(log), '\n'.join([
             'Running 1 tests',
             'Running Parser/memory-test.html (1 of 1)',
@@ -277 +284 @@
             'RESULT Parser: memory-test: Malloc= 532000.0 bytes',
             'median= 529000.0 bytes, stdev= 13000.0 bytes, min= 511000.0 bytes, max= 548000.0 bytes',
+            'Finished: 0.1 s',
             '', '']))
         results = runner.load_output_json()[0]['results']
@@ -305 +313 @@
 
         if not expected_exit_code:
-            self.assertEqual(logs, '\n'.join([
-                'Running 2 tests',
+            self.assertEqual(self.normalizeFinishedTime(logs),
+                '\n'.join(['Running 2 tests',
                 'Running Bindings/event-target-wrapper.html (1 of 2)',
                 'RESULT Bindings: event-target-wrapper= 1489.05 ms',
                 'median= 1487.0 ms, stdev= 14.46 ms, min= 1471.0 ms, max= 1510.0 ms',
+                'Finished: 0.1 s',
                 '',
                 'Running inspector/pass.html (2 of 2)',
                 'RESULT group_name: test_name= 42 ms',
+                'Finished: 0.1 s',
                 '',
                 '']))