Changeset 129110 in webkit

Timestamp:

Sep 20, 2012 3:16:35 AM (12 years ago)

Author:

commit-queue@webkit.org

Message:

[EFL][DRT]DumpRenderTree needs to reset focus state when test starts.
​https://bugs.webkit.org/show_bug.cgi?id=97087

Patch by Michał Pakuła vel Rutka <Michał Pakuła vel Rutka> on 2012-09-20
Reviewed by Gyuyoung Kim.

Tools:

Add focusing a main frame on settings reset.
After editing/undo/undo-iframe-location-change was executed a frame
was left in unfocused state. This caused flakiness in two tests results.

• DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::resetDefaultsToConsistentValues):

LayoutTests:

Remove two flaky tests from TestExpectations as they pass after setting focus
on settings reset.

• platform/efl-wk1/TestExpectations:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/efl-wk1/TestExpectations (modified) (1 diff)
• Tools/ChangeLog (modified) (1 diff)
• Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2012-09-20  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
+
+        [EFL][DRT]DumpRenderTree needs to reset focus state when test starts.
+        https://bugs.webkit.org/show_bug.cgi?id=97087
+
+        Reviewed by Gyuyoung Kim.
+
+        Remove two flaky tests from TestExpectations as they pass after setting focus
+        on settings reset.
+
+        * platform/efl-wk1/TestExpectations:
+
 2012-09-20  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
 

trunk/LayoutTests/platform/efl-wk1/TestExpectations

@@ -39 +39 @@
 
 # Test passes, but editing delegates does not match expected ones
-Bug(EFL) editing/undo/undo-indent.html [ Failure Pass ]
-Bug(EFL) editing/undo/undo-misspellings.html [ Failure Pass ]
-
 webkit.org/b/96641 media/video-seek-past-end-playing.html [ Failure Pass ]
 webkit.org/b/96642 loader/go-back-to-different-window-size.html [ Failure Pass ]

trunk/Tools/ChangeLog

@@ +1 @@
+2012-09-20  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
+
+        [EFL][DRT]DumpRenderTree needs to reset focus state when test starts.
+        https://bugs.webkit.org/show_bug.cgi?id=97087
+
+        Reviewed by Gyuyoung Kim.
+
+        Add focusing a main frame on settings reset.
+        After editing/undo/undo-iframe-location-change was executed a frame
+        was left in unfocused state. This caused flakiness in two tests results.
+
+        * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
+        (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
+
 2012-09-20  Allan Sandfeld Jensen  <allan.jensen@digia.com>
 

trunk/Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp

@@ -293 +293 @@
     ewk_history_clear(ewk_view_history_get(mainView()));
 
+    ewk_frame_feed_focus_in(mainFrame());
+
     ewk_cookies_clear();
     ewk_cookies_policy_set(EWK_COOKIE_JAR_ACCEPT_NO_THIRD_PARTY);