Changeset 129120 in webkit


Ignore:
Timestamp:
Sep 20, 2012 5:05:56 AM (12 years ago)
Author:
commit-queue@webkit.org
Message:

[Qt] [WK1] Spaces missing in output of fast/forms/mailto/advanced-{get,put}.html
​https://bugs.webkit.org/show_bug.cgi?id=92551

Patch by Marcelo Lira <​marcelo.lira@openbossa.org> on 2012-09-20
Reviewed by Adam Barth.

The problem here is that the text input boxes are rendered differently
in chromium and qt/gtk/efl, causing the text dump to also differ.

There are 4 adjacent input boxes in a page 800 pixel wide, the width
of these inputs is unspecified, as it should since this is unrelated
to purpose of the test, and left for the port to decide. Chromium puts
the four in the same line, qt/gtk/efl breaks the line before the fourth
input, causing an extra space to appear in the text dump.

The test was corrected by defining a fixed width for the input
elements, ensuring the text dumps will be identical in all platforms,
eliminating the need for special expected files.

  • fast/forms/mailto/advanced-get.html:
  • fast/forms/mailto/advanced-put.html:
  • platform/efl/fast/forms/mailto/advanced-get-expected.txt: Removed.
  • platform/efl/fast/forms/mailto/advanced-put-expected.txt: Removed.
  • platform/gtk/fast/forms/mailto/advanced-get-expected.txt: Removed.
  • platform/gtk/fast/forms/mailto/advanced-put-expected.txt: Removed.
  • platform/qt-5.0-wk1/Skipped:
  • platform/qt-5.0-wk2/fast/forms/mailto/advanced-get-expected.txt: Removed.
  • platform/qt-5.0-wk2/fast/forms/mailto/advanced-put-expected.txt: Removed.
  • platform/qt-mac/Skipped:
Location:
trunk/LayoutTests
Files:
6 deleted
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r129118 r129120  
     12012-09-20  Marcelo Lira  <marcelo.lira@openbossa.org>
     2
     3        [Qt] [WK1] Spaces missing in output of fast/forms/mailto/advanced-{get,put}.html
     4        https://bugs.webkit.org/show_bug.cgi?id=92551
     5
     6        Reviewed by Adam Barth.
     7
     8        The problem here is that the text input boxes are rendered differently
     9        in chromium and qt/gtk/efl, causing the text dump to also differ.
     10
     11        There are 4 adjacent input boxes in a page 800 pixel wide, the width
     12        of these inputs is unspecified, as it should since this is unrelated
     13        to purpose of the test, and left for the port to decide. Chromium puts
     14        the four in the same line, qt/gtk/efl breaks the line before the fourth
     15        input, causing an extra space to appear in the text dump.
     16
     17        The test was corrected by defining a fixed width for the input
     18        elements, ensuring the text dumps will be identical in all platforms,
     19        eliminating the need for special expected files.
     20
     21        * fast/forms/mailto/advanced-get.html:
     22        * fast/forms/mailto/advanced-put.html:
     23        * platform/efl/fast/forms/mailto/advanced-get-expected.txt: Removed.
     24        * platform/efl/fast/forms/mailto/advanced-put-expected.txt: Removed.
     25        * platform/gtk/fast/forms/mailto/advanced-get-expected.txt: Removed.
     26        * platform/gtk/fast/forms/mailto/advanced-put-expected.txt: Removed.
     27        * platform/qt-5.0-wk1/Skipped:
     28        * platform/qt-5.0-wk2/fast/forms/mailto/advanced-get-expected.txt: Removed.
     29        * platform/qt-5.0-wk2/fast/forms/mailto/advanced-put-expected.txt: Removed.
     30        * platform/qt-mac/Skipped:
     31
    1322012-09-20  Otto Derek Cheung  <otcheung@rim.com>
    233

  • trunk/LayoutTests/fast/forms/mailto/advanced-get.html

    r121008 r129120  
    1212            }
    1313        </script>
     14        <style>input { width: 100px; } </style>
    1415    </head>
    1516    <body onload="test()">

  • trunk/LayoutTests/fast/forms/mailto/advanced-put.html

    r121008 r129120  
    1212            }
    1313        </script>
     14        <style>input { width: 100px; } </style>
    1415    </head>
    1516    <body onload="test()">

  • trunk/LayoutTests/platform/qt-5.0-wk1/Skipped

    r127097 r129120  
    4646fast/table/table-style-not-updated.html
    4747
    48 # [Qt] [WK1] Spaces missing in output of fast/forms/mailto/advanced-{get,put}.html
    49 # https://bugs.webkit.org/show_bug.cgi?id=92551
    50 fast/forms/mailto/advanced-get.html
    51 fast/forms/mailto/advanced-put.html
    52 
    5348# [Qt] Tests still fail after the update to new fonts
    5449# https://bugs.webkit.org/show_bug.cgi?id=91610

  • trunk/LayoutTests/platform/qt-mac/Skipped

    r127862 r129120  
    18091809fast/forms/textfield-outline.html
    18101810fast/forms/textfield-overflow.html
    1811 fast/forms/mailto/advanced-get.html
    1812 fast/forms/mailto/advanced-put.html
    18131811fast/forms/range/range-thumb-height-percentage.html
    18141812fast/forms/range/thumbslider-crash.html
Note: See TracChangeset for help on using the changeset viewer.