Changeset 129126 in webkit


Ignore:
Timestamp:
Sep 20, 2012 6:20:55 AM (12 years ago)
Author:
Csaba Osztrogonác
Message:

[Qt] Enable CSS regions by default
​https://bugs.webkit.org/show_bug.cgi?id=97196

Source/WebKit/qt:

Reviewed by Dirk Schulze.

  • Api/qwebsettings.cpp:

(QWebSettings::QWebSettings):

LayoutTests:

Add Qt specific expected results for non-reftests,
results are compared to Mac results manually.

Reviewed by Dirk Schulze.

  • platform/qt/Skipped: Unskip passing fast/regions tests, skip 3 failing reftest.
  • platform/qt/fast/regions/autoheight-regions-mark-expected.png: Added.
  • platform/qt/fast/regions/autoheight-regions-mark-expected.txt: Added.
  • platform/qt/fast/regions/bottom-overflow-out-of-first-region-expected.png: Added.
  • platform/qt/fast/regions/bottom-overflow-out-of-first-region-expected.txt: Added.
  • platform/qt/fast/regions/flow-content-basic-expected.png: Added.
  • platform/qt/fast/regions/flow-content-basic-expected.txt: Added.
  • platform/qt/fast/regions/flow-content-basic-vertical-expected.png: Added.
  • platform/qt/fast/regions/flow-content-basic-vertical-expected.txt: Added.
  • platform/qt/fast/regions/flow-content-basic-vertical-rl-expected.png: Added.
  • platform/qt/fast/regions/flow-content-basic-vertical-rl-expected.txt: Added.
  • platform/qt/fast/regions/flows-dependency-dynamic-remove-expected.png: Added.
  • platform/qt/fast/regions/flows-dependency-dynamic-remove-expected.txt: Added.
  • platform/qt/fast/regions/flows-dependency-same-flow-expected.png: Added.
  • platform/qt/fast/regions/flows-dependency-same-flow-expected.txt: Added.
  • platform/qt/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.png: Added.
  • platform/qt/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.txt: Added.
  • platform/qt/fast/regions/overflow-in-uniform-regions-dynamic-expected.png: Added.
  • platform/qt/fast/regions/overflow-in-uniform-regions-dynamic-expected.txt: Added.
  • platform/qt/fast/regions/overflow-in-variable-width-regions-expected.png: Added.
  • platform/qt/fast/regions/overflow-in-variable-width-regions-expected.txt: Added.
  • platform/qt/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.png: Added.
  • platform/qt/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.txt: Added.
  • platform/qt/fast/regions/overflow-not-moving-below-floats-in-variable-width-regions-expected.png: Added.
  • platform/qt/fast/regions/overflow-not-moving-below-floats-in-variable-width-regions-expected.txt: Added.
  • platform/qt/fast/regions/overflow-rtl-in-variable-width-regions-expected.png: Added.
  • platform/qt/fast/regions/overflow-rtl-in-variable-width-regions-expected.txt: Added.
  • platform/qt/fast/regions/overflow-size-change-in-variable-width-regions-expected.png: Added.
  • platform/qt/fast/regions/overflow-size-change-in-variable-width-regions-expected.txt: Added.
  • platform/qt/fast/regions/overflow-size-change-with-stacking-context-rtl-expected.png: Added.
  • platform/qt/fast/regions/overflow-size-change-with-stacking-context-rtl-expected.txt: Added.
  • platform/qt/fast/regions/percentage-margins-mixed-ltr-dominant-regions-expected.png: Added.
  • platform/qt/fast/regions/percentage-margins-mixed-ltr-dominant-regions-expected.txt: Added.
  • platform/qt/fast/regions/percentage-margins-mixed-rtl-dominant-regions-expected.png: Added.
  • platform/qt/fast/regions/percentage-margins-mixed-rtl-dominant-regions-expected.txt: Added.
  • platform/qt/fast/regions/percentage-margins-rtl-variable-width-regions-expected.png: Added.
  • platform/qt/fast/regions/percentage-margins-rtl-variable-width-regions-expected.txt: Added.
  • platform/qt/fast/regions/percentage-margins-variable-width-regions-expected.png: Added.
  • platform/qt/fast/regions/percentage-margins-variable-width-regions-expected.txt: Added.
  • platform/qt/fast/regions/region-overflow-auto-overflow-hidden-expected.png: Added.
  • platform/qt/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Added.
  • platform/qt/fast/regions/region-overflow-auto-overflow-visible-expected.png: Added.
  • platform/qt/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Added.
  • platform/qt/fast/regions/region-style-block-background-color-expected.png: Added.
  • platform/qt/fast/regions/region-style-block-background-color-expected.txt: Added.
  • platform/qt/fast/regions/region-style-block-background-color2-expected.png: Added.
  • platform/qt/fast/regions/region-style-block-background-color2-expected.txt: Added.
  • platform/qt/fast/regions/text-region-split-small-pagination-expected.png: Added.
  • platform/qt/fast/regions/text-region-split-small-pagination-expected.txt: Added.
  • platform/qt/fast/regions/top-overflow-out-of-second-region-expected.png: Added.
  • platform/qt/fast/regions/top-overflow-out-of-second-region-expected.txt: Added.
  • platform/qt/fast/regions/webkit-flow-double-pagination-float-push-expected.png: Added.
  • platform/qt/fast/regions/webkit-flow-double-pagination-float-push-expected.txt: Added.
  • platform/qt/fast/regions/webkit-flow-float-pushed-to-last-region-expected.png: Added.
  • platform/qt/fast/regions/webkit-flow-float-pushed-to-last-region-expected.txt: Added.
  • platform/qt/fast/regions/webkit-flow-float-unable-to-push-expected.png: Added.
  • platform/qt/fast/regions/webkit-flow-float-unable-to-push-expected.txt: Added.
  • platform/qt/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.png: Added.
  • platform/qt/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.txt: Added.
  • platform/qt/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.png: Added.
  • platform/qt/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.txt: Added.
  • platform/qt/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-expected.png: Added.
  • platform/qt/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-expected.txt: Added.
  • platform/qt/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl-expected.png: Added.
  • platform/qt/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl-expected.txt: Added.
Location:
trunk
Files:
65 added
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r129123 r129126  
     12012-09-20  Csaba Osztrogonác  <ossy@webkit.org>
     2
     3        [Qt] Enable CSS regions by default
     4        https://bugs.webkit.org/show_bug.cgi?id=97196
     5
     6        Add Qt specific expected results for non-reftests,
     7        results are compared to Mac results manually.
     8
     9        Reviewed by Dirk Schulze.
     10
     11        * platform/qt/Skipped: Unskip passing fast/regions tests, skip 3 failing reftest.
     12        * platform/qt/fast/regions/autoheight-regions-mark-expected.png: Added.
     13        * platform/qt/fast/regions/autoheight-regions-mark-expected.txt: Added.
     14        * platform/qt/fast/regions/bottom-overflow-out-of-first-region-expected.png: Added.
     15        * platform/qt/fast/regions/bottom-overflow-out-of-first-region-expected.txt: Added.
     16        * platform/qt/fast/regions/flow-content-basic-expected.png: Added.
     17        * platform/qt/fast/regions/flow-content-basic-expected.txt: Added.
     18        * platform/qt/fast/regions/flow-content-basic-vertical-expected.png: Added.
     19        * platform/qt/fast/regions/flow-content-basic-vertical-expected.txt: Added.
     20        * platform/qt/fast/regions/flow-content-basic-vertical-rl-expected.png: Added.
     21        * platform/qt/fast/regions/flow-content-basic-vertical-rl-expected.txt: Added.
     22        * platform/qt/fast/regions/flows-dependency-dynamic-remove-expected.png: Added.
     23        * platform/qt/fast/regions/flows-dependency-dynamic-remove-expected.txt: Added.
     24        * platform/qt/fast/regions/flows-dependency-same-flow-expected.png: Added.
     25        * platform/qt/fast/regions/flows-dependency-same-flow-expected.txt: Added.
     26        * platform/qt/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.png: Added.
     27        * platform/qt/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.txt: Added.
     28        * platform/qt/fast/regions/overflow-in-uniform-regions-dynamic-expected.png: Added.
     29        * platform/qt/fast/regions/overflow-in-uniform-regions-dynamic-expected.txt: Added.
     30        * platform/qt/fast/regions/overflow-in-variable-width-regions-expected.png: Added.
     31        * platform/qt/fast/regions/overflow-in-variable-width-regions-expected.txt: Added.
     32        * platform/qt/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.png: Added.
     33        * platform/qt/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.txt: Added.
     34        * platform/qt/fast/regions/overflow-not-moving-below-floats-in-variable-width-regions-expected.png: Added.
     35        * platform/qt/fast/regions/overflow-not-moving-below-floats-in-variable-width-regions-expected.txt: Added.
     36        * platform/qt/fast/regions/overflow-rtl-in-variable-width-regions-expected.png: Added.
     37        * platform/qt/fast/regions/overflow-rtl-in-variable-width-regions-expected.txt: Added.
     38        * platform/qt/fast/regions/overflow-size-change-in-variable-width-regions-expected.png: Added.
     39        * platform/qt/fast/regions/overflow-size-change-in-variable-width-regions-expected.txt: Added.
     40        * platform/qt/fast/regions/overflow-size-change-with-stacking-context-rtl-expected.png: Added.
     41        * platform/qt/fast/regions/overflow-size-change-with-stacking-context-rtl-expected.txt: Added.
     42        * platform/qt/fast/regions/percentage-margins-mixed-ltr-dominant-regions-expected.png: Added.
     43        * platform/qt/fast/regions/percentage-margins-mixed-ltr-dominant-regions-expected.txt: Added.
     44        * platform/qt/fast/regions/percentage-margins-mixed-rtl-dominant-regions-expected.png: Added.
     45        * platform/qt/fast/regions/percentage-margins-mixed-rtl-dominant-regions-expected.txt: Added.
     46        * platform/qt/fast/regions/percentage-margins-rtl-variable-width-regions-expected.png: Added.
     47        * platform/qt/fast/regions/percentage-margins-rtl-variable-width-regions-expected.txt: Added.
     48        * platform/qt/fast/regions/percentage-margins-variable-width-regions-expected.png: Added.
     49        * platform/qt/fast/regions/percentage-margins-variable-width-regions-expected.txt: Added.
     50        * platform/qt/fast/regions/region-overflow-auto-overflow-hidden-expected.png: Added.
     51        * platform/qt/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Added.
     52        * platform/qt/fast/regions/region-overflow-auto-overflow-visible-expected.png: Added.
     53        * platform/qt/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Added.
     54        * platform/qt/fast/regions/region-style-block-background-color-expected.png: Added.
     55        * platform/qt/fast/regions/region-style-block-background-color-expected.txt: Added.
     56        * platform/qt/fast/regions/region-style-block-background-color2-expected.png: Added.
     57        * platform/qt/fast/regions/region-style-block-background-color2-expected.txt: Added.
     58        * platform/qt/fast/regions/text-region-split-small-pagination-expected.png: Added.
     59        * platform/qt/fast/regions/text-region-split-small-pagination-expected.txt: Added.
     60        * platform/qt/fast/regions/top-overflow-out-of-second-region-expected.png: Added.
     61        * platform/qt/fast/regions/top-overflow-out-of-second-region-expected.txt: Added.
     62        * platform/qt/fast/regions/webkit-flow-double-pagination-float-push-expected.png: Added.
     63        * platform/qt/fast/regions/webkit-flow-double-pagination-float-push-expected.txt: Added.
     64        * platform/qt/fast/regions/webkit-flow-float-pushed-to-last-region-expected.png: Added.
     65        * platform/qt/fast/regions/webkit-flow-float-pushed-to-last-region-expected.txt: Added.
     66        * platform/qt/fast/regions/webkit-flow-float-unable-to-push-expected.png: Added.
     67        * platform/qt/fast/regions/webkit-flow-float-unable-to-push-expected.txt: Added.
     68        * platform/qt/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.png: Added.
     69        * platform/qt/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.txt: Added.
     70        * platform/qt/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.png: Added.
     71        * platform/qt/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.txt: Added.
     72        * platform/qt/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-expected.png: Added.
     73        * platform/qt/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-expected.txt: Added.
     74        * platform/qt/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl-expected.png: Added.
     75        * platform/qt/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl-expected.txt: Added.
     76
    1772012-09-20  Sheriff Bot  <webkit.review.bot@gmail.com>
    278

  • trunk/LayoutTests/platform/qt-5.0-wk2/Skipped

    r129103 r129126  
    504504http/tests/security/storage-blocking-strengthened-plugin.html
    505505http/tests/security/storage-blocking-strengthened-private-browsing-plugin.html
     506
     507# [Qt][WK2] fast/regions/css-regions-disabled.html fails
     508# https://bugs.webkit.org/show_bug.cgi?id=97197
     509fast/regions/css-regions-disabled.html

  • trunk/LayoutTests/platform/qt/Skipped

    r129102 r129126  
    310310fast/sub-pixel/sub-pixel-accumulates-to-layers.html
    311311fast/sub-pixel/selection/selection-rect-in-sub-pixel-table.html
    312 
    313 # CSS Regions support not yet enabled. http://webkit.org/b/57312
    314 fast/regions
    315312
    316313# CSS Exclusions support not yet enabled. http://webkit.org/b/57311
    … …  
    25992596svg/animations/animateMotion-additive-1.svg
    26002597svg/transforms/transformed-text-fill-gradient.html
     2598fast/regions/floats-basic-in-variable-width-regions.html
     2599fast/regions/positioned-objects-block-static-spanning-regions-rtl.html
     2600fast/regions/region-style-rule-position.html
    26012601
    26022602# Failing fast/css/sticky/ tests with minor pixel differences
    … …  
    28052805# https://bugs.webkit.org/show_bug.cgi?id=97084
    28062806inspector/extensions/extensions-panel.html
     2807
     2808# [Qt] fast/regions/overflow-size-change-with-stacking-context.html fails
     2809# https://bugs.webkit.org/show_bug.cgi?id=97199
     2810fast/regions/overflow-size-change-with-stacking-context.html

  • trunk/Source/WebKit/qt/Api/qwebsettings.cpp

    r127757 r129126  
    526526    d->attributes.insert(QWebSettings::AcceleratedCompositingEnabled, true);
    527527    d->attributes.insert(QWebSettings::WebGLEnabled, false);
    528     d->attributes.insert(QWebSettings::CSSRegionsEnabled, false);
     528    d->attributes.insert(QWebSettings::CSSRegionsEnabled, true);
    529529    d->attributes.insert(QWebSettings::CSSGridLayoutEnabled, false);
    530530    d->attributes.insert(QWebSettings::HyperlinkAuditingEnabled, false);

  • trunk/Source/WebKit/qt/ChangeLog

    r128889 r129126  
     12012-09-20  Csaba Osztrogonác  <ossy@webkit.org>
     2
     3        [Qt] Enable CSS regions by default
     4        https://bugs.webkit.org/show_bug.cgi?id=97196
     5
     6        Reviewed by Dirk Schulze.
     7
     8        * Api/qwebsettings.cpp:
     9        (QWebSettings::QWebSettings):
     10
    1112012-09-17  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
    212
Note: See TracChangeset for help on using the changeset viewer.