Changeset 129170 in webkit

Timestamp:

Sep 20, 2012 2:45:57 PM (12 years ago)

Author:

dgrogan@chromium.org

Message:

Fix IndexedDB unit tests
​https://bugs.webkit.org/show_bug.cgi?id=97149

Reviewed by Tony Chang.

• tests/IDBDatabaseBackendTest.cpp:

Specify a desired version of -1 so that no version change transaction
is run.

Location:

trunk/Source/WebKit/chromium

Files:

• ChangeLog (modified) (1 diff)
• tests/IDBDatabaseBackendTest.cpp (modified) (4 diffs)

trunk/Source/WebKit/chromium/ChangeLog

@@ +1 @@
+2012-09-20  David Grogan  <dgrogan@chromium.org>
+
+        Fix IndexedDB unit tests
+        https://bugs.webkit.org/show_bug.cgi?id=97149
+
+        Reviewed by Tony Chang.
+
+        * tests/IDBDatabaseBackendTest.cpp:
+        Specify a desired version of -1 so that no version change transaction
+        is run.
+
 2012-09-20  Dirk Pranke  <dpranke@chromium.org>
 

trunk/Source/WebKit/chromium/tests/IDBDatabaseBackendTest.cpp

@@ -114 +114 @@
 };
 
-TEST(IDBDatabaseBackendTest, DISABLED_ConnectionLifecycle)
+TEST(IDBDatabaseBackendTest, ConnectionLifecycle)
 {
     RefPtr<IDBFakeBackingStore> backingStore = adoptRef(new IDBFakeBackingStore());
@@ -126 +126 @@
     RefPtr<MockIDBCallbacks> request1 = MockIDBCallbacks::create();
     RefPtr<FakeIDBDatabaseCallbacks> connection1 = FakeIDBDatabaseCallbacks::create();
-    db->openConnection(request1, connection1);
+    db->openConnectionWithVersion(request1, connection1, IDBDatabaseMetadata::NoIntVersion);
 
     RefPtr<MockIDBCallbacks> request2 = MockIDBCallbacks::create();
     RefPtr<FakeIDBDatabaseCallbacks> connection2 = FakeIDBDatabaseCallbacks::create();
-    db->openConnection(request2, connection2);
+    db->openConnectionWithVersion(request2, connection2, IDBDatabaseMetadata::NoIntVersion);
 
     db->close(connection1);
@@ -173 +173 @@
 };
 
-TEST(IDBDatabaseBackendTest, DISABLED_ForcedClose)
+TEST(IDBDatabaseBackendTest, ForcedClose)
 {
     RefPtr<IDBFakeBackingStore> backingStore = adoptRef(new IDBFakeBackingStore());
@@ -189 +189 @@
     RefPtr<MockIDBDatabaseBackendProxy> proxy = MockIDBDatabaseBackendProxy::create(webDatabase);
     RefPtr<MockIDBCallbacks> request = MockIDBCallbacks::create();
-    backend->openConnection(request, connectionProxy);
+    backend->openConnectionWithVersion(request, connectionProxy, IDBDatabaseMetadata::NoIntVersion);
 
     ScriptExecutionContext* context = 0;