Changeset 130026 in webkit

Timestamp:

Oct 1, 2012 3:45:12 AM (12 years ago)

Author:

arko@motorola.com

Message:

Microdata: names.item() must return null for out of range indexes.
​https://bugs.webkit.org/show_bug.cgi?id=97898

Reviewed by Kentaro Hara.

Source/WebCore:

DOMStringList.item() must return null for an invalid index.
Spec: ​http://www.w3.org/TR/DOM-Level-3-Core/core.html#DOMStringList
Removed [IsIndex] extended IDL attribute from item() method's index
parameter in DOMStringList interface.
Firefox and Opera's behavior is consistent with the spec. Both
returns null for invalid index.

Test: fast/dom/MicroData/names-item-out-of-range-index.html

• dom/DOMStringList.idl:

LayoutTests:

Added test case to ensure names.item() behavior for out of range indexes.

• fast/dom/MicroData/names-item-out-of-range-index-expected.txt: Added.
• fast/dom/MicroData/names-item-out-of-range-index.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/dom/MicroData/names-item-out-of-range-index-expected.txt (added)
• LayoutTests/fast/dom/MicroData/names-item-out-of-range-index.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/dom/DOMStringList.idl (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2012-10-01  Arko Saha  <arko@motorola.com>
+
+        Microdata: names.item() must return null for out of range indexes.
+        https://bugs.webkit.org/show_bug.cgi?id=97898
+
+        Reviewed by Kentaro Hara.
+
+        Added test case to ensure names.item() behavior for out of range indexes.
+
+        * fast/dom/MicroData/names-item-out-of-range-index-expected.txt: Added.
+        * fast/dom/MicroData/names-item-out-of-range-index.html: Added.
+
 2012-10-01  Yoshifumi Inoue  <yosin@chromium.org>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-10-01  Arko Saha  <arko@motorola.com>
+
+        Microdata: names.item() must return null for out of range indexes.
+        https://bugs.webkit.org/show_bug.cgi?id=97898
+
+        Reviewed by Kentaro Hara.
+
+        DOMStringList.item() must return null for an invalid index.
+        Spec: http://www.w3.org/TR/DOM-Level-3-Core/core.html#DOMStringList
+        Removed [IsIndex] extended IDL attribute from item() method's index
+        parameter in DOMStringList interface.
+        Firefox and Opera's behavior is consistent with the spec. Both
+        returns null for invalid index.
+
+        Test: fast/dom/MicroData/names-item-out-of-range-index.html
+
+        * dom/DOMStringList.idl:
+
 2012-10-01  Yoshifumi Inoue  <yosin@chromium.org>
 

trunk/Source/WebCore/dom/DOMStringList.idl

@@ -31 +31 @@
     ] DOMStringList {
         readonly attribute unsigned long length;
-        [TreatReturnedNullStringAs=Null] DOMString item(in [IsIndex,Optional=DefaultIsUndefined] unsigned long index);
+        [TreatReturnedNullStringAs=Null] DOMString item(in [Optional=DefaultIsUndefined] unsigned long index);
         boolean contains(in [Optional=DefaultIsUndefined] DOMString string);
     };