Changeset 130116 in webkit


Ignore:
Timestamp:
Oct 1, 2012 9:22:55 PM (12 years ago)
Author:
yosin@chromium.org
Message:

Week specifiers defined in DateTimeFormat class are wrong.
​https://bugs.webkit.org/show_bug.cgi?id=98104

Reviewed by Kent Tamura.

This patch changes week of year and week of month format specifiers
defined in DateTimeFormat class to match with Unicode technical
standard 35, LDML, Locale Data Markup Language, (​http://www.unicode.org/reports/tr35/).

No new tests. Following existing tests cover this change:

  • fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic.html
  • fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes.html
  • fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements.html
  • fast/forms/month-multiple-fields/month-multiple-fields-appearance-style.html
  • html/WeekInputType.cpp:

(WebCore::WeekInputType::setupLayoutParameters): Changed to use 'w' instead of 'W'.

  • platform/text/DateTimeFormat.cpp: Changed elements in lowerCaseToFieldTypeMap and upperCaseToFieldTypeMap.
  • platform/text/DateTimeFormat.h: Changed FieldTypeWeekOfMonth to 'W' and FieldTypeWeekOfYear to 'w'.
Location:
trunk/Source/WebCore
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r130114 r130116  
     12012-10-01  Yoshifumi Inoue  <yosin@chromium.org>
     2
     3        Week specifiers defined in DateTimeFormat class are wrong.
     4        https://bugs.webkit.org/show_bug.cgi?id=98104
     5
     6        Reviewed by Kent Tamura.
     7
     8        This patch changes week of year and week of month format specifiers
     9        defined in DateTimeFormat class to match with Unicode technical
     10        standard 35, LDML, Locale Data Markup Language, (http://www.unicode.org/reports/tr35/).
     11
     12        No new tests. Following existing tests cover this change:
     13          - fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic.html
     14          - fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes.html
     15          - fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements.html
     16          - fast/forms/month-multiple-fields/month-multiple-fields-appearance-style.html
     17
     18        * html/WeekInputType.cpp:
     19        (WebCore::WeekInputType::setupLayoutParameters): Changed to use 'w' instead of 'W'.
     20        * platform/text/DateTimeFormat.cpp: Changed elements in lowerCaseToFieldTypeMap and upperCaseToFieldTypeMap.
     21        * platform/text/DateTimeFormat.h: Changed FieldTypeWeekOfMonth to 'W' and FieldTypeWeekOfYear to 'w'.
     22
    1232012-10-01  Glenn Adams  <glenn@skynav.com>
    224

  • trunk/Source/WebCore/html/WeekInputType.cpp

    r130024 r130116  
    110110{
    111111    layoutParameters.dateTimeFormat = weekFormatInLDML();
    112     layoutParameters.fallbackDateTimeFormat = "'Week' WW-yyyy";
     112    layoutParameters.fallbackDateTimeFormat = "'Week' ww-yyyy";
    113113    layoutParameters.placeholderForYear = "----";
    114114}

  • trunk/Source/WebCore/platform/text/DateTimeFormat.cpp

    r129612 r130116  
    5656    DateTimeFormat::FieldTypeExtendedYear, // u
    5757    DateTimeFormat::FieldTypeNonLocationZone, // v
    58     DateTimeFormat::FieldTypeWeekOfMonth, // w
     58    DateTimeFormat::FieldTypeWeekOfYear, // w
    5959    DateTimeFormat::FieldTypeInvalid, // x
    6060    DateTimeFormat::FieldTypeYear, // y
    … …  
    8585    DateTimeFormat::FieldTypeInvalid, // U
    8686    DateTimeFormat::FieldTypeInvalid, // V
    87     DateTimeFormat::FieldTypeWeekOfYear, // W
     87    DateTimeFormat::FieldTypeWeekOfMonth, // W
    8888    DateTimeFormat::FieldTypeInvalid, // X
    8989    DateTimeFormat::FieldTypeYearOfWeekOfYear, // Y

  • trunk/Source/WebCore/platform/text/DateTimeFormat.h

    r129612 r130116  
    5858
    5959        // Week: 42
    60         FieldTypeWeekOfYear = 'W',
    61         FieldTypeWeekOfMonth = 'w',
     60        FieldTypeWeekOfYear = 'w',
     61        FieldTypeWeekOfMonth = 'W',
    6262
    6363        // Day: 12
Note: See TracChangeset for help on using the changeset viewer.