Changeset 130127 in webkit

Timestamp:

Oct 1, 2012 11:48:59 PM (12 years ago)

Author:

yosin@chromium.org

Message:

Adding Localizer::dateFormat() for multiple fields date/datetime input UI
​https://bugs.webkit.org/show_bug.cgi?id=98109

Reviewed by Kent Tamura.

This patch introduces Localizer::dateFormat() function for multiple
fields date/datetime/datetime-local input UI inside ENABLE_INPUT_MULTIPLE_FIELDS_UI.

We'll have platform specific implementations in LocaleICU, LocaleMac,
and LocaleWin.

No new tests. Other patches will add tests for this change.

• platform/text/LocaleICU.cpp:

(WebCore::LocaleICU::dateFormat): Added a stub.

• platform/text/LocaleICU.h:

(LocaleICU): Changed to add a declaration of dateFormat().

• platform/text/LocaleNone.cpp:

(LocaleNone): Changed to add a declaration of dateFormat().
(WebCore::LocaleNone::dateFormat): Added.

• platform/text/LocaleWin.cpp:

(WebCore::LocaleWin::dateFormat): Added.

• platform/text/LocaleWin.h:

(LocaleWin): Changed to add a declaration of dateFormat().

• platform/text/Localizer.h: Updates Unicode TR35 URI in a comment.

(Localizer): Changed to add a declaration of dateFormat().

• platform/text/mac/LocaleMac.h:

(LocaleMac): Changed to add a declaration of dateFormat().

• platform/text/mac/LocaleMac.mm:

(WebCore::LocaleMac::dateFormat): Added a stub.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/text/LocaleICU.cpp (modified) (1 diff)
• platform/text/LocaleICU.h (modified) (1 diff)
• platform/text/LocaleNone.cpp (modified) (2 diffs)
• platform/text/LocaleWin.cpp (modified) (1 diff)
• platform/text/LocaleWin.h (modified) (1 diff)
• platform/text/Localizer.h (modified) (1 diff)
• platform/text/mac/LocaleMac.h (modified) (1 diff)
• platform/text/mac/LocaleMac.mm (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-10-01  Yoshifumi Inoue  <yosin@chromium.org>
+
+        Adding Localizer::dateFormat() for multiple fields date/datetime input UI
+        https://bugs.webkit.org/show_bug.cgi?id=98109
+
+        Reviewed by Kent Tamura.
+
+        This patch introduces Localizer::dateFormat() function for multiple
+        fields date/datetime/datetime-local input UI inside ENABLE_INPUT_MULTIPLE_FIELDS_UI.
+
+        We'll have platform specific implementations in LocaleICU, LocaleMac,
+        and LocaleWin.
+
+        No new tests. Other patches will add tests for this change.
+
+        * platform/text/LocaleICU.cpp:
+        (WebCore::LocaleICU::dateFormat): Added a stub.
+        * platform/text/LocaleICU.h:
+        (LocaleICU):  Changed to add a declaration of dateFormat().
+        * platform/text/LocaleNone.cpp:
+        (LocaleNone):  Changed to add a declaration of dateFormat().
+        (WebCore::LocaleNone::dateFormat): Added.
+        * platform/text/LocaleWin.cpp:
+        (WebCore::LocaleWin::dateFormat): Added.
+        * platform/text/LocaleWin.h:
+        (LocaleWin): Changed to add a declaration of dateFormat().
+        * platform/text/Localizer.h: Updates Unicode TR35 URI in a comment.
+        (Localizer): Changed to add a declaration of dateFormat().
+        * platform/text/mac/LocaleMac.h:
+        (LocaleMac): Changed to add a declaration of dateFormat().
+        * platform/text/mac/LocaleMac.mm:
+        (WebCore::LocaleMac::dateFormat): Added a stub.
+
 2012-10-01  Adam Barth  <abarth@webkit.org>
 

trunk/Source/WebCore/platform/text/LocaleICU.cpp

@@ -412 +412 @@
 }
 
+String LocaleICU::dateFormat()
+{
+    // FIXME: We should have real implementation of LocaleICU::dateFormat().
+    return emptyString();
+}
+
 String LocaleICU::timeFormat()
 {

trunk/Source/WebCore/platform/text/LocaleICU.h

@@ -63 +63 @@
 
 #if ENABLE(INPUT_MULTIPLE_FIELDS_UI)
+    virtual String dateFormat() OVERRIDE;
     virtual String timeFormat() OVERRIDE;
     virtual String shortTimeFormat() OVERRIDE;

trunk/Source/WebCore/platform/text/LocaleNone.cpp

@@ -41 +41 @@
     virtual String dateFormatText() OVERRIDE;
 #endif
+#if ENABLE(INPUT_MULTIPLE_FIELDS_UI)
+    virtual String dateFormat() OVERRIDE;
+#endif
 };
 
@@ -73 +76 @@
 #endif
 
+#if ENABLE(INPUT_MULTIPLE_FIELDS_UI)
+String LocaleNone::dateFormat()
+{
+    return ASCIILiteral("dd/mm/yyyyy");
+}
+#endif
+
 } // namespace WebCore

trunk/Source/WebCore/platform/text/LocaleWin.cpp

@@ -730 +730 @@
 }
 
+String LocaleWin::dateFormat()
+{
+    // FIXME: We should have real implementation of LocaleWin::dateFormat().
+    return emptyString();
+}
+
 String LocaleWin::timeFormat()
 {

trunk/Source/WebCore/platform/text/LocaleWin.h

@@ -58 +58 @@
 
 #if ENABLE(INPUT_MULTIPLE_FIELDS_UI)
+    virtual String dateFormat() OVERRIDE;
     virtual String timeFormat() OVERRIDE;
     virtual String shortTimeFormat() OVERRIDE;

trunk/Source/WebCore/platform/text/Localizer.h

@@ -58 +58 @@
     String localizedDecimalSeparator();
 
+    // Returns date format in Unicode TR35 LDML[1] containing day of month,
+    // month, and year, e.g. "dd/mm/yyyy"
+    // [1] LDML http://unicode.org/reports/tr35/#Date_Format_Patterns
+    virtual String dateFormat() = 0;
+
     // Returns time format in Unicode TR35 LDML[1] containing hour, minute, and
     // second with optional period(AM/PM), e.g. "h:mm:ss a"
-    // [1] LDML http://unicode.org/reports/tr35/tr35-6.html#Date_Format_Patterns
+    // [1] LDML http://unicode.org/reports/tr35/#Date_Format_Patterns
     virtual String timeFormat();
 

trunk/Source/WebCore/platform/text/mac/LocaleMac.h

@@ -62 +62 @@
 
 #if ENABLE(INPUT_MULTIPLE_FIELDS_UI)
+    virtual String dateFormat() OVERRIDE;
     virtual String timeFormat() OVERRIDE;
     virtual String shortTimeFormat() OVERRIDE;

trunk/Source/WebCore/platform/text/mac/LocaleMac.mm

@@ -253 +253 @@
 }
 
+String LocaleMac::dateFormat()
+{
+    // FIXME: We should have real implementation of LocaleMac::dateFormat().
+    return emptyString();
+}
+
 String LocaleMac::timeFormat()
 {