Changeset 130243 in webkit

Timestamp:

Oct 2, 2012 6:25:29 PM (12 years ago)

Author:

tkent@chromium.org

Message:

[Mac][Chromium-Mac] Implement LocaleMac::dateFormat
​https://bugs.webkit.org/show_bug.cgi?id=98116

Reviewed by Hajime Morita.

​http://trac.webkit.org/changeset/130127 introduced
Localizer::dateFormat, and this is its implementation for LocaleICU
classs. The code is going to be used when
ENABLE_INPUT_MULTIPLE_FIELDS_UI is enabled.

No new tests. The function is not used yet.

• platform/text/mac/LocaleMac.h:

(LocaleMac): Declare m_dateFormat.

• platform/text/mac/LocaleMac.mm:

(WebCore::LocaleMac::dateFormat): Implemented.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/text/mac/LocaleMac.h (modified) (1 diff)
• platform/text/mac/LocaleMac.mm (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-10-02  Kent Tamura  <tkent@chromium.org>
+
+        [Mac][Chromium-Mac] Implement LocaleMac::dateFormat
+        https://bugs.webkit.org/show_bug.cgi?id=98116
+
+        Reviewed by Hajime Morita.
+
+        http://trac.webkit.org/changeset/130127 introduced
+        Localizer::dateFormat, and this is its implementation for LocaleICU
+        classs. The code is going to be used when
+        ENABLE_INPUT_MULTIPLE_FIELDS_UI is enabled.
+
+        No new tests. The function is not used yet.
+
+        * platform/text/mac/LocaleMac.h:
+        (LocaleMac): Declare m_dateFormat.
+        * platform/text/mac/LocaleMac.mm:
+        (WebCore::LocaleMac::dateFormat): Implemented.
+
 2012-10-02  Kent Tamura  <tkent@chromium.org>
 

trunk/Source/WebCore/platform/text/mac/LocaleMac.h

@@ -83 +83 @@
     NSDateFormatter *createShortTimeFormatter();
 
+    String m_dateFormat;
     String m_localizedTimeFormatText;
     String m_localizedShortTimeFormatText;

trunk/Source/WebCore/platform/text/mac/LocaleMac.mm

@@ -255 +255 @@
 String LocaleMac::dateFormat()
 {
-    // FIXME: We should have real implementation of LocaleMac::dateFormat().
-    return emptyString();
+    if (!m_dateFormat.isEmpty())
+        return m_dateFormat;
+    RetainPtr<NSDateFormatter> formatter(AdoptNS, createShortDateFormatter());
+    m_dateFormat = String([formatter.get() dateFormat]);
+    return m_dateFormat;
 }