Changeset 130827 in webkit

Timestamp:

Oct 9, 2012 4:49:07 PM (12 years ago)

Author:

commit-queue@webkit.org

Message:

Fix coding style of layout test fast/dom/timer-throttling-hidden-page.html
​https://bugs.webkit.org/show_bug.cgi?id=98828

Patch by Kiran Muppala <​cmuppala@apple.com> on 2012-10-09
Reviewed by Ojan Vafai.

Replaced tab characters with spaces, fixed position of braces and renamed
variables to be more explanatory.

• fast/dom/timer-throttling-hidden-page.html:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• fast/dom/timer-throttling-hidden-page.html (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2012-10-09  Kiran Muppala  <cmuppala@apple.com>
+
+        Fix coding style of layout test fast/dom/timer-throttling-hidden-page.html
+        https://bugs.webkit.org/show_bug.cgi?id=98828
+
+        Reviewed by Ojan Vafai.
+
+        Replaced tab characters with spaces, fixed position of braces and renamed
+        variables to be more explanatory.
+
+        * fast/dom/timer-throttling-hidden-page.html:
+
 2012-10-09  Sadrul Habib Chowdhury  <sadrul@chromium.org>
 

trunk/LayoutTests/fast/dom/timer-throttling-hidden-page.html

@@ -6 +6 @@
 
         var jsTestIsAsync = true;
-        var previousT = new Date().getTime();
+        var previousTime = new Date().getTime();
         var timerCount = 0;
         var firstTimerWhileHidden = true;
@@ -14 +14 @@
         var timerAlignmentInterval = 1000;
 
-        function testTimer() {
-            var d = new Date();
-            var t = d.getTime();
+        function testTimer()
+        {
+            var date = new Date();
+            var time = date.getTime();
             if (!isPageVisible) {
                 if (firstTimerWhileHidden) {
-                    firstTimerIntervalWhilePageHidden = t - previousT;
+                    firstTimerIntervalWhilePageHidden = time - previousTime;
                     var minValue = timeoutInterval - tolerance;
-                    shouldBeGreaterThanOrEqual("firstTimerIntervalWhilePageHidden", minValue.toString());
-                    var maxValue = timeoutInterval + timerAlignmentInterval + tolerance;
+                    shouldBeGreaterThanOrEqual("firstTimerIntervalWhilePageHidden", minValue.toString());
+                    var maxValue = timeoutInterval + timerAlignmentInterval + tolerance;
                     shouldBeTrue("firstTimerIntervalWhilePageHidden <= " + maxValue);
                     firstTimerWhileHidden = false;
                 } else {
-                    timerIntervalWhilePageHidden = t - previousT;
+                    timerIntervalWhilePageHidden = time - previousTime;
                     shouldBeCloseTo("timerIntervalWhilePageHidden", timerAlignmentInterval, tolerance);
                 }
-            }
-            else {
-                timerIntervalWhilePageVisible = t - previousT;
+            } else {
+                timerIntervalWhilePageVisible = time - previousTime;
                 shouldBeCloseTo("timerIntervalWhilePageVisible", timeoutInterval, tolerance);
             }
 
             timerCount++;
-            previousT = t;
+            previousTime = time;
 
             if (timerCount == 1) {
                 testRunner.setPageVisibility("hidden");
-                isPageVisible = false;
-            } else if (timerCount == 3) {
+                isPageVisible = false;
+            } else if (timerCount == 3) {
                 testRunner.resetPageVisibility();
                 isPageVisible = true;
             } else if (timerCount >= 4){
                 finishJSTest();
-                return;
+                return;
             }
             setTimeout(testTimer, timeoutInterval);
-        }
+        }
 
-        function runTest() {
-            if (!window.testRunner) {
-                debug('This test requires testRunner');
-                return;
+        function runTest()
+        {
+            if (!window.testRunner) {
+                debug('This test requires testRunner');
+                return;
             }
-            var timeoutIntervalSpans = document.getElementsByClassName('timeoutInterval');
-            for (var i = 0; i < timeoutIntervalSpans.length; i++) {
-                timeoutIntervalSpans[i].innerText = timeoutInterval;
-            }
+            var timeoutIntervalSpans = document.getElementsByClassName('timeoutInterval');
+            for (var i = 0; i < timeoutIntervalSpans.length; i++)
+                timeoutIntervalSpans[i].innerText = timeoutInterval;
 
-            document.getElementById('alignmentInterval').innerText = timerAlignmentInterval / 1000;
+            document.getElementById('alignmentInterval').innerText = timerAlignmentInterval / 1000;
 
             testRunner.dumpAsText();
             setTimeout(testTimer, timeoutInterval);
         }
-
     </script>
 </head>