Changeset 131057 in webkit


Ignore:
Timestamp:
Oct 11, 2012 7:24:39 AM (12 years ago)
Author:
commit-queue@webkit.org
Message:

REGRESSION (r129478-r129480): http/tests/loading/text-content-type-with-binary-extension.html failing on Apple MountainLion Debug WK2 (Tests)
​https://bugs.webkit.org/show_bug.cgi?id=98527

Patch by Mikhail Pozdnyakov <​mikhail.pozdnyakov@intel.com> on 2012-10-11
Reviewed by Kenneth Rohde Christiansen.

Tools:

Added decidePolicyForResponse callback for WTR PagePolicyClient.

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::initialize):
(WTR::TestController::decidePolicyForResponse):
(WTR):

  • WebKitTestRunner/TestController.h:

(TestController):

LayoutTests:

Rebased http/tests/loading/text-content-type-with-binary-extension.html for WK2 EFL, as dumping order is affected.
Other WK2 ports will have to do the same.

  • platform/efl-wk2/http/tests/loading/text-content-type-with-binary-extension-expected.txt: Added.
  • platform/gtk-wk2/TestExpectations:
  • platform/mac-wk2/TestExpectations:
  • platform/qt-5.0-wk2/TestExpectations:
Location:
trunk
Files:
4 added
7 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r131055 r131057  
     12012-10-11  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
     2
     3        REGRESSION (r129478-r129480): http/tests/loading/text-content-type-with-binary-extension.html failing on Apple MountainLion Debug WK2 (Tests)
     4        https://bugs.webkit.org/show_bug.cgi?id=98527
     5
     6        Reviewed by Kenneth Rohde Christiansen.
     7
     8        Rebased http/tests/loading/text-content-type-with-binary-extension.html for WK2 EFL, as dumping order is affected.
     9        Other WK2 ports will have to do the same.
     10
     11        * platform/efl-wk2/http/tests/loading/text-content-type-with-binary-extension-expected.txt: Added.
     12        * platform/gtk-wk2/TestExpectations:
     13        * platform/mac-wk2/TestExpectations:
     14        * platform/qt-5.0-wk2/TestExpectations:
     15
    1162012-10-11  Zan Dobersek  <zandobersek@gmail.com>
    217

  • trunk/LayoutTests/platform/gtk-wk2/TestExpectations

    r130641 r131057  
    614614Bug(GTK) svg/dom/viewspec-parser-5.html [ Pass ]
    615615
     616# Will need rebaselining after bug 98527 fixed
     617webkit.org/b/98527 http/tests/loading/text-content-type-with-binary-extension.html [ Failure ]
     618
    616619#////////////////////////////////////////////////////////////////////////////////////////
    617620# End of Tests working in WK2 and failing in WK1

  • trunk/LayoutTests/platform/mac-wk2/TestExpectations

    r130976 r131057  
    281281webkit.org/b/96832 fast/loader/display-image-unset-can-block-image-and-can-reload-in-place.html [ Failure ]
    282282
    283 # http/tests/loading/text-content-type-with-binary-extension.html fails on Mac WK2 bots
    284 # https://bugs.webkit.org/show_bug.cgi?id=98527
     283# Will need rebaselining after bug 98527 fixed
    285284webkit.org/b/98527 http/tests/loading/text-content-type-with-binary-extension.html [ Failure ]
    286285

  • trunk/LayoutTests/platform/qt-5.0-wk2/TestExpectations

    r131051 r131057  
    603603webkit.org/b/98897 fast/repaint/textarea-set-disabled.html [ ImageOnlyFailure ]
    604604
    605 # [Qt][WK2] REGRESSION(r130967): It made http/tests/loading/text-content-type-with-binary-extension.html fail
    606 webkit.org/b/98994 http/tests/loading/text-content-type-with-binary-extension.html
     605# Will need rebaselining after bug 98527 fixed
     606webkit.org/b/98994 http/tests/loading/text-content-type-with-binary-extension.html [ Failure ]
    607607
    608608# [Qt] some tests fail after unskipped in r131044

  • trunk/Tools/ChangeLog

    r131045 r131057  
     12012-10-11  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
     2
     3        REGRESSION (r129478-r129480): http/tests/loading/text-content-type-with-binary-extension.html failing on Apple MountainLion Debug WK2 (Tests)
     4        https://bugs.webkit.org/show_bug.cgi?id=98527
     5
     6        Reviewed by Kenneth Rohde Christiansen.
     7
     8        Added decidePolicyForResponse callback for WTR PagePolicyClient.
     9
     10        * WebKitTestRunner/TestController.cpp:
     11        (WTR::TestController::initialize):
     12        (WTR::TestController::decidePolicyForResponse):
     13        (WTR):
     14        * WebKitTestRunner/TestController.h:
     15        (TestController):
     16
    1172012-10-11  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
    218

  • trunk/Tools/WebKitTestRunner/TestController.cpp

    r130967 r131057  
    441441        decidePolicyForNavigationAction,
    442442        0, // decidePolicyForNewWindowAction
    443         0, // decidePolicyForResponse
     443        decidePolicyForResponse,
    444444        0, // unableToImplementPolicy
    445445    };
    … …  
    10711071}
    10721072
     1073void TestController::decidePolicyForResponse(WKPageRef, WKFrameRef, WKURLResponseRef, WKURLRequestRef, WKFramePolicyListenerRef listener, WKTypeRef, const void* clientInfo)
     1074{
     1075    static_cast<TestController*>(const_cast<void*>(clientInfo))->decidePolicyForResponse(listener);
     1076}
     1077
     1078void TestController::decidePolicyForResponse(WKFramePolicyListenerRef listener)
     1079{
     1080    // Response was already checked by WKBundlePagePolicyClient, so if we are here we're supposed to ignore.
     1081    WKFramePolicyListenerIgnore(listener);
     1082}
     1083
    10731084} // namespace WTR

  • trunk/Tools/WebKitTestRunner/TestController.h

    r130967 r131057  
    118118    void decidePolicyForNavigationAction(WKFramePolicyListenerRef);
    119119
     120    static void decidePolicyForResponse(WKPageRef, WKFrameRef, WKURLResponseRef, WKURLRequestRef, WKFramePolicyListenerRef, WKTypeRef, const void*);
     121    void decidePolicyForResponse(WKFramePolicyListenerRef);
     122
    120123    static WKPageRef createOtherPage(WKPageRef oldPage, WKURLRequestRef, WKDictionaryRef, WKEventModifiers, WKEventMouseButton, const void*);
    121124
Note: See TracChangeset for help on using the changeset viewer.