Changeset 131088 in webkit

Timestamp:

Oct 11, 2012 12:54:38 PM (12 years ago)

Author:

ggaren@apple.com

Message:

Removed ASSERT_CLASS_FITS_IN_CELL
​https://bugs.webkit.org/show_bug.cgi?id=97634

Reviewed by Mark Hahnenberg.

Source/JavaScriptCore:

Our collector now supports arbitrarily sized objects, so the ASSERT is not needed.

• API/JSCallbackFunction.cpp:
• API/JSCallbackObject.cpp:
• heap/MarkedSpace.h:
• jsc.cpp:
• runtime/Arguments.cpp:
• runtime/ArrayConstructor.cpp:
• runtime/ArrayPrototype.cpp:
• runtime/BooleanConstructor.cpp:
• runtime/BooleanObject.cpp:
• runtime/BooleanPrototype.cpp:
• runtime/DateConstructor.cpp:
• runtime/DatePrototype.cpp:
• runtime/Error.cpp:
• runtime/ErrorConstructor.cpp:
• runtime/ErrorPrototype.cpp:
• runtime/FunctionConstructor.cpp:
• runtime/FunctionPrototype.cpp:
• runtime/InternalFunction.cpp:
• runtime/JSActivation.cpp:
• runtime/JSArray.cpp:
• runtime/JSBoundFunction.cpp:
• runtime/JSFunction.cpp:
• runtime/JSGlobalObject.cpp:
• runtime/JSGlobalThis.cpp:
• runtime/JSNameScope.cpp:
• runtime/JSNotAnObject.cpp:
• runtime/JSONObject.cpp:
• runtime/JSObject.cpp:
• runtime/JSPropertyNameIterator.cpp:
• runtime/JSScope.cpp:
• runtime/JSWithScope.cpp:
• runtime/JSWrapperObject.cpp:
• runtime/MathObject.cpp:
• runtime/NameConstructor.cpp:
• runtime/NamePrototype.cpp:
• runtime/NativeErrorConstructor.cpp:
• runtime/NativeErrorPrototype.cpp:
• runtime/NumberConstructor.cpp:
• runtime/NumberObject.cpp:
• runtime/NumberPrototype.cpp:
• runtime/ObjectConstructor.cpp:
• runtime/ObjectPrototype.cpp:
• runtime/RegExpConstructor.cpp:
• runtime/RegExpMatchesArray.cpp:
• runtime/RegExpObject.cpp:
• runtime/RegExpPrototype.cpp:
• runtime/StringConstructor.cpp:
• runtime/StringObject.cpp:
• runtime/StringPrototype.cpp:
• testRegExp.cpp: Removed the ASSERT.

Source/WebCore:

• bindings/js/JSDOMWindowShell.cpp:

(WebCore):

• bindings/js/JSImageConstructor.cpp:

(WebCore):

• bindings/js/JSNodeFilterCondition.cpp:

(WebCore):

• bindings/js/JSWorkerContextBase.cpp:

(WebCore):

• bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

• bindings/scripts/test/JS/JSFloat64Array.cpp:

(WebCore):

• bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:

(WebCore):

• bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:

(WebCore):

• bindings/scripts/test/JS/JSTestEventConstructor.cpp:

(WebCore):

• bindings/scripts/test/JS/JSTestEventTarget.cpp:

(WebCore):

• bindings/scripts/test/JS/JSTestException.cpp:

(WebCore):

• bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore):

• bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:

(WebCore):

• bindings/scripts/test/JS/JSTestNamedConstructor.cpp:

(WebCore):

• bindings/scripts/test/JS/JSTestNode.cpp:

(WebCore):

• bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore):

• bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore):

• bridge/runtime_method.cpp:

(JSC):

Location:

trunk/Source

Files:

• JavaScriptCore/API/JSCallbackFunction.cpp (modified) (1 diff)
• JavaScriptCore/API/JSCallbackObject.cpp (modified) (1 diff)
• JavaScriptCore/ChangeLog (modified) (1 diff)
• JavaScriptCore/heap/MarkedSpace.h (modified) (2 diffs)
• JavaScriptCore/jsc.cpp (modified) (1 diff)
• JavaScriptCore/runtime/Arguments.cpp (modified) (1 diff)
• JavaScriptCore/runtime/ArrayConstructor.cpp (modified) (1 diff)
• JavaScriptCore/runtime/ArrayPrototype.cpp (modified) (1 diff)
• JavaScriptCore/runtime/BooleanConstructor.cpp (modified) (1 diff)
• JavaScriptCore/runtime/BooleanObject.cpp (modified) (1 diff)
• JavaScriptCore/runtime/BooleanPrototype.cpp (modified) (1 diff)
• JavaScriptCore/runtime/DateConstructor.cpp (modified) (1 diff)
• JavaScriptCore/runtime/DatePrototype.cpp (modified) (1 diff)
• JavaScriptCore/runtime/Error.cpp (modified) (1 diff)
• JavaScriptCore/runtime/ErrorConstructor.cpp (modified) (1 diff)
• JavaScriptCore/runtime/ErrorPrototype.cpp (modified) (2 diffs)
• JavaScriptCore/runtime/FunctionConstructor.cpp (modified) (1 diff)
• JavaScriptCore/runtime/FunctionPrototype.cpp (modified) (1 diff)
• JavaScriptCore/runtime/InternalFunction.cpp (modified) (1 diff)
• JavaScriptCore/runtime/JSActivation.cpp (modified) (1 diff)
• JavaScriptCore/runtime/JSArray.cpp (modified) (1 diff)
• JavaScriptCore/runtime/JSBoundFunction.cpp (modified) (1 diff)
• JavaScriptCore/runtime/JSFunction.cpp (modified) (1 diff)
• JavaScriptCore/runtime/JSGlobalObject.cpp (modified) (1 diff)
• JavaScriptCore/runtime/JSNameScope.cpp (modified) (1 diff)
• JavaScriptCore/runtime/JSNotAnObject.cpp (modified) (1 diff)
• JavaScriptCore/runtime/JSONObject.cpp (modified) (1 diff)
• JavaScriptCore/runtime/JSObject.cpp (modified) (1 diff)
• JavaScriptCore/runtime/JSPropertyNameIterator.cpp (modified) (1 diff)
• JavaScriptCore/runtime/JSProxy.cpp (modified) (1 diff)
• JavaScriptCore/runtime/JSScope.cpp (modified) (1 diff)
• JavaScriptCore/runtime/JSWithScope.cpp (modified) (1 diff)
• JavaScriptCore/runtime/JSWrapperObject.cpp (modified) (1 diff)
• JavaScriptCore/runtime/MathObject.cpp (modified) (1 diff)
• JavaScriptCore/runtime/NameConstructor.cpp (modified) (1 diff)
• JavaScriptCore/runtime/NamePrototype.cpp (modified) (2 diffs)
• JavaScriptCore/runtime/NativeErrorConstructor.cpp (modified) (1 diff)
• JavaScriptCore/runtime/NativeErrorPrototype.cpp (modified) (1 diff)
• JavaScriptCore/runtime/NumberConstructor.cpp (modified) (1 diff)
• JavaScriptCore/runtime/NumberObject.cpp (modified) (1 diff)
• JavaScriptCore/runtime/NumberPrototype.cpp (modified) (1 diff)
• JavaScriptCore/runtime/ObjectConstructor.cpp (modified) (1 diff)
• JavaScriptCore/runtime/ObjectPrototype.cpp (modified) (1 diff)
• JavaScriptCore/runtime/RegExpConstructor.cpp (modified) (1 diff)
• JavaScriptCore/runtime/RegExpMatchesArray.cpp (modified) (1 diff)
• JavaScriptCore/runtime/RegExpObject.cpp (modified) (1 diff)
• JavaScriptCore/runtime/RegExpPrototype.cpp (modified) (1 diff)
• JavaScriptCore/runtime/StringConstructor.cpp (modified) (1 diff)
• JavaScriptCore/runtime/StringObject.cpp (modified) (1 diff)
• JavaScriptCore/runtime/StringPrototype.cpp (modified) (1 diff)
• JavaScriptCore/testRegExp.cpp (modified) (1 diff)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/bindings/js/JSDOMWindowShell.cpp (modified) (1 diff)
• WebCore/bindings/js/JSImageConstructor.cpp (modified) (1 diff)
• WebCore/bindings/js/JSNodeFilterCondition.cpp (modified) (1 diff)
• WebCore/bindings/js/JSWorkerContextBase.cpp (modified) (1 diff)
• WebCore/bindings/scripts/CodeGeneratorJS.pm (modified) (1 diff)
• WebCore/bindings/scripts/test/JS/JSFloat64Array.cpp (modified) (1 diff)
• WebCore/bindings/scripts/test/JS/JSTestActiveDOMObject.cpp (modified) (1 diff)
• WebCore/bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp (modified) (1 diff)
• WebCore/bindings/scripts/test/JS/JSTestEventConstructor.cpp (modified) (1 diff)
• WebCore/bindings/scripts/test/JS/JSTestEventTarget.cpp (modified) (1 diff)
• WebCore/bindings/scripts/test/JS/JSTestException.cpp (modified) (1 diff)
• WebCore/bindings/scripts/test/JS/JSTestInterface.cpp (modified) (1 diff)
• WebCore/bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp (modified) (1 diff)
• WebCore/bindings/scripts/test/JS/JSTestNamedConstructor.cpp (modified) (1 diff)
• WebCore/bindings/scripts/test/JS/JSTestNode.cpp (modified) (1 diff)
• WebCore/bindings/scripts/test/JS/JSTestObj.cpp (modified) (1 diff)
• WebCore/bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp (modified) (1 diff)
• WebCore/bridge/runtime_method.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/API/JSCallbackFunction.cpp

@@ -39 +39 @@
 namespace JSC {
 
-ASSERT_CLASS_FITS_IN_CELL(JSCallbackFunction);
 ASSERT_HAS_TRIVIAL_DESTRUCTOR(JSCallbackFunction);
 

trunk/Source/JavaScriptCore/API/JSCallbackObject.cpp

@@ -32 +32 @@
 
 namespace JSC {
-
-ASSERT_CLASS_FITS_IN_CELL(JSCallbackObject<JSDestructibleObject>);
-ASSERT_CLASS_FITS_IN_CELL(JSCallbackObject<JSGlobalObject>);
 
 // Define the two types of JSCallbackObjects we support.

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2012-10-11  Geoffrey Garen  <ggaren@apple.com>
+
+        Removed ASSERT_CLASS_FITS_IN_CELL
+        https://bugs.webkit.org/show_bug.cgi?id=97634
+
+        Reviewed by Mark Hahnenberg.
+
+        Our collector now supports arbitrarily sized objects, so the ASSERT is not needed.
+
+        * API/JSCallbackFunction.cpp:
+        * API/JSCallbackObject.cpp:
+        * heap/MarkedSpace.h:
+        * jsc.cpp:
+        * runtime/Arguments.cpp:
+        * runtime/ArrayConstructor.cpp:
+        * runtime/ArrayPrototype.cpp:
+        * runtime/BooleanConstructor.cpp:
+        * runtime/BooleanObject.cpp:
+        * runtime/BooleanPrototype.cpp:
+        * runtime/DateConstructor.cpp:
+        * runtime/DatePrototype.cpp:
+        * runtime/Error.cpp:
+        * runtime/ErrorConstructor.cpp:
+        * runtime/ErrorPrototype.cpp:
+        * runtime/FunctionConstructor.cpp:
+        * runtime/FunctionPrototype.cpp:
+        * runtime/InternalFunction.cpp:
+        * runtime/JSActivation.cpp:
+        * runtime/JSArray.cpp:
+        * runtime/JSBoundFunction.cpp:
+        * runtime/JSFunction.cpp:
+        * runtime/JSGlobalObject.cpp:
+        * runtime/JSGlobalThis.cpp:
+        * runtime/JSNameScope.cpp:
+        * runtime/JSNotAnObject.cpp:
+        * runtime/JSONObject.cpp:
+        * runtime/JSObject.cpp:
+        * runtime/JSPropertyNameIterator.cpp:
+        * runtime/JSScope.cpp:
+        * runtime/JSWithScope.cpp:
+        * runtime/JSWrapperObject.cpp:
+        * runtime/MathObject.cpp:
+        * runtime/NameConstructor.cpp:
+        * runtime/NamePrototype.cpp:
+        * runtime/NativeErrorConstructor.cpp:
+        * runtime/NativeErrorPrototype.cpp:
+        * runtime/NumberConstructor.cpp:
+        * runtime/NumberObject.cpp:
+        * runtime/NumberPrototype.cpp:
+        * runtime/ObjectConstructor.cpp:
+        * runtime/ObjectPrototype.cpp:
+        * runtime/RegExpConstructor.cpp:
+        * runtime/RegExpMatchesArray.cpp:
+        * runtime/RegExpObject.cpp:
+        * runtime/RegExpPrototype.cpp:
+        * runtime/StringConstructor.cpp:
+        * runtime/StringObject.cpp:
+        * runtime/StringPrototype.cpp:
+        * testRegExp.cpp: Removed the ASSERT.
+
 2012-10-11  Filip Pizlo  <fpizlo@apple.com>
 

trunk/Source/JavaScriptCore/heap/MarkedSpace.h

@@ -35 +35 @@
 #include <wtf/Vector.h>
 
-#define ASSERT_CLASS_FITS_IN_CELL(class) COMPILE_ASSERT(sizeof(class) <= MarkedSpace::maxCellSize, class_fits_in_cell)
-
 namespace JSC {
 
@@ -69 +67 @@
     WTF_MAKE_NONCOPYABLE(MarkedSpace);
 public:
-    static const size_t maxCellSize = 2048;
-
     MarkedSpace(Heap*);
     ~MarkedSpace();

trunk/Source/JavaScriptCore/jsc.cpp

@@ -252 +252 @@
 
 COMPILE_ASSERT(!IsInteger<GlobalObject>::value, WTF_IsInteger_GlobalObject_false);
-ASSERT_CLASS_FITS_IN_CELL(GlobalObject);
 
 const ClassInfo GlobalObject::s_info = { "global", &JSGlobalObject::s_info, 0, ExecState::globalObjectTable, CREATE_METHOD_TABLE(GlobalObject) };

trunk/Source/JavaScriptCore/runtime/Arguments.cpp

@@ -34 +34 @@
 namespace JSC {
 
-ASSERT_CLASS_FITS_IN_CELL(Arguments);
-
 const ClassInfo Arguments::s_info = { "Arguments", &Base::s_info, 0, 0, CREATE_METHOD_TABLE(Arguments) };
 

trunk/Source/JavaScriptCore/runtime/ArrayConstructor.cpp

@@ -53 +53 @@
 @end
 */
-
-ASSERT_CLASS_FITS_IN_CELL(ArrayConstructor);
 
 ArrayConstructor::ArrayConstructor(JSGlobalObject* globalObject, Structure* structure)

trunk/Source/JavaScriptCore/runtime/ArrayPrototype.cpp

@@ -42 +42 @@
 
 namespace JSC {
-
-ASSERT_CLASS_FITS_IN_CELL(ArrayPrototype);
 
 static EncodedJSValue JSC_HOST_CALL arrayProtoFuncToString(ExecState*);

trunk/Source/JavaScriptCore/runtime/BooleanConstructor.cpp

@@ -27 +27 @@
 namespace JSC {
 
-ASSERT_CLASS_FITS_IN_CELL(BooleanConstructor);
 ASSERT_HAS_TRIVIAL_DESTRUCTOR(BooleanConstructor);
 

trunk/Source/JavaScriptCore/runtime/BooleanObject.cpp

@@ -26 +26 @@
 namespace JSC {
 
-ASSERT_CLASS_FITS_IN_CELL(BooleanObject);
 ASSERT_HAS_TRIVIAL_DESTRUCTOR(BooleanObject);
 

trunk/Source/JavaScriptCore/runtime/BooleanPrototype.cpp

@@ -48 +48 @@
 */
 
-ASSERT_CLASS_FITS_IN_CELL(BooleanPrototype);
 ASSERT_HAS_TRIVIAL_DESTRUCTOR(BooleanPrototype);
 

trunk/Source/JavaScriptCore/runtime/DateConstructor.cpp

@@ -72 +72 @@
 */
 
-ASSERT_CLASS_FITS_IN_CELL(DateConstructor);
 ASSERT_HAS_TRIVIAL_DESTRUCTOR(DateConstructor);
 

trunk/Source/JavaScriptCore/runtime/DatePrototype.cpp

@@ -70 +70 @@
 
 namespace JSC {
-
-ASSERT_CLASS_FITS_IN_CELL(DatePrototype);
 
 static EncodedJSValue JSC_HOST_CALL dateProtoFuncGetDate(ExecState*);

trunk/Source/JavaScriptCore/runtime/Error.cpp

@@ -178 +178 @@
 }
 
-ASSERT_CLASS_FITS_IN_CELL(StrictModeTypeErrorFunction);
-
 const ClassInfo StrictModeTypeErrorFunction::s_info = { "Function", &Base::s_info, 0, 0, CREATE_METHOD_TABLE(StrictModeTypeErrorFunction) };
 

trunk/Source/JavaScriptCore/runtime/ErrorConstructor.cpp

@@ -28 +28 @@
 namespace JSC {
 
-ASSERT_CLASS_FITS_IN_CELL(ErrorConstructor);
 ASSERT_HAS_TRIVIAL_DESTRUCTOR(ErrorConstructor);
 

trunk/Source/JavaScriptCore/runtime/ErrorPrototype.cpp

@@ -31 +31 @@
 namespace JSC {
 
-ASSERT_CLASS_FITS_IN_CELL(ErrorPrototype);
 ASSERT_HAS_TRIVIAL_DESTRUCTOR(ErrorPrototype);
 
@@ -49 +48 @@
 @end
 */
-
-ASSERT_CLASS_FITS_IN_CELL(ErrorPrototype);
 
 ErrorPrototype::ErrorPrototype(ExecState* exec, Structure* structure)

trunk/Source/JavaScriptCore/runtime/FunctionConstructor.cpp

@@ -35 +35 @@
 namespace JSC {
 
-ASSERT_CLASS_FITS_IN_CELL(FunctionConstructor);
 ASSERT_HAS_TRIVIAL_DESTRUCTOR(FunctionConstructor);
 

trunk/Source/JavaScriptCore/runtime/FunctionPrototype.cpp

@@ -33 +33 @@
 namespace JSC {
 
-ASSERT_CLASS_FITS_IN_CELL(FunctionPrototype);
 ASSERT_HAS_TRIVIAL_DESTRUCTOR(FunctionPrototype);
 

trunk/Source/JavaScriptCore/runtime/InternalFunction.cpp

@@ -30 +30 @@
 namespace JSC {
 
-ASSERT_CLASS_FITS_IN_CELL(InternalFunction);
 ASSERT_HAS_TRIVIAL_DESTRUCTOR(InternalFunction);
 

trunk/Source/JavaScriptCore/runtime/JSActivation.cpp

@@ -38 +38 @@
 namespace JSC {
 
-ASSERT_CLASS_FITS_IN_CELL(JSActivation);
-
 const ClassInfo JSActivation::s_info = { "JSActivation", &Base::s_info, 0, 0, CREATE_METHOD_TABLE(JSActivation) };
 

trunk/Source/JavaScriptCore/runtime/JSArray.cpp

@@ -45 +45 @@
 namespace JSC {
 
-
-ASSERT_CLASS_FITS_IN_CELL(JSArray);
 ASSERT_HAS_TRIVIAL_DESTRUCTOR(JSArray);
 

trunk/Source/JavaScriptCore/runtime/JSBoundFunction.cpp

@@ -32 +32 @@
 namespace JSC {
 
-ASSERT_CLASS_FITS_IN_CELL(JSBoundFunction);
 ASSERT_HAS_TRIVIAL_DESTRUCTOR(JSBoundFunction);
 

trunk/Source/JavaScriptCore/runtime/JSFunction.cpp

@@ -49 +49 @@
 }
 
-ASSERT_CLASS_FITS_IN_CELL(JSFunction);
 ASSERT_HAS_TRIVIAL_DESTRUCTOR(JSFunction);
 

trunk/Source/JavaScriptCore/runtime/JSGlobalObject.cpp

@@ -101 +101 @@
 */
 
-ASSERT_CLASS_FITS_IN_CELL(JSGlobalObject);
-
 // Default number of ticks before a timeout check should be done.
 static const int initialTickCountThreshold = 255;

trunk/Source/JavaScriptCore/runtime/JSNameScope.cpp

@@ -30 +30 @@
 
 namespace JSC {
-
-ASSERT_CLASS_FITS_IN_CELL(JSNameScope);
 
 const ClassInfo JSNameScope::s_info = { "NameScope", &Base::s_info, 0, 0, CREATE_METHOD_TABLE(JSNameScope) };

trunk/Source/JavaScriptCore/runtime/JSNotAnObject.cpp

@@ -35 +35 @@
 namespace JSC {
 
-ASSERT_CLASS_FITS_IN_CELL(JSNotAnObject);
 ASSERT_HAS_TRIVIAL_DESTRUCTOR(JSNotAnObject);
 

trunk/Source/JavaScriptCore/runtime/JSONObject.cpp

@@ -42 +42 @@
 namespace JSC {
 
-ASSERT_CLASS_FITS_IN_CELL(JSONObject);
 ASSERT_HAS_TRIVIAL_DESTRUCTOR(JSONObject);
 

trunk/Source/JavaScriptCore/runtime/JSObject.cpp

@@ -62 +62 @@
     return 0;
 }
-
-ASSERT_CLASS_FITS_IN_CELL(JSObject);
-ASSERT_CLASS_FITS_IN_CELL(JSNonFinalObject);
-ASSERT_CLASS_FITS_IN_CELL(JSFinalObject);
 
 ASSERT_HAS_TRIVIAL_DESTRUCTOR(JSObject);

trunk/Source/JavaScriptCore/runtime/JSPropertyNameIterator.cpp

@@ -33 +33 @@
 
 namespace JSC {
-
-ASSERT_CLASS_FITS_IN_CELL(JSPropertyNameIterator);
 
 const ClassInfo JSPropertyNameIterator::s_info = { "JSPropertyNameIterator", 0, 0, 0, CREATE_METHOD_TABLE(JSPropertyNameIterator) };

trunk/Source/JavaScriptCore/runtime/JSProxy.cpp

@@ -31 +31 @@
 namespace JSC {
 
-ASSERT_CLASS_FITS_IN_CELL(JSProxy);
 ASSERT_HAS_TRIVIAL_DESTRUCTOR(JSProxy);
 

trunk/Source/JavaScriptCore/runtime/JSScope.cpp

@@ -34 +34 @@
 namespace JSC {
 
-ASSERT_CLASS_FITS_IN_CELL(JSScope);
 ASSERT_HAS_TRIVIAL_DESTRUCTOR(JSScope);
 

trunk/Source/JavaScriptCore/runtime/JSWithScope.cpp

@@ -29 +29 @@
 namespace JSC {
 
-ASSERT_CLASS_FITS_IN_CELL(JSWithScope);
-
 const ClassInfo JSWithScope::s_info = { "WithScope", &Base::s_info, 0, 0, CREATE_METHOD_TABLE(JSWithScope) };
 

trunk/Source/JavaScriptCore/runtime/JSWrapperObject.cpp

@@ -25 +25 @@
 namespace JSC {
 
-ASSERT_CLASS_FITS_IN_CELL(JSWrapperObject);
 ASSERT_HAS_TRIVIAL_DESTRUCTOR(JSWrapperObject);
 

trunk/Source/JavaScriptCore/runtime/MathObject.cpp

@@ -33 +33 @@
 namespace JSC {
 
-ASSERT_CLASS_FITS_IN_CELL(MathObject);
 ASSERT_HAS_TRIVIAL_DESTRUCTOR(MathObject);
 

trunk/Source/JavaScriptCore/runtime/NameConstructor.cpp

@@ -32 +32 @@
 namespace JSC {
 
-ASSERT_CLASS_FITS_IN_CELL(NameConstructor);
 ASSERT_HAS_TRIVIAL_DESTRUCTOR(NameConstructor);
 

trunk/Source/JavaScriptCore/runtime/NamePrototype.cpp

@@ -31 +31 @@
 namespace JSC {
 
-ASSERT_CLASS_FITS_IN_CELL(NamePrototype);
-
 static EncodedJSValue JSC_HOST_CALL privateNameProtoFuncToString(ExecState*);
 
@@ -48 +46 @@
 @end
 */
-
-ASSERT_CLASS_FITS_IN_CELL(NamePrototype);
 
 NamePrototype::NamePrototype(ExecState* exec, Structure* structure)

trunk/Source/JavaScriptCore/runtime/NativeErrorConstructor.cpp

@@ -29 +29 @@
 namespace JSC {
 
-ASSERT_CLASS_FITS_IN_CELL(NativeErrorConstructor);
 ASSERT_HAS_TRIVIAL_DESTRUCTOR(NativeErrorConstructor);
 

trunk/Source/JavaScriptCore/runtime/NativeErrorPrototype.cpp

@@ -28 +28 @@
 namespace JSC {
 
-ASSERT_CLASS_FITS_IN_CELL(NativeErrorPrototype);
-
 NativeErrorPrototype::NativeErrorPrototype(ExecState* exec, Structure* structure)
     : ErrorPrototype(exec, structure)

trunk/Source/JavaScriptCore/runtime/NumberConstructor.cpp

@@ -28 +28 @@
 
 namespace JSC {
-
-ASSERT_CLASS_FITS_IN_CELL(NumberConstructor);
 
 static JSValue numberConstructorNaNValue(ExecState*, JSValue, PropertyName);

trunk/Source/JavaScriptCore/runtime/NumberObject.cpp

@@ -28 +28 @@
 namespace JSC {
 
-ASSERT_CLASS_FITS_IN_CELL(NumberObject);
 ASSERT_HAS_TRIVIAL_DESTRUCTOR(NumberObject);
 

trunk/Source/JavaScriptCore/runtime/NumberPrototype.cpp

@@ -69 +69 @@
 */
 
-ASSERT_CLASS_FITS_IN_CELL(NumberPrototype);
 ASSERT_HAS_TRIVIAL_DESTRUCTOR(NumberPrototype);
 

trunk/Source/JavaScriptCore/runtime/ObjectConstructor.cpp

@@ -36 +36 @@
 namespace JSC {
 
-ASSERT_CLASS_FITS_IN_CELL(ObjectConstructor);
-
 static EncodedJSValue JSC_HOST_CALL objectConstructorGetPrototypeOf(ExecState*);
 static EncodedJSValue JSC_HOST_CALL objectConstructorGetOwnPropertyDescriptor(ExecState*);

trunk/Source/JavaScriptCore/runtime/ObjectPrototype.cpp

@@ -64 +64 @@
 */
 
-ASSERT_CLASS_FITS_IN_CELL(ObjectPrototype);
-
 ObjectPrototype::ObjectPrototype(ExecState* exec, Structure* stucture)
     : JSNonFinalObject(exec->globalData(), stucture)

trunk/Source/JavaScriptCore/runtime/RegExpConstructor.cpp

@@ -53 +53 @@
 
 namespace JSC {
-
-ASSERT_CLASS_FITS_IN_CELL(RegExpConstructor);
 
 const ClassInfo RegExpConstructor::s_info = { "Function", &InternalFunction::s_info, 0, ExecState::regExpConstructorTable, CREATE_METHOD_TABLE(RegExpConstructor) };

trunk/Source/JavaScriptCore/runtime/RegExpMatchesArray.cpp

@@ -30 +30 @@
 
 namespace JSC {
-
-ASSERT_CLASS_FITS_IN_CELL(RegExpMatchesArray);
 
 const ClassInfo RegExpMatchesArray::s_info = {"Array", &JSArray::s_info, 0, 0, CREATE_METHOD_TABLE(RegExpMatchesArray)};

trunk/Source/JavaScriptCore/runtime/RegExpObject.cpp

@@ -50 +50 @@
 namespace JSC {
 
-ASSERT_CLASS_FITS_IN_CELL(RegExpObject);
 ASSERT_HAS_TRIVIAL_DESTRUCTOR(RegExpObject);
 

trunk/Source/JavaScriptCore/runtime/RegExpPrototype.cpp

@@ -59 +59 @@
 @end
 */
-
-ASSERT_CLASS_FITS_IN_CELL(RegExpPrototype);
 
 RegExpPrototype::RegExpPrototype(JSGlobalObject* globalObject, Structure* structure, RegExp* regExp)

trunk/Source/JavaScriptCore/runtime/StringConstructor.cpp

@@ -46 +46 @@
 */
 
-ASSERT_CLASS_FITS_IN_CELL(StringConstructor);
 ASSERT_HAS_TRIVIAL_DESTRUCTOR(StringConstructor);
 

trunk/Source/JavaScriptCore/runtime/StringObject.cpp

@@ -28 +28 @@
 namespace JSC {
 
-ASSERT_CLASS_FITS_IN_CELL(StringObject);
 ASSERT_HAS_TRIVIAL_DESTRUCTOR(StringObject);
 

trunk/Source/JavaScriptCore/runtime/StringPrototype.cpp

@@ -48 +48 @@
 namespace JSC {
 
-ASSERT_CLASS_FITS_IN_CELL(StringPrototype);
 ASSERT_HAS_TRIVIAL_DESTRUCTOR(StringPrototype);
 

trunk/Source/JavaScriptCore/testRegExp.cpp

@@ -139 +139 @@
 
 COMPILE_ASSERT(!IsInteger<GlobalObject>::value, WTF_IsInteger_GlobalObject_false);
-ASSERT_CLASS_FITS_IN_CELL(GlobalObject);
 
 const ClassInfo GlobalObject::s_info = { "global", &JSGlobalObject::s_info, 0, ExecState::globalObjectTable, CREATE_METHOD_TABLE(GlobalObject) };

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-10-11  Geoffrey Garen  <ggaren@apple.com>
+
+        Removed ASSERT_CLASS_FITS_IN_CELL
+        https://bugs.webkit.org/show_bug.cgi?id=97634
+
+        Reviewed by Mark Hahnenberg.
+
+        * bindings/js/JSDOMWindowShell.cpp:
+        (WebCore):
+        * bindings/js/JSImageConstructor.cpp:
+        (WebCore):
+        * bindings/js/JSNodeFilterCondition.cpp:
+        (WebCore):
+        * bindings/js/JSWorkerContextBase.cpp:
+        (WebCore):
+        * bindings/scripts/CodeGeneratorJS.pm:
+        (GenerateImplementation):
+        * bindings/scripts/test/JS/JSFloat64Array.cpp:
+        (WebCore):
+        * bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
+        (WebCore):
+        * bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:
+        (WebCore):
+        * bindings/scripts/test/JS/JSTestEventConstructor.cpp:
+        (WebCore):
+        * bindings/scripts/test/JS/JSTestEventTarget.cpp:
+        (WebCore):
+        * bindings/scripts/test/JS/JSTestException.cpp:
+        (WebCore):
+        * bindings/scripts/test/JS/JSTestInterface.cpp:
+        (WebCore):
+        * bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
+        (WebCore):
+        * bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
+        (WebCore):
+        * bindings/scripts/test/JS/JSTestNode.cpp:
+        (WebCore):
+        * bindings/scripts/test/JS/JSTestObj.cpp:
+        (WebCore):
+        * bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
+        (WebCore):
+        * bridge/runtime_method.cpp:
+        (JSC):
+
 2012-10-10  Brady Eidson  <beidson@apple.com>
 

trunk/Source/WebCore/bindings/js/JSDOMWindowShell.cpp

@@ -40 +40 @@
 
 namespace WebCore {
-
-ASSERT_CLASS_FITS_IN_CELL(JSDOMWindowShell);
 
 const ClassInfo JSDOMWindowShell::s_info = { "JSDOMWindowShell", &Base::s_info, 0, 0, CREATE_METHOD_TABLE(JSDOMWindowShell) };

trunk/Source/WebCore/bindings/js/JSImageConstructor.cpp

@@ -31 +31 @@
 namespace WebCore {
 
-ASSERT_CLASS_FITS_IN_CELL(JSImageConstructor);
 ASSERT_HAS_TRIVIAL_DESTRUCTOR(JSImageConstructor);
 

trunk/Source/WebCore/bindings/js/JSNodeFilterCondition.cpp

@@ -31 +31 @@
 
 using namespace JSC;
-
-ASSERT_CLASS_FITS_IN_CELL(JSNodeFilterCondition);
 
 JSNodeFilterCondition::JSNodeFilterCondition(JSGlobalData&, NodeFilter* owner, JSValue filter)

trunk/Source/WebCore/bindings/js/JSWorkerContextBase.cpp

@@ -44 +44 @@
 
 namespace WebCore {
-
-ASSERT_CLASS_FITS_IN_CELL(JSWorkerContextBase);
 
 const ClassInfo JSWorkerContextBase::s_info = { "WorkerContext", &JSDOMGlobalObject::s_info, 0, 0, CREATE_METHOD_TABLE(JSWorkerContextBase) };

trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm

@@ -1420 +1420 @@
     push(@implContent, "\nusing namespace JSC;\n\n");
     push(@implContent, "namespace WebCore {\n\n");
-
-    push(@implContent, "ASSERT_CLASS_FITS_IN_CELL($className);\n");
 
     my $numAttributes = GenerateAttributesHashTable($object, $dataNode);

trunk/Source/WebCore/bindings/scripts/test/JS/JSFloat64Array.cpp

@@ -37 +37 @@
 namespace WebCore {
 
-ASSERT_CLASS_FITS_IN_CELL(JSFloat64Array);
 /* Hash table */
 

trunk/Source/WebCore/bindings/scripts/test/JS/JSTestActiveDOMObject.cpp

@@ -34 +34 @@
 namespace WebCore {
 
-ASSERT_CLASS_FITS_IN_CELL(JSTestActiveDOMObject);
 /* Hash table */
 

trunk/Source/WebCore/bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp

@@ -33 +33 @@
 namespace WebCore {
 
-ASSERT_CLASS_FITS_IN_CELL(JSTestCustomNamedGetter);
 /* Hash table */
 

trunk/Source/WebCore/bindings/scripts/test/JS/JSTestEventConstructor.cpp

@@ -33 +33 @@
 namespace WebCore {
 
-ASSERT_CLASS_FITS_IN_CELL(JSTestEventConstructor);
 /* Hash table for constructor */
 

trunk/Source/WebCore/bindings/scripts/test/JS/JSTestEventTarget.cpp

@@ -39 +39 @@
 namespace WebCore {
 
-ASSERT_CLASS_FITS_IN_CELL(JSTestEventTarget);
 /* Hash table */
 

trunk/Source/WebCore/bindings/scripts/test/JS/JSTestException.cpp

@@ -31 +31 @@
 namespace WebCore {
 
-ASSERT_CLASS_FITS_IN_CELL(JSTestException);
 /* Hash table */
 

trunk/Source/WebCore/bindings/scripts/test/JS/JSTestInterface.cpp

@@ -49 +49 @@
 namespace WebCore {
 
-ASSERT_CLASS_FITS_IN_CELL(JSTestInterface);
 /* Hash table */
 

trunk/Source/WebCore/bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp

@@ -33 +33 @@
 namespace WebCore {
 
-ASSERT_CLASS_FITS_IN_CELL(JSTestMediaQueryListListener);
 /* Hash table */
 

trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNamedConstructor.cpp

@@ -32 +32 @@
 namespace WebCore {
 
-ASSERT_CLASS_FITS_IN_CELL(JSTestNamedConstructor);
 /* Hash table for constructor */
 

trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNode.cpp

@@ -32 +32 @@
 namespace WebCore {
 
-ASSERT_CLASS_FITS_IN_CELL(JSTestNode);
 /* Hash table */
 

trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp

@@ -78 +78 @@
 namespace WebCore {
 
-ASSERT_CLASS_FITS_IN_CELL(JSTestObj);
 /* Hash table */
 

trunk/Source/WebCore/bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp

@@ -40 +40 @@
 namespace WebCore {
 
-ASSERT_CLASS_FITS_IN_CELL(JSTestSerializedScriptValueInterface);
 /* Hash table */
 

trunk/Source/WebCore/bridge/runtime_method.cpp

@@ -39 +39 @@
 
 using namespace Bindings;
-
-ASSERT_CLASS_FITS_IN_CELL(RuntimeMethod);
 
 const ClassInfo RuntimeMethod::s_info = { "RuntimeMethod", &InternalFunction::s_info, 0, 0, CREATE_METHOD_TABLE(RuntimeMethod) };