Changeset 131106 in webkit


Ignore:
Timestamp:
Oct 11, 2012 4:08:13 PM (12 years ago)
Author:
simonjam@chromium.org
Message:

unprefix window.performance.webkitNow()
​https://bugs.webkit.org/show_bug.cgi?id=88278

Reviewed by Tony Gentilcore.

PerformanceTests:

  • resources/runner.js: Bind to proper object to avoid invalid invocation errors.

Source/WebCore:

Test: fast/dom/Window/window-properties-performance.html

fast/performance/performance-now-timestamps.html

  • page/Performance.cpp:

(WebCore::Performance::now):

  • page/Performance.h:

(Performance):

  • page/Performance.idl:

LayoutTests:

  • fast/dom/Window/window-properties-performance-expected.txt:
  • fast/performance/performance-now-timestamps-expected.txt:
  • fast/performance/script-tests/performance-now-timestamps.js:
  • platform/chromium/TestExpectations: Remove skipped expectation.
  • platform/efl/TestExpectations:
  • platform/efl/fast/dom/Window/window-properties-performance-expected.txt:
  • platform/gtk/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/qt/fast/dom/Window/window-properties-performance-expected.txt:
  • resources/magnitude-perf.js:

(Magnitude._runIteration):

Location:
trunk
Files:
17 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r131103 r131106  
     12012-10-11  James Simonsen  <simonjam@chromium.org>
     2
     3        unprefix window.performance.webkitNow()
     4        https://bugs.webkit.org/show_bug.cgi?id=88278
     5
     6        Reviewed by Tony Gentilcore.
     7
     8        * fast/dom/Window/window-properties-performance-expected.txt:
     9        * fast/performance/performance-now-timestamps-expected.txt:
     10        * fast/performance/script-tests/performance-now-timestamps.js:
     11        * platform/chromium/TestExpectations: Remove skipped expectation.
     12        * platform/efl/TestExpectations:
     13        * platform/efl/fast/dom/Window/window-properties-performance-expected.txt:
     14        * platform/gtk/TestExpectations:
     15        * platform/qt/TestExpectations:
     16        * platform/qt/fast/dom/Window/window-properties-performance-expected.txt:
     17        * resources/magnitude-perf.js:
     18        (Magnitude._runIteration):
     19
    1202012-10-11  Huang Dongsung  <luxtella@company100.net>
    221

  • trunk/LayoutTests/fast/dom/Window/window-properties-performance-expected.txt

    r115503 r131106  
    1313window.performance.navigation.redirectCount [number]
    1414window.performance.navigation.type [number]
     15window.performance.now [function]
    1516window.performance.timing [object PerformanceTiming]
    1617window.performance.timing.connectEnd [number]
    … …  
    3536window.performance.timing.unloadEventEnd [number]
    3637window.performance.timing.unloadEventStart [number]
    37 window.performance.webkitNow [function]
    3838window.performance.timing [printed above as window.performance.timing]
    3939window.performance.navigation [printed above as window.performance.navigation]

  • trunk/LayoutTests/fast/performance/performance-now-timestamps-expected.txt

    r115503 r131106  
    1 Tests the timestamps from performance.webkitNow increase and are in milliseconds
     1Tests the timestamps from performance.now increase and are in milliseconds
    22
    33On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".

  • trunk/LayoutTests/fast/performance/script-tests/performance-now-timestamps.js

    r115503 r131106  
    1 description("Tests the timestamps from performance.webkitNow increase and are in milliseconds");
     1description("Tests the timestamps from performance.now increase and are in milliseconds");
    22
    33function busyWait(millis) {
    … …  
    66}
    77
    8 var firstTimestamp = window.performance.webkitNow();
     8var firstTimestamp = window.performance.now();
    99shouldBeDefined("firstTimestamp");
    1010shouldBeGreaterThanOrEqual("firstTimestamp", "0");
    … …  
    1818busyWait(waitTime);
    1919
    20 var secondTimestamp = window.performance.webkitNow();
     20var secondTimestamp = window.performance.now();
    2121shouldBeDefined("secondTimestamp");
    2222shouldBeGreaterThanOrEqual("secondTimestamp", "firstTimestamp + (waitTime / 2)");

  • trunk/LayoutTests/platform/chromium/TestExpectations

    r131084 r131106  
    40214021webkit.org/b/98948 [ Linux Debug ] http/tests/media/media-source/video-media-source-play.html [ PASS CRASH ]
    40224022
    4023 # Skipped until the prefix is removed.
    4024 webkit.org/b/98953 http/tests/w3c/webperf/approved/HighResolutionTime [ Skip ]
    4025 
    40264023webkit.org/b/99089 transforms/3d/general/perspective-units.html [ Pass ImageOnlyFailure ]

  • trunk/LayoutTests/platform/efl/TestExpectations

    r131058 r131106  
    14271427webkit.org/b/98729 fast/spatial-navigation/snav-iframe-nested.html [ Failure ]
    14281428
    1429 # Skipped until the prefix is removed.
    1430 webkit.org/b/98953 http/tests/w3c/webperf/approved/HighResolutionTime [ Skip ]
    1431 
    14321429# New inspector/profiler/memory-instrumentation-canvas.html fails on JSC platforms
    14331430webkit.org/b/99001 inspector/profiler/memory-instrumentation-canvas.html

  • trunk/LayoutTests/platform/efl/fast/dom/Window/window-properties-performance-expected.txt

    r116118 r131106  
    1313window.performance.navigation.redirectCount [number]
    1414window.performance.navigation.type [number]
     15window.performance.now [function]
    1516window.performance.timing [object PerformanceTiming]
    1617window.performance.timing.connectEnd [number]
    … …  
    3536window.performance.timing.unloadEventEnd [number]
    3637window.performance.timing.unloadEventStart [number]
    37 window.performance.webkitNow [function]
    3838window.performance.timing [printed above as window.performance.timing]
    3939window.performance.navigation [printed above as window.performance.navigation]

  • trunk/LayoutTests/platform/gtk/TestExpectations

    r131062 r131106  
    13611361webkit.org/b/98729 svg/custom/object-data-href.html [ ImageOnlyFailure ]
    13621362
    1363 # Skipped until the prefix is removed.
    1364 webkit.org/b/98953 http/tests/w3c/webperf/approved/HighResolutionTime [ Skip ]
    1365 
    13661363# New inspector/profiler/memory-instrumentation-canvas.html fails on JSC platforms
    13671364webkit.org/b/99001 inspector/profiler/memory-instrumentation-canvas.html

  • trunk/LayoutTests/platform/qt/TestExpectations

    r131080 r131106  
    24452445webkit.org/b/98640 plugins/refcount-leaks.html
    24462446
    2447 # Skipped until the prefix is removed.
    2448 webkit.org/b/98953 http/tests/w3c/webperf/approved/HighResolutionTime [ Skip ]
    2449 
    24502447# New inspector/profiler/memory-instrumentation-canvas.html fails on JSC platforms
    24512448webkit.org/b/99001 inspector/profiler/memory-instrumentation-canvas.html

  • trunk/LayoutTests/platform/qt/fast/dom/Window/window-properties-performance-expected.txt

    r115503 r131106  
    1313window.performance.navigation.redirectCount [number]
    1414window.performance.navigation.type [number]
     15window.performance.now [function]
    1516window.performance.timing [object PerformanceTiming]
    1617window.performance.timing.connectEnd [number]
    … …  
    3536window.performance.timing.unloadEventEnd [number]
    3637window.performance.timing.unloadEventStart [number]
    37 window.performance.webkitNow [function]
    3838window.performance.timing [printed above as window.performance.timing]
    3939window.performance.navigation [printed above as window.performance.navigation]

  • trunk/LayoutTests/resources/magnitude-perf.js

    r130533 r131106  
    202202
    203203    var iterations = 0;
    204     var nowFunction = window.performance.now || Date.now;
     204    var nowFunction = window.performance.now.bind(window.performance) || Date.now;
    205205    var start = nowFunction();
    206206    while (nowFunction() - start < Magnitude.millisecondsPerIteration) {

  • trunk/PerformanceTests/ChangeLog

    r130713 r131106  
     12012-10-11  James Simonsen  <simonjam@chromium.org>
     2
     3        unprefix window.performance.webkitNow()
     4        https://bugs.webkit.org/show_bug.cgi?id=88278
     5
     6        Reviewed by Tony Gentilcore.
     7
     8        * resources/runner.js: Bind to proper object to avoid invalid invocation errors.
     9
    1102012-10-08  Ryosuke Niwa  <rniwa@webkit.org>
    211

  • trunk/PerformanceTests/resources/runner.js

    r130181 r131106  
    4343    };
    4444
    45     PerfTestRunner.now = window.performance && window.performance.webkitNow ? function () { return window.performance.webkitNow(); } : Date.now;
     45    PerfTestRunner.now = window.performance && window.performance.now ? function () { return window.performance.now(); } : Date.now;
    4646
    4747    PerfTestRunner.logInfo = function (text) {

  • trunk/Source/WebCore/ChangeLog

    r131105 r131106  
     12012-10-11  James Simonsen  <simonjam@chromium.org>
     2
     3        unprefix window.performance.webkitNow()
     4        https://bugs.webkit.org/show_bug.cgi?id=88278
     5
     6        Reviewed by Tony Gentilcore.
     7
     8        Test: fast/dom/Window/window-properties-performance.html
     9              fast/performance/performance-now-timestamps.html
     10
     11        * page/Performance.cpp:
     12        (WebCore::Performance::now):
     13        * page/Performance.h:
     14        (Performance):
     15        * page/Performance.idl:
     16
    1172012-10-11  Roger Fong  <roger_fong@apple.com>
    218

  • trunk/Source/WebCore/page/Performance.cpp

    r131001 r131106  
    166166}
    167167
    168 double Performance::webkitNow() const
     168double Performance::now() const
    169169{
    170170    return 1000.0 * m_frame->document()->loader()->timing()->monotonicTimeToZeroBasedDocumentTime(monotonicallyIncreasingTime());

  • trunk/Source/WebCore/page/Performance.h

    r121313 r131106  
    6262    PerformanceNavigation* navigation() const;
    6363    PerformanceTiming* timing() const;
    64     double webkitNow() const;
     64    double now() const;
    6565
    6666#if ENABLE(PERFORMANCE_TIMELINE)

  • trunk/Source/WebCore/page/Performance.idl

    r120962 r131106  
    5454#endif
    5555        // See http://www.w3.org/TR/hr-time/ for details.
    56         double webkitNow();
     56        double now();
    5757    };
    5858
Note: See TracChangeset for help on using the changeset viewer.