Changeset 131715 in webkit

Timestamp:

Oct 18, 2012 1:25:48 AM (12 years ago)

Author:

commit-queue@webkit.org

Message:

[EFL] Add unit test for ewk_frame_source_get.
​https://bugs.webkit.org/show_bug.cgi?id=95984

Patch by Kangil Han <​kangil.han@samsung.com> on 2012-10-18
Reviewed by Gyuyoung Kim.

Source/WebKit:

Add test_ewk_frame.cpp for unit test.

• PlatformEfl.cmake:

Source/WebKit/efl:

Add three unit test cases to verify ewk_frame_source_get function.
Additionally, insert code to check if uri exists in order to return error since view itself has blank html.

• ewk/ewk_frame.cpp:

(ewk_frame_source_get):

• tests/test_ewk_frame.cpp: Added.

(initBuffer):
(TEST_F):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• PlatformEfl.cmake (modified) (1 diff)
• efl/ChangeLog (modified) (1 diff)
• efl/ewk/ewk_frame.cpp (modified) (1 diff)
• efl/tests/test_ewk_frame.cpp (added)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2012-10-18  Kangil Han  <kangil.han@samsung.com>
+
+        [EFL] Add unit test for ewk_frame_source_get.
+        https://bugs.webkit.org/show_bug.cgi?id=95984
+
+        Reviewed by Gyuyoung Kim.
+
+        Add test_ewk_frame.cpp for unit test.
+
+        * PlatformEfl.cmake:
+
 2012-10-15  David Kilzer  <ddkilzer@apple.com>
 

trunk/Source/WebKit/PlatformEfl.cmake

@@ -243 +243 @@
 
 SET(EWKUnitTests_BINARIES
+    test_ewk_frame
     test_ewk_view
 )

trunk/Source/WebKit/efl/ChangeLog

@@ +1 @@
+2012-10-18  Kangil Han  <kangil.han@samsung.com>
+
+        [EFL] Add unit test for ewk_frame_source_get.
+        https://bugs.webkit.org/show_bug.cgi?id=95984
+
+        Reviewed by Gyuyoung Kim.
+
+        Add three unit test cases to verify ewk_frame_source_get function.
+        Additionally, insert code to check if uri exists in order to return error since view itself has blank html.
+
+        * ewk/ewk_frame.cpp:
+        (ewk_frame_source_get):
+        * tests/test_ewk_frame.cpp: Added.
+        (initBuffer):
+        (TEST_F):
+
 2012-10-17  Byungwoo Lee  <bw80.lee@samsung.com>
 

trunk/Source/WebKit/efl/ewk/ewk_frame.cpp

@@ -1642 +1642 @@
     *frameSource = 0; // Saves 0 to pointer until it's not allocated.
 
+    if (!ewk_frame_uri_get(ewkFrame))
+        return -1;
+
     if (!smartData->frame->document()->isHTMLDocument()) {
         // FIXME: Support others documents.