Changeset 132136 in webkit
- Timestamp:
- Oct 22, 2012 2:32:01 PM (11 years ago)
- Location:
- trunk
- Files:
-
- 14 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r132135 r132136 1 2012-10-22 Tony Chang <tony@chromium.org> 2 3 WebKit does not support 'flex-wrap: nowrap' 4 https://bugs.webkit.org/show_bug.cgi?id=99924 5 6 Reviewed by Ojan Vafai. 7 8 Update expectations (find and replace none with nowrap). 9 10 * css3/flexbox/css-properties-expected.txt: 11 * css3/flexbox/css-properties.html: 12 * fast/css/getComputedStyle/computed-style-expected.txt: 13 * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: 14 * svg/css/getComputedStyle-basic-expected.txt: 15 1 16 2012-10-22 Emil A Eklund <eae@chromium.org> 2 17 … … 1716 1731 * platform/gtk/accessibility/media-controls-panel-title.html: Updated. 1717 1732 1718 2012-10- 19Emil A Eklund <eae@chromium.org>1733 2012-10-22 Emil A Eklund <eae@chromium.org> 1719 1734 1720 1735 Convert fast/sub-pixel/file-upload-control-at-fractional-offset-expected.html to ref test … … 1737 1752 * platform/gtk/fast/sub-pixel/file-upload-control-at-fractional-offset-expected.txt: Removed. 1738 1753 1739 <<<<<<< .mine1740 2012-10-22 Emil A Eklund <eae@chromium.org>1741 1742 Convert fast/sub-pixel/file-upload-control-at-fractional-offset-expected.html to ref test1743 https://bugs.webkit.org/show_bug.cgi?id=998691744 1745 Reviewed by Eric Seidel.1746 1747 * fast/sub-pixel/file-upload-control-at-fractional-offset-expected.html: Added.1748 * platform/chromium-linux/fast/sub-pixel/file-upload-control-at-fractional-offset-expected.png: Removed.1749 * platform/chromium-linux/fast/sub-pixel/file-upload-control-at-fractional-offset-expected.txt: Removed.1750 * platform/chromium-mac-snowleopard/fast/sub-pixel/file-upload-control-at-fractional-offset-expected.png: Removed.1751 * platform/chromium-mac/fast/sub-pixel/file-upload-control-at-fractional-offset-expected.png: Removed.1752 * platform/chromium-mac/fast/sub-pixel/file-upload-control-at-fractional-offset-expected.txt: Removed.1753 * platform/chromium-win/fast/sub-pixel/file-upload-control-at-fractional-offset-expected.png: Removed.1754 * platform/chromium-win/fast/sub-pixel/file-upload-control-at-fractional-offset-expected.txt: Removed.1755 * platform/gtk/fast/sub-pixel/file-upload-control-at-fractional-offset-expected.png: Removed.1756 * platform/gtk/fast/sub-pixel/file-upload-control-at-fractional-offset-expected.txt: Removed.1757 1758 =======1759 1754 2012-10-16 Andrey Kosyakov <caseq@chromium.org> 1760 1755 … … 1768 1763 * inspector/timeline/timeline-enum-stability-expected.txt: 1769 1764 1770 >>>>>>> .r1320881771 1765 2012-10-22 Vsevolod Vlasov <vsevik@chromium.org> 1772 1766 -
trunk/LayoutTests/css3/flexbox/css-properties-expected.txt
r124276 r132136 89 89 PASS window.getComputedStyle(flexbox, null).webkitFlexDirection is "column-reverse" 90 90 PASS flexbox.style.webkitFlexWrap is "" 91 PASS window.getComputedStyle(flexbox, null).webkitFlexWrap is "no ne"91 PASS window.getComputedStyle(flexbox, null).webkitFlexWrap is "nowrap" 92 92 PASS flexbox.style.webkitFlexWrap is "" 93 PASS flexbox.style.webkitFlexWrap is "no ne"94 PASS window.getComputedStyle(flexbox, null).webkitFlexWrap is "no ne"93 PASS flexbox.style.webkitFlexWrap is "nowrap" 94 PASS window.getComputedStyle(flexbox, null).webkitFlexWrap is "nowrap" 95 95 PASS flexbox.style.webkitFlexWrap is "wrap" 96 96 PASS window.getComputedStyle(flexbox, null).webkitFlexWrap is "wrap" … … 98 98 PASS window.getComputedStyle(flexbox, null).webkitFlexWrap is "wrap-reverse" 99 99 PASS flexbox.style.webkitFlexFlow is "" 100 PASS window.getComputedStyle(flexbox, null).webkitFlexFlow is "row no ne"101 PASS flexbox.style.webkitFlexFlow is "" 102 PASS flexbox.style.webkitFlexFlow is "" 103 PASS window.getComputedStyle(flexbox, null).webkitFlexFlow is "row no ne"104 PASS flexbox.style.webkitFlexFlow is "" 105 PASS window.getComputedStyle(flexbox, null).webkitFlexFlow is "row no ne"106 PASS flexbox.style.webkitFlexFlow is "no ne"107 PASS window.getComputedStyle(flexbox, null).webkitFlexFlow is "row no ne"108 PASS flexbox.style.webkitFlexFlow is "no ne"109 PASS window.getComputedStyle(flexbox, null).webkitFlexFlow is "row no ne"100 PASS window.getComputedStyle(flexbox, null).webkitFlexFlow is "row nowrap" 101 PASS flexbox.style.webkitFlexFlow is "" 102 PASS flexbox.style.webkitFlexFlow is "" 103 PASS window.getComputedStyle(flexbox, null).webkitFlexFlow is "row nowrap" 104 PASS flexbox.style.webkitFlexFlow is "" 105 PASS window.getComputedStyle(flexbox, null).webkitFlexFlow is "row nowrap" 106 PASS flexbox.style.webkitFlexFlow is "nowrap" 107 PASS window.getComputedStyle(flexbox, null).webkitFlexFlow is "row nowrap" 108 PASS flexbox.style.webkitFlexFlow is "nowrap" 109 PASS window.getComputedStyle(flexbox, null).webkitFlexFlow is "row nowrap" 110 110 PASS flexbox.style.webkitFlexFlow is "wrap" 111 111 PASS window.getComputedStyle(flexbox, null).webkitFlexFlow is "row wrap" … … 117 117 PASS window.getComputedStyle(flexbox, null).webkitFlexFlow is "row wrap-reverse" 118 118 PASS flexbox.style.webkitFlexFlow is "row" 119 PASS window.getComputedStyle(flexbox, null).webkitFlexFlow is "row no ne"119 PASS window.getComputedStyle(flexbox, null).webkitFlexFlow is "row nowrap" 120 120 PASS flexbox.style.webkitFlexFlow is "row" 121 PASS window.getComputedStyle(flexbox, null).webkitFlexFlow is "row no ne"122 PASS flexbox.style.webkitFlexFlow is "row no ne"123 PASS window.getComputedStyle(flexbox, null).webkitFlexFlow is "row no ne"124 PASS flexbox.style.webkitFlexFlow is "row no ne"125 PASS window.getComputedStyle(flexbox, null).webkitFlexFlow is "row no ne"121 PASS window.getComputedStyle(flexbox, null).webkitFlexFlow is "row nowrap" 122 PASS flexbox.style.webkitFlexFlow is "row nowrap" 123 PASS window.getComputedStyle(flexbox, null).webkitFlexFlow is "row nowrap" 124 PASS flexbox.style.webkitFlexFlow is "row nowrap" 125 PASS window.getComputedStyle(flexbox, null).webkitFlexFlow is "row nowrap" 126 126 PASS flexbox.style.webkitFlexFlow is "row wrap" 127 127 PASS window.getComputedStyle(flexbox, null).webkitFlexFlow is "row wrap" … … 133 133 PASS window.getComputedStyle(flexbox, null).webkitFlexFlow is "row wrap-reverse" 134 134 PASS flexbox.style.webkitFlexFlow is "row-reverse" 135 PASS window.getComputedStyle(flexbox, null).webkitFlexFlow is "row-reverse no ne"135 PASS window.getComputedStyle(flexbox, null).webkitFlexFlow is "row-reverse nowrap" 136 136 PASS flexbox.style.webkitFlexFlow is "row-reverse" 137 PASS window.getComputedStyle(flexbox, null).webkitFlexFlow is "row-reverse no ne"138 PASS flexbox.style.webkitFlexFlow is "row-reverse no ne"139 PASS window.getComputedStyle(flexbox, null).webkitFlexFlow is "row-reverse no ne"140 PASS flexbox.style.webkitFlexFlow is "row-reverse no ne"141 PASS window.getComputedStyle(flexbox, null).webkitFlexFlow is "row-reverse no ne"137 PASS window.getComputedStyle(flexbox, null).webkitFlexFlow is "row-reverse nowrap" 138 PASS flexbox.style.webkitFlexFlow is "row-reverse nowrap" 139 PASS window.getComputedStyle(flexbox, null).webkitFlexFlow is "row-reverse nowrap" 140 PASS flexbox.style.webkitFlexFlow is "row-reverse nowrap" 141 PASS window.getComputedStyle(flexbox, null).webkitFlexFlow is "row-reverse nowrap" 142 142 PASS flexbox.style.webkitFlexFlow is "row-reverse wrap" 143 143 PASS window.getComputedStyle(flexbox, null).webkitFlexFlow is "row-reverse wrap" … … 149 149 PASS window.getComputedStyle(flexbox, null).webkitFlexFlow is "row-reverse wrap-reverse" 150 150 PASS flexbox.style.webkitFlexFlow is "column" 151 PASS window.getComputedStyle(flexbox, null).webkitFlexFlow is "column no ne"151 PASS window.getComputedStyle(flexbox, null).webkitFlexFlow is "column nowrap" 152 152 PASS flexbox.style.webkitFlexFlow is "column" 153 PASS window.getComputedStyle(flexbox, null).webkitFlexFlow is "column no ne"154 PASS flexbox.style.webkitFlexFlow is "column no ne"155 PASS window.getComputedStyle(flexbox, null).webkitFlexFlow is "column no ne"156 PASS flexbox.style.webkitFlexFlow is "column no ne"157 PASS window.getComputedStyle(flexbox, null).webkitFlexFlow is "column no ne"153 PASS window.getComputedStyle(flexbox, null).webkitFlexFlow is "column nowrap" 154 PASS flexbox.style.webkitFlexFlow is "column nowrap" 155 PASS window.getComputedStyle(flexbox, null).webkitFlexFlow is "column nowrap" 156 PASS flexbox.style.webkitFlexFlow is "column nowrap" 157 PASS window.getComputedStyle(flexbox, null).webkitFlexFlow is "column nowrap" 158 158 PASS flexbox.style.webkitFlexFlow is "column wrap" 159 159 PASS window.getComputedStyle(flexbox, null).webkitFlexFlow is "column wrap" … … 165 165 PASS window.getComputedStyle(flexbox, null).webkitFlexFlow is "column wrap-reverse" 166 166 PASS flexbox.style.webkitFlexFlow is "column-reverse" 167 PASS window.getComputedStyle(flexbox, null).webkitFlexFlow is "column-reverse no ne"167 PASS window.getComputedStyle(flexbox, null).webkitFlexFlow is "column-reverse nowrap" 168 168 PASS flexbox.style.webkitFlexFlow is "column-reverse" 169 PASS window.getComputedStyle(flexbox, null).webkitFlexFlow is "column-reverse no ne"170 PASS flexbox.style.webkitFlexFlow is "column-reverse no ne"171 PASS window.getComputedStyle(flexbox, null).webkitFlexFlow is "column-reverse no ne"172 PASS flexbox.style.webkitFlexFlow is "column-reverse no ne"173 PASS window.getComputedStyle(flexbox, null).webkitFlexFlow is "column-reverse no ne"169 PASS window.getComputedStyle(flexbox, null).webkitFlexFlow is "column-reverse nowrap" 170 PASS flexbox.style.webkitFlexFlow is "column-reverse nowrap" 171 PASS window.getComputedStyle(flexbox, null).webkitFlexFlow is "column-reverse nowrap" 172 PASS flexbox.style.webkitFlexFlow is "column-reverse nowrap" 173 PASS window.getComputedStyle(flexbox, null).webkitFlexFlow is "column-reverse nowrap" 174 174 PASS flexbox.style.webkitFlexFlow is "column-reverse wrap" 175 175 PASS window.getComputedStyle(flexbox, null).webkitFlexFlow is "column-reverse wrap" … … 184 184 PASS flexbox.style.webkitFlexFlow is "" 185 185 PASS flexbox.style.webkitFlexFlow is "" 186 PASS window.getComputedStyle(flexbox, null).webkitFlexFlow is "row no ne"186 PASS window.getComputedStyle(flexbox, null).webkitFlexFlow is "row nowrap" 187 187 PASS flexbox.style.webkitFlexFlow is "column" 188 PASS window.getComputedStyle(flexbox, null).webkitFlexFlow is "column no ne"188 PASS window.getComputedStyle(flexbox, null).webkitFlexFlow is "column nowrap" 189 189 PASS flexbox.style.webkitFlexFlow is "column wrap" 190 190 PASS window.getComputedStyle(flexbox, null).webkitFlexFlow is "column wrap" -
trunk/LayoutTests/css3/flexbox/css-properties.html
r124276 r132136 197 197 198 198 shouldBeEqualToString('flexbox.style.webkitFlexWrap', ''); 199 // The initial value is 'no ne'.200 shouldBeEqualToString('window.getComputedStyle(flexbox, null).webkitFlexWrap', 'no ne');199 // The initial value is 'nowrap'. 200 shouldBeEqualToString('window.getComputedStyle(flexbox, null).webkitFlexWrap', 'nowrap'); 201 201 202 202 flexbox.style.webkitFlexWrap = 'foo'; 203 203 shouldBeEqualToString('flexbox.style.webkitFlexWrap', ''); 204 204 205 flexbox.style.webkitFlexWrap = 'no ne';206 shouldBeEqualToString('flexbox.style.webkitFlexWrap', 'no ne');207 shouldBeEqualToString('window.getComputedStyle(flexbox, null).webkitFlexWrap', 'no ne');205 flexbox.style.webkitFlexWrap = 'nowrap'; 206 shouldBeEqualToString('flexbox.style.webkitFlexWrap', 'nowrap'); 207 shouldBeEqualToString('window.getComputedStyle(flexbox, null).webkitFlexWrap', 'nowrap'); 208 208 209 209 flexbox.style.webkitFlexWrap = 'wrap'; … … 217 217 flexbox.style.webkitFlexFlow = ''; 218 218 shouldBeEqualToString('flexbox.style.webkitFlexFlow', ''); 219 shouldBeEqualToString('window.getComputedStyle(flexbox, null).webkitFlexFlow', 'row no ne');219 shouldBeEqualToString('window.getComputedStyle(flexbox, null).webkitFlexFlow', 'row nowrap'); 220 220 221 221 flexbox.style.webkitFlexFlow = 'foo'; … … 230 230 231 231 var directions = ['', 'row', 'row-reverse', 'column', 'column-reverse']; 232 var wraps = ['', 'no ne', 'wrap', 'wrap-reverse'];232 var wraps = ['', 'nowrap', 'wrap', 'wrap-reverse']; 233 233 directions.forEach(function(direction) { 234 234 wraps.forEach(function(wrap) { 235 var expectedComputed = (direction || 'row') + ' ' + (wrap || 'no ne');235 var expectedComputed = (direction || 'row') + ' ' + (wrap || 'nowrap'); 236 236 var expected = direction + ' ' + wrap; 237 237 testFlexFlowValue(direction + ' ' + wrap, expected, expectedComputed); … … 249 249 flexbox.style.webkitFlexFlow = ''; 250 250 shouldBeEqualToString('flexbox.style.webkitFlexFlow', ''); 251 shouldBeEqualToString('window.getComputedStyle(flexbox, null).webkitFlexFlow', 'row no ne');251 shouldBeEqualToString('window.getComputedStyle(flexbox, null).webkitFlexFlow', 'row nowrap'); 252 252 flexbox.style.webkitFlexDirection = 'column'; 253 253 flexbox.style.webkitFlexWrap = 'initial'; 254 254 shouldBeEqualToString('flexbox.style.webkitFlexFlow', 'column'); 255 shouldBeEqualToString('window.getComputedStyle(flexbox, null).webkitFlexFlow', 'column no ne');255 shouldBeEqualToString('window.getComputedStyle(flexbox, null).webkitFlexFlow', 'column nowrap'); 256 256 flexbox.style.webkitFlexWrap = 'wrap'; 257 257 shouldBeEqualToString('flexbox.style.webkitFlexFlow', 'column wrap'); -
trunk/LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt
r125716 r132136 148 148 -webkit-align-self: stretch; 149 149 -webkit-flex-direction: row; 150 -webkit-flex-wrap: no ne;150 -webkit-flex-wrap: nowrap; 151 151 -webkit-justify-content: flex-start; 152 152 -webkit-font-kerning: auto; -
trunk/LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt
r125716 r132136 147 147 -webkit-align-self: stretch 148 148 -webkit-flex-direction: row 149 -webkit-flex-wrap: no ne149 -webkit-flex-wrap: nowrap 150 150 -webkit-justify-content: flex-start 151 151 -webkit-font-kerning: auto -
trunk/LayoutTests/svg/css/getComputedStyle-basic-expected.txt
r125716 r132136 293 293 rect: style.getPropertyValue(-webkit-flex-direction) : row 294 294 rect: style.getPropertyCSSValue(-webkit-flex-direction) : [object CSSPrimitiveValue] 295 rect: style.getPropertyValue(-webkit-flex-wrap) : no ne295 rect: style.getPropertyValue(-webkit-flex-wrap) : nowrap 296 296 rect: style.getPropertyCSSValue(-webkit-flex-wrap) : [object CSSPrimitiveValue] 297 297 rect: style.getPropertyValue(-webkit-justify-content) : flex-start … … 795 795 g: style.getPropertyValue(-webkit-flex-direction) : row 796 796 g: style.getPropertyCSSValue(-webkit-flex-direction) : [object CSSPrimitiveValue] 797 g: style.getPropertyValue(-webkit-flex-wrap) : no ne797 g: style.getPropertyValue(-webkit-flex-wrap) : nowrap 798 798 g: style.getPropertyCSSValue(-webkit-flex-wrap) : [object CSSPrimitiveValue] 799 799 g: style.getPropertyValue(-webkit-justify-content) : flex-start -
trunk/Source/WebCore/ChangeLog
r132130 r132136 1 2012-10-22 Tony Chang <tony@chromium.org> 2 3 WebKit does not support 'flex-wrap: nowrap' 4 https://bugs.webkit.org/show_bug.cgi?id=99924 5 6 Reviewed by Ojan Vafai. 7 8 The spec changed back from using none to nowrap for the single-line 9 flexbox case. 10 http://dev.w3.org/csswg/css3-flexbox/#flex-wrap-property 11 12 No new tests, covered by css3/flexbox/css-properties.html and others. 13 14 * css/CSSParser.cpp: 15 (WebCore::isValidKeywordPropertyAndValue): 16 * css/CSSPrimitiveValueMappings.h: 17 (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): 18 (WebCore::CSSPrimitiveValue::operator EFlexWrap): 19 * css/CSSValueKeywords.in: 20 * rendering/RenderBox.cpp: 21 (WebCore::isStretchingColumnFlexItem): 22 (WebCore::RenderBox::sizesLogicalWidthToFitContent): 23 * rendering/RenderFlexibleBox.cpp: 24 (WebCore::RenderFlexibleBox::isMultiline): 25 * rendering/style/RenderStyle.h: 26 * rendering/style/RenderStyleConstants.h: 27 1 28 2012-10-22 Mike West <mkwst@chromium.org> 2 29 -
trunk/Source/WebCore/css/CSSParser.cpp
r131925 r132136 807 807 break; 808 808 case CSSPropertyWebkitFlexWrap: 809 if (valueID == CSSValueNo ne|| valueID == CSSValueWrap || valueID == CSSValueWrapReverse)809 if (valueID == CSSValueNowrap || valueID == CSSValueWrap || valueID == CSSValueWrapReverse) 810 810 return true; 811 811 break; -
trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h
r131925 r132136 1381 1381 m_primitiveUnitType = CSS_IDENT; 1382 1382 switch (e) { 1383 case Flex WrapNone:1384 m_value.ident = CSSValueNo ne;1383 case FlexNoWrap: 1384 m_value.ident = CSSValueNowrap; 1385 1385 break; 1386 1386 case FlexWrap: … … 1396 1396 { 1397 1397 switch (m_value.ident) { 1398 case CSSValueNo ne:1399 return Flex WrapNone;1398 case CSSValueNowrap: 1399 return FlexNoWrap; 1400 1400 case CSSValueWrap: 1401 1401 return FlexWrap; … … 1405 1405 1406 1406 ASSERT_NOT_REACHED(); 1407 return Flex WrapNone;1407 return FlexNoWrap; 1408 1408 } 1409 1409 -
trunk/Source/WebCore/css/CSSValueKeywords.in
r131925 r132136 518 518 column 519 519 column-reverse 520 // no ne520 // nowrap 521 521 // wrap 522 522 wrap-reverse -
trunk/Source/WebCore/rendering/RenderBox.cpp
r132112 r132136 1787 1787 1788 1788 // We don't stretch multiline flexboxes because they need to apply line spacing (align-content) first. 1789 if (parent->isFlexibleBox() && parent->style()->flexWrap() == Flex WrapNone&& parent->style()->isColumnFlexDirection() && flexItemHasStretchAlignment(flexitem))1789 if (parent->isFlexibleBox() && parent->style()->flexWrap() == FlexNoWrap && parent->style()->isColumnFlexDirection() && flexItemHasStretchAlignment(flexitem)) 1790 1790 return true; 1791 1791 return false; … … 1821 1821 if (parent()->isFlexibleBox()) { 1822 1822 // For multiline columns, we need to apply align-content first, so we can't stretch now. 1823 if (!parent()->style()->isColumnFlexDirection() || parent()->style()->flexWrap() != Flex WrapNone)1823 if (!parent()->style()->isColumnFlexDirection() || parent()->style()->flexWrap() != FlexNoWrap) 1824 1824 return true; 1825 1825 if (!flexItemHasStretchAlignment(this)) -
trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp
r132112 r132136 426 426 bool RenderFlexibleBox::isMultiline() const 427 427 { 428 return style()->flexWrap() != Flex WrapNone;428 return style()->flexWrap() != FlexNoWrap; 429 429 } 430 430 -
trunk/Source/WebCore/rendering/style/RenderStyle.h
r132076 r132136 1635 1635 static EAlignItems initialAlignSelf() { return AlignAuto; } 1636 1636 static EFlexDirection initialFlexDirection() { return FlowRow; } 1637 static EFlexWrap initialFlexWrap() { return Flex WrapNone; }1637 static EFlexWrap initialFlexWrap() { return FlexNoWrap; } 1638 1638 static EJustifyContent initialJustifyContent() { return JustifyFlexStart; } 1639 1639 static int initialMarqueeLoopCount() { return -1; } -
trunk/Source/WebCore/rendering/style/RenderStyleConstants.h
r132076 r132136 172 172 enum EAlignItems { AlignAuto, AlignFlexStart, AlignFlexEnd, AlignCenter, AlignStretch, AlignBaseline }; 173 173 enum EFlexDirection { FlowRow, FlowRowReverse, FlowColumn, FlowColumnReverse }; 174 enum EFlexWrap { Flex WrapNone, FlexWrap, FlexWrapReverse };174 enum EFlexWrap { FlexNoWrap, FlexWrap, FlexWrapReverse }; 175 175 enum EJustifyContent { JustifyFlexStart, JustifyFlexEnd, JustifyCenter, JustifySpaceBetween, JustifySpaceAround }; 176 176
Note: See TracChangeset
for help on using the changeset viewer.