Changeset 132240 in webkit

Timestamp:

Oct 23, 2012 10:12:47 AM (11 years ago)

Author:

rwlbuis@webkit.org

Message:

[BlackBerry] Make selection in search input box not overlap cancel button
​https://bugs.webkit.org/show_bug.cgi?id=100130

Reviewed by Antonio Gomes.

This ensures that even when selection is active, the user can still press 'cancel'.

• WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::boundingBoxForInputField):

Location:

trunk/Source/WebKit/blackberry

Files:

• ChangeLog (modified) (1 diff)
• WebKitSupport/InputHandler.cpp (modified) (1 diff)

trunk/Source/WebKit/blackberry/ChangeLog

@@ +1 @@
+2012-10-23  Rob Buis  <rbuis@rim.com>
+
+        [BlackBerry] Make selection in search input box not overlap cancel button
+        https://bugs.webkit.org/show_bug.cgi?id=100130
+
+        Reviewed by Antonio Gomes.
+
+        This ensures that even when selection is active, the user can still press 'cancel'.
+
+        * WebKitSupport/InputHandler.cpp:
+        (BlackBerry::WebKit::InputHandler::boundingBoxForInputField):
+
 2012-10-23  Arvid Nilsson  <anilsson@rim.com>
 

trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp

@@ -1042 +1042 @@
         return WebCore::IntRect();
 
+    // type="search" can have a 'X', so take the inner block bounding box to not include it.
+    if (HTMLInputElement* element = m_currentFocusElement->toInputElement())
+        if (element->isSearchField())
+            return element->innerBlockElement()->renderer()->absoluteBoundingBoxRect();
+
     return m_currentFocusElement->renderer()->absoluteBoundingBoxRect();
 }