Changeset 132262 in webkit

Timestamp:

Oct 23, 2012 2:09:54 PM (12 years ago)

Author:

tony@chromium.org

Message:

[chromium] Chromium window build system does not rebuild correctly when enabling/disabling a feature
​https://bugs.webkit.org/show_bug.cgi?id=38926

Reviewed by Eric Seidel.

Remove hack for clobbering build when features.gypi changes. Now that
Chromium requires VS2010 or newer, this bug has gone away.

• Scripts/update-webkit:

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/update-webkit (modified) (3 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2012-10-23  Tony Chang  <tony@chromium.org>
+
+        [chromium] Chromium window build system does not rebuild correctly when enabling/disabling a feature
+        https://bugs.webkit.org/show_bug.cgi?id=38926
+
+        Reviewed by Eric Seidel.
+
+        Remove hack for clobbering build when features.gypi changes. Now that
+        Chromium requires VS2010 or newer, this bug has gone away.
+
+        * Scripts/update-webkit:
+
 2012-10-23  Jochen Eisinger  <jochen@chromium.org>
 

trunk/Tools/Scripts/update-webkit

@@ -35 +35 @@
 use lib $FindBin::Bin;
 use File::Basename;
-use File::Path;
 use File::Spec;
 use Getopt::Long;
@@ -88 +87 @@
 }
 
-my $startTime = time();
-
 my @svnOptions = ();
 push @svnOptions, '-q' if $quiet;
@@ -106 +103 @@
     runGitUpdate() if isGitDirectory(".");
 } elsif (isChromium()) {
-    # Workaround for https://bugs.webkit.org/show_bug.cgi?id=38926
-    # We should remove the following "if" block when we find a right fix.
-    if ((isCygwin() || isWindows()) && (stat("WebKit/chromium/features.gypi"))[9] >= $startTime) {
-        print "features.gypi has been updated. Cleaning the build directories.\n";
-        rmtree(["WebKit/chromium/Debug", "WebKit/chromium/Release"]);
-    }
-
     my @chromiumUpdateArgs = ("perl", "Tools/Scripts/update-webkit-chromium");
     push @chromiumUpdateArgs, "--chromium-android" if isChromiumAndroid();