Changeset 132328 in webkit


Ignore:
Timestamp:
Oct 24, 2012 1:12:50 AM (12 years ago)
Author:
mario@webkit.org
Message:

[WK2] [GTK] TestWebKitAccessibility is not being run
​https://bugs.webkit.org/show_bug.cgi?id=100102

Reviewed by Carlos Garcia Campos.

.:

Moved check for at-spi2 after the definition of enable_webkit2,
since it's only needed for WebKit2GTK API tests.

  • configure.ac: Moved the check for at-spi2 down in the file.

Tools:

Removed wrong early return in _start_accessibility_daemons().

  • Scripts/run-gtk-tests:

(TestRunner._lookup_atspi2_binary): Removed wrong line.

Location:
trunk
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/ChangeLog

    r132289 r132328  
     12012-10-24  Mario Sanchez Prada  <mario@webkit.org>
     2
     3        [WK2] [GTK] TestWebKitAccessibility is not being run
     4        https://bugs.webkit.org/show_bug.cgi?id=100102
     5
     6        Reviewed by Carlos Garcia Campos.
     7
     8        Moved check for at-spi2 after the definition of enable_webkit2,
     9        since it's only needed for WebKit2GTK API tests.
     10
     11        * configure.ac: Moved the check for at-spi2 down in the file.
     12
    1132012-10-23  Martin Robinson  <mrobinson@igalia.com>
    214

  • trunk/Tools/ChangeLog

    r132320 r132328  
     12012-10-24  Mario Sanchez Prada  <mario@webkit.org>
     2
     3        [WK2] [GTK] TestWebKitAccessibility is not being run
     4        https://bugs.webkit.org/show_bug.cgi?id=100102
     5
     6        Reviewed by Carlos Garcia Campos.
     7
     8        Removed wrong early return in _start_accessibility_daemons().
     9
     10        * Scripts/run-gtk-tests:
     11        (TestRunner._lookup_atspi2_binary): Removed wrong line.
     12
    1132012-10-24  Noel Gordon  <noel.gordon@gmail.com>
    214

  • trunk/Tools/Scripts/run-gtk-tests

    r131876 r132328  
    120120
    121121    def _start_accessibility_daemons(self):
    122         return False
    123122        spi_bus_launcher_path = self._lookup_atspi2_binary('at-spi-bus-launcher')
    124123        spi_registryd_path = self._lookup_atspi2_binary('at-spi2-registryd')

  • trunk/configure.ac

    r132289 r132328  
    10451045AC_SUBST([OPENGL_LIBS])
    10461046
    1047 # check if atspi2 is available (only needed for Webkit2 unit tests)
    1048 if test "$enable_webkit2" = "yes"; then
    1049    PKG_CHECK_MODULES([ATSPI2],
    1050                      [atspi-2 >= $ATSPI2_REQUIRED_VERSION],
    1051                      [have_atspi2=yes], [have_atspi2=no])
    1052 
    1053    AC_SUBST([ATSPI2_CFLAGS])
    1054    AC_SUBST([ATSPI2_LIBS])
    1055 fi
    1056 
    10571047if test "$enable_gamepad" = "yes"; then
    10581048   PKG_CHECK_MODULES([GAMEPAD], [gio-unix-2.0 gudev-1.0])
    … …  
    11141104
    11151105GTK_DOC_CHECK([1.10])
     1106
     1107# We need atspi2 for Webkit2 unit tests
     1108if test "$enable_webkit2" = "yes"; then
     1109   PKG_CHECK_MODULES([ATSPI2],
     1110                     [atspi-2 >= $ATSPI2_REQUIRED_VERSION],
     1111                     [have_atspi2=yes], [have_atspi2=no])
     1112
     1113   AC_SUBST([ATSPI2_CFLAGS])
     1114   AC_SUBST([ATSPI2_LIBS])
     1115fi
    11161116
    11171117# OS conditionals
Note: See TracChangeset for help on using the changeset viewer.