Changeset 132422 in webkit

Timestamp:

Oct 24, 2012 4:40:28 PM (11 years ago)

Author:

timothy_horton@apple.com

Message:

Update main frame scroll position immediately for programmatic scrolls
​https://bugs.webkit.org/show_bug.cgi?id=98074

Reviewed by Simon Fraser.

Immediately update the main frame scroll position after a programmatic scroll,
so that performing a scrollBy or scrollTo will be instantly reflected in
all of the scroll offset accessors.

No new tests; this will be tested by many scrolling tests once WebKitTestRunner
can use threaded scrolling.

• page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::requestScrollPositionUpdate):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/scrolling/mac/ScrollingCoordinatorMac.mm (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-10-24  Tim Horton  <timothy_horton@apple.com>
+
+        Update main frame scroll position immediately for programmatic scrolls
+        https://bugs.webkit.org/show_bug.cgi?id=98074
+
+        Reviewed by Simon Fraser.
+
+        Immediately update the main frame scroll position after a programmatic scroll,
+        so that performing a scrollBy or scrollTo will be instantly reflected in
+        all of the scroll offset accessors.
+
+        No new tests; this will be tested by many scrolling tests once WebKitTestRunner
+        can use threaded scrolling.
+
+        * page/scrolling/ScrollingCoordinator.cpp:
+        (WebCore::ScrollingCoordinator::requestScrollPositionUpdate):
+
 2012-10-24  Mihai Parparita  <mihaip@chromium.org>
 

trunk/Source/WebCore/page/scrolling/mac/ScrollingCoordinatorMac.mm

@@ -184 +184 @@
         return false;
 
-    if (frameView->frame()->document()->inPageCache()) {
-        // If this frame view's document is being put into the page cache, we don't want to update our
-        // main frame scroll position. Just let the FrameView think that we did.
+    if (frameView->inProgrammaticScroll() || frameView->frame()->document()->inPageCache())
         updateMainFrameScrollPosition(scrollPosition, frameView->inProgrammaticScroll());
+
+    // If this frame view's document is being put into the page cache, we don't want to update our
+    // main frame scroll position. Just let the FrameView think that we did.
+    if (frameView->frame()->document()->inPageCache())
         return true;
-    }
 
     ScrollingStateScrollingNode* stateNode = stateNodeForID(frameView->scrollLayerID());