Changeset 132493 in webkit

Timestamp:

Oct 25, 2012 9:28:48 AM (12 years ago)

Author:

dominik.rottsches@intel.com

Message:

Init timeout flag in ResourceErrorCF
​https://bugs.webkit.org/show_bug.cgi?id=100349

Reviewed by Alexey Proskuryakov.

Initialize the timeout property to true if the network error was a timeout error.
This is a speculative fix for the XHR timeout test cases failing on Apple Win -
I can't verify this on a local machine.

No new tests, covered by
LayoutTests/http/tests/xmlhttprequest/timeout/*

• platform/network/cf/ResourceErrorCF.cpp:

(WebCore::ResourceError::ResourceError): Init m_timeout from error code.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/network/cf/ResourceErrorCF.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-10-25  Dominik Röttsches  <dominik.rottsches@intel.com>
+
+        Init timeout flag in ResourceErrorCF
+        https://bugs.webkit.org/show_bug.cgi?id=100349
+
+        Reviewed by Alexey Proskuryakov.
+
+        Initialize the timeout property to true if the network error was a timeout error.
+        This is a speculative fix for the XHR timeout test cases failing on Apple Win -
+        I can't verify this on a local machine.
+
+        No new tests, covered by
+        LayoutTests/http/tests/xmlhttprequest/timeout/*
+
+        * platform/network/cf/ResourceErrorCF.cpp:
+        (WebCore::ResourceError::ResourceError): Init m_timeout from error code.
+
 2012-10-25  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 

trunk/Source/WebCore/platform/network/cf/ResourceErrorCF.cpp

@@ -46 +46 @@
 {
     m_isNull = !cfError;
+    if (!m_isNull)
+        m_isTimeout = CFErrorGetCode(m_platformError.get()) == kCFURLErrorTimedOut;
 }