Changeset 132529 in webkit


Ignore:
Timestamp:
Oct 25, 2012 1:50:39 PM (11 years ago)
Author:
commit-queue@webkit.org
Message:

Unreviewed, rolling out r132269.
​http://trac.webkit.org/changeset/132269
​https://bugs.webkit.org/show_bug.cgi?id=100412

"Speculative rollout of r132269 in hopes of fixing a
mysterious recalcStyle crasher" (Requested by eseidel on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-10-25

Source/WebCore:

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::updateFirstLetter):

  • rendering/RenderListBox.h:
  • rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::updateBeforeAfterContent):

LayoutTests:

  • fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.html: Removed.
  • fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.txt: Added.
  • fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements.html:
  • fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.html: Removed.
  • fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.txt: Added.
  • fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements.html:
  • fast/forms/pseudo-elements-expected.html: Removed.
  • fast/forms/pseudo-elements.html: Removed.
  • fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.html: Removed.
  • fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.txt: Added.
  • fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements.html:
  • fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.html: Removed.
  • fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.txt: Added.
  • fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements.html:
  • platform/chromium-linux/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png: Added.
  • platform/chromium-linux/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png: Added.
  • platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png: Added.
  • platform/chromium-linux/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png: Added.
  • platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png: Added.
  • platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png: Added.
  • platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png: Added.
  • platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png: Added.
  • platform/chromium-win/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png: Added.
  • platform/chromium-win/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png: Added.
  • platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png: Added.
  • platform/chromium-win/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png: Added.
Location:
trunk
Files:
20 added
6 deleted
9 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r132528 r132529  
     12012-10-25  Sheriff Bot  <webkit.review.bot@gmail.com>
     2
     3        Unreviewed, rolling out r132269.
     4        http://trac.webkit.org/changeset/132269
     5        https://bugs.webkit.org/show_bug.cgi?id=100412
     6
     7        "Speculative rollout of r132269 in hopes of fixing a
     8        mysterious recalcStyle crasher" (Requested by eseidel on
     9        #webkit).
     10
     11        * fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.html: Removed.
     12        * fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.txt: Added.
     13        * fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements.html:
     14        * fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.html: Removed.
     15        * fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.txt: Added.
     16        * fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements.html:
     17        * fast/forms/pseudo-elements-expected.html: Removed.
     18        * fast/forms/pseudo-elements.html: Removed.
     19        * fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.html: Removed.
     20        * fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.txt: Added.
     21        * fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements.html:
     22        * fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.html: Removed.
     23        * fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.txt: Added.
     24        * fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements.html:
     25        * platform/chromium-linux/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png: Added.
     26        * platform/chromium-linux/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png: Added.
     27        * platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png: Added.
     28        * platform/chromium-linux/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png: Added.
     29        * platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png: Added.
     30        * platform/chromium-mac-snowleopard/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png: Added.
     31        * platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png: Added.
     32        * platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png: Added.
     33        * platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png: Added.
     34        * platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png: Added.
     35        * platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png: Added.
     36        * platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png: Added.
     37        * platform/chromium-win/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png: Added.
     38        * platform/chromium-win/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png: Added.
     39        * platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png: Added.
     40        * platform/chromium-win/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png: Added.
     41
    1422012-10-25  Stephen White  <senorblanco@chromium.org>
    243

  • trunk/LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements.html

    r132269 r132529  
    1 <!DOCTYPE html>
    2 
    3 <style>
     1<html>
     2<head>
     3<style type="text/css">
    44.after:after { content: "[after]"; }
    55.before:before { content: "[before]"; }
    66.first-letter:first-letter { color: green; font-size: 200%; }
    77</style>
    8 
    9 <input type="date" value="1234-05-07" class="after"><br>
    10 <input type="date" value="1234-05-07" class="before"><br>
    11 <input type="date" value="1234-05-07" class="first-letter">
     8</head>
     9<body>
     10<ul>
     11    <li><input type="date" value="1234-05-07" class="after"></li>
     12    <li><input type="date" value="1234-05-07" class="before"></li>
     13    <li><input type="date" value="1234-05-07" class="first-letter"></li>
     14</ul>
     15<script>
     16if (window.testRunner)
     17    testRunner.dumpAsText(true);
     18</script>
     19</body>
     20</html>

  • trunk/LayoutTests/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements.html

    r132269 r132529  
    1 <!DOCTYPE html>
    2 
    3 <style>
     1<html>
     2<head>
     3<style type="text/css">
    44.after:after { content: "[after]"; }
    55.before:before { content: "[before]"; }
    66.first-letter:first-letter { color: green; font-size: 200%; }
    77</style>
    8 
    9 <input type="month" value="1982-11" class="after"><br>
    10 <input type="month" value="1982-11" class="before"><br>
    11 <input type="month" value="1982-11" class="first-letter">
     8</head>
     9<body>
     10<ul>
     11    <li><input type="month" value="1982-11" class="after"></li>
     12    <li><input type="month" value="1982-11" class="before"></li>
     13    <li><input type="month" value="1982-11" class="first-letter"></li>
     14</ul>
     15</body>
     16<script>
     17if (window.testRunner)
     18    testRunner.dumpAsText(true);
     19</script>
     20</html>

  • trunk/LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements.html

    r132269 r132529  
    1 <!DOCTYPE html>
    2 
    3 <style>
     1<html>
     2<head>
     3<style type="text/css">
    44.after:after { content: "[after]"; }
    55.before:before { content: "[before]"; }
    66.first-letter:first-letter { color: green; font-size: 200%; }
    77</style>
    8 
    9 <input type="time" value="12:34" class="after"><br>
    10 <input type="time" value="12:34" class="before"><br>
    11 <input type="time" value="12:34" class="first-letter">
     8</head>
     9<body>
     10<ul>
     11    <li><input type="time" value="12:34" class="after"></li>
     12    <li><input type="time" value="12:34" class="before"></li>
     13    <li><input type="time" value="12:34" class="first-letter"></li>
     14</ul>
     15</body>
     16<script>
     17if (window.testRunner) {
     18    testRunner.dumpAsText(true);
     19}
     20</script>
     21</html>

  • trunk/LayoutTests/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements.html

    r132269 r132529  
    1 <!DOCTYPE html>
    2 
    3 <style>
     1<html>
     2<head>
     3<style type="text/css">
    44.after:after { content: "[after]"; }
    55.before:before { content: "[before]"; }
    66.first-letter:first-letter { color: green; font-size: 200%; }
    77</style>
    8 
    9 <input type="week" value="1982-W25" class="after"><br>
    10 <input type="week" value="1982-W25" class="before"><br>
    11 <input type="week" value="1982-W25" class="first-letter">
     8</head>
     9<body>
     10<ul>
     11    <li><input type="week" value="1982-W25" class="after"></li>
     12    <li><input type="week" value="1982-W25" class="before"></li>
     13    <li><input type="week" value="1982-W25" class="first-letter"></li>
     14</ul>
     15</body>
     16<script>
     17if (window.testRunner)
     18    testRunner.dumpAsText(true);
     19</script>
     20</html>

  • trunk/Source/WebCore/ChangeLog

    r132528 r132529  
     12012-10-25  Sheriff Bot  <webkit.review.bot@gmail.com>
     2
     3        Unreviewed, rolling out r132269.
     4        http://trac.webkit.org/changeset/132269
     5        https://bugs.webkit.org/show_bug.cgi?id=100412
     6
     7        "Speculative rollout of r132269 in hopes of fixing a
     8        mysterious recalcStyle crasher" (Requested by eseidel on
     9        #webkit).
     10
     11        * rendering/RenderBlock.cpp:
     12        (WebCore::RenderBlock::updateFirstLetter):
     13        * rendering/RenderListBox.h:
     14        * rendering/RenderObjectChildList.cpp:
     15        (WebCore::RenderObjectChildList::updateBeforeAfterContent):
     16
    1172012-10-25  Stephen White  <senorblanco@chromium.org>
    218

  • trunk/Source/WebCore/rendering/RenderBlock.cpp

    r132514 r132529  
    65256525        return;
    65266526
    6527     // Disallow generated content in shadows until the spec says what to do. See: http://webkit.org/b/98836
    6528     if (isShadowHost(firstLetterBlock->node()))
    6529         return;
    6530 
    65316527    // If the child already has style, then it has already been created, so we just want
    65326528    // to update it.

  • trunk/Source/WebCore/rendering/RenderListBox.h

    r132269 r132529  
    6868    virtual bool canBeReplacedWithInlineRunIn() const OVERRIDE;
    6969    virtual bool hasControlClip() const { return true; }
    70     virtual bool canHaveGeneratedChildren() const OVERRIDE { return false; }
    7170    virtual void paintObject(PaintInfo&, const LayoutPoint&);
    7271    virtual LayoutRect controlClipRect(const LayoutPoint&) const;

  • trunk/Source/WebCore/rendering/RenderObjectChildList.cpp

    r132269 r132529  
    3030#include "AXObjectCache.h"
    3131#include "ContentData.h"
    32 #include "Element.h"
    3332#include "RenderBlock.h"
    3433#include "RenderCounter.h"
    … …  
    342341        styledObject = owner;
    343342
    344     // Disallow generated content in shadows until the spec says what to do. See: http://webkit.org/b/98836
    345     if (isShadowHost(styledObject->node()))
    346         return;
    347 
    348343    RenderStyle* pseudoElementStyle = styledObject->getCachedPseudoStyle(type);
    349344    RenderObject* child;
Note: See TracChangeset for help on using the changeset viewer.