Changeset 13256 in webkit

Timestamp:

Mar 10, 2006 5:35:55 PM (18 years ago)

Author:

justing

Message:

Reviewed by darin, harrison

~3x speedup pasting plain text from the console

• dom/dom_position.cpp: (WebCore::Position::next): (WebCore::Position::atEnd):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• dom/dom_position.cpp (modified) (2 diffs)

trunk/WebCore/ChangeLog

@@ +1 @@
+2006-03-10  Justin Garcia  <justin.garcia@apple.com>
+        
+        Reviewed by darin, harrison
+        
+        ~3x speedup pasting plain text from the console
+
+        * dom/dom_position.cpp:
+        (WebCore::Position::next): 
+        (WebCore::Position::atEnd): 
+
 2006-03-10  David Hyatt <hyatt@apple.com>
 

trunk/WebCore/dom/dom_position.cpp

@@ -145 +145 @@
     assert(o >= 0);
 
-    if (o < maxDeepOffset(n)) {
-        NodeImpl *child = n->childNode(o);
-        if (child) {
+    NodeImpl* child = n->childNode(o);
+    if (child || !n->hasChildNodes() && o < maxDeepOffset(n)) {
+        if (child)
             return Position(child, 0);
-        }
+            
         // There are two reasons child might be 0:
         //   1) The node is node like a text node that is not an element, and therefore has no children.
@@ -180 +180 @@
         return true;
     
-    return offset() >= maxDeepOffset(n) && n->parent() == 0;
+    return n->parent() == 0 && offset() >= maxDeepOffset(n);
 }