Changeset 132907 in webkit
- Timestamp:
- Oct 30, 2012 7:11:28 AM (11 years ago)
- Location:
- trunk/Source
- Files:
-
- 5 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r132906 r132907 1 2012-10-30 No'am Rosenthal <noam.rosenthal@nokia.com> 2 3 [Qt] Animations jump when the page is suspended 4 https://bugs.webkit.org/show_bug.cgi?id=100673 5 6 Reviewed by Kenneth Rohde Christiansen. 7 8 GraphicsLayerAnimations::pause() should accept time from start and not an offset. 9 10 We need to support the "freeze" API before this can be reliably tested. 11 See https://bugs.webkit.org/show_bug.cgi?id=100703. 12 13 * platform/graphics/GraphicsLayerAnimation.cpp: 14 (WebCore::GraphicsLayerAnimation::pause): 15 1 16 2012-10-30 Kondapally Kalyan <kalyan.kondapally@intel.com> 2 17 -
trunk/Source/WebCore/platform/graphics/GraphicsLayerAnimation.cpp
r132798 r132907 263 263 } 264 264 265 void GraphicsLayerAnimation::pause(double offset) 266 { 267 // FIXME: should apply offset here. 265 void GraphicsLayerAnimation::pause(double time) 266 { 268 267 setState(PausedState); 269 m_pauseTime = WTF::currentTime() - offset;268 m_pauseTime = time; 270 269 } 271 270 -
trunk/Source/WebKit2/ChangeLog
r132905 r132907 1 2012-10-30 No'am Rosenthal <noam.rosenthal@nokia.com> 2 3 [Qt] Animations jump when the page is suspended 4 https://bugs.webkit.org/show_bug.cgi?id=100673 5 6 Reviewed by Kenneth Rohde Christiansen. 7 8 GraphicsLayerAnimations::pause() should accept time from start and not an offset. 9 10 * WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp: 11 (WebCore::CoordinatedGraphicsLayer::addAnimation): 12 (WebCore::CoordinatedGraphicsLayer::pauseAnimation): 13 (WebCore::CoordinatedGraphicsLayer::animationStartedTimerFired): 14 * WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h: 15 (CoordinatedGraphicsLayer): 16 1 17 2012-10-30 Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> 2 18 -
trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp
r132275 r132907 796 796 } 797 797 798 bool CoordinatedGraphicsLayer::addAnimation(const KeyframeValueList& valueList, const IntSize& boxSize, const Animation* anim, const String& keyframesName, double timeOffset)798 bool CoordinatedGraphicsLayer::addAnimation(const KeyframeValueList& valueList, const IntSize& boxSize, const Animation* anim, const String& keyframesName, double delayAsNegativeTimeOffset) 799 799 { 800 800 ASSERT(!keyframesName.isEmpty()); … … 809 809 listsMatch = validateTransformOperations(valueList, ignoredHasBigRotation) >= 0; 810 810 811 m_animations.add(GraphicsLayerAnimation(keyframesName, valueList, boxSize, anim, WTF::currentTime() - timeOffset, listsMatch)); 811 m_lastAnimationStartTime = WTF::currentTime() - delayAsNegativeTimeOffset; 812 m_animations.add(GraphicsLayerAnimation(keyframesName, valueList, boxSize, anim, m_lastAnimationStartTime, listsMatch)); 812 813 m_animationStartedTimer.startOneShot(0); 813 814 didChangeAnimations(); … … 815 816 } 816 817 817 void CoordinatedGraphicsLayer::pauseAnimation(const String& animationName, double time Offset)818 { 819 m_animations.pause(animationName, time Offset);818 void CoordinatedGraphicsLayer::pauseAnimation(const String& animationName, double time) 819 { 820 m_animations.pause(animationName, time); 820 821 didChangeAnimations(); 821 822 } … … 829 830 void CoordinatedGraphicsLayer::animationStartedTimerFired(Timer<CoordinatedGraphicsLayer>*) 830 831 { 831 client()->notifyAnimationStarted(this, /* DOM time */ WTF::currentTime());832 client()->notifyAnimationStarted(this, m_lastAnimationStartTime); 832 833 } 833 834 } -
trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h
r132275 r132907 221 221 Timer<CoordinatedGraphicsLayer> m_animationStartedTimer; 222 222 GraphicsLayerAnimations m_animations; 223 double m_lastAnimationStartTime; 223 224 }; 224 225
Note: See TracChangeset
for help on using the changeset viewer.