Changeset 133069 in webkit

Timestamp:

Oct 31, 2012 1:35:04 PM (11 years ago)

Author:

fischman@chromium.org

Message:

[chromium] DRT and WTR should clear the cache between tests
​https://bugs.webkit.org/show_bug.cgi?id=93195

Reviewed by Tony Chang.

Tools:

This change makes chromium DRT match the GTK+, Qt, and EFL ports.

• DumpRenderTree/chromium/TestShell.cpp:

(TestShell::resetTestController): added a WebCache::clear() call to achieve the goal of the bug.

LayoutTests:

• media/video-poster-blocked-by-willsendrequest.html: updated list of still-busted ports.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/media/video-poster-blocked-by-willsendrequest.html (modified) (1 diff)
• Tools/ChangeLog (modified) (1 diff)
• Tools/DumpRenderTree/chromium/TestShell.cpp (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2012-10-31  Ami Fischman  <fischman@chromium.org>
+
+        [chromium] DRT and WTR should clear the cache between tests
+        https://bugs.webkit.org/show_bug.cgi?id=93195
+
+        Reviewed by Tony Chang.
+
+        * media/video-poster-blocked-by-willsendrequest.html: updated list of still-busted ports.
+
 2012-10-31  Stephen White  <senorblanco@chromium.org>
 

trunk/LayoutTests/media/video-poster-blocked-by-willsendrequest.html

@@ -38 +38 @@
                 testExpected("video.clientHeight", 150);
 
-                // FIXME: the getTime() below works around a bug in DRT where caches aren't cleared between tests; chromium: 93195, mac: 82976, gtk: 79760.
+                // FIXME: the getTime() below works around a bug (82976) in mac DRT where caches aren't cleared between tests.
                 video.poster = "content/abe.png?" + (new Date().getTime());
 

trunk/Tools/ChangeLog

@@ +1 @@
+2012-10-31  Ami Fischman  <fischman@chromium.org>
+
+        [chromium] DRT and WTR should clear the cache between tests
+        https://bugs.webkit.org/show_bug.cgi?id=93195
+
+        Reviewed by Tony Chang.
+
+        This change makes chromium DRT match the GTK+, Qt, and EFL ports.
+
+        * DumpRenderTree/chromium/TestShell.cpp:
+        (TestShell::resetTestController): added a WebCache::clear() call to achieve the goal of the bug.
+
 2012-10-31  Dirk Pranke  <dpranke@chromium.org>
 

trunk/Tools/DumpRenderTree/chromium/TestShell.cpp

@@ -36 +36 @@
 #include "DRTTestRunner.h"
 #include "MockWebPrerenderingSupport.h"
+#include "WebCache.h"
 #include "WebDataSource.h"
 #include "WebDocument.h"
@@ -319 +320 @@
     webView()->mainFrame()->clearOpener();
     WebTestingSupport::resetInternalsObject(webView()->mainFrame());
+    WebCache::clear();
 }