Changeset 133282 in webkit


Ignore:
Timestamp:
Nov 2, 2012 3:29:46 AM (11 years ago)
Author:
tkent@chromium.org
Message:

Add a common base class for date/time input types without inline editing behavior
https://bugs.webkit.org/show_bug.cgi?id=101031

Reviewed by Hajime Morita.

Add BaseChooserOnlyDateAndTimeInputType class, which will support
DateTimeChooserClient, and date/time input types inherit it if
!ENABLE(INPUT_MULTIPLE_FIELDS_UI).

No new tests. This doesn't change any behavior.

  • CMakeLists.txt: Add BaseChooserOnlyDateAndTimeInputType.{cpp,h}.
  • GNUmakefile.list.am: Ditto.
  • Target.pri: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • html/BaseChooserOnlyDateAndTimeInputType.cpp: Added.
  • html/BaseChooserOnlyDateAndTimeInputType.h: Added.
  • html/DateInputType.h: Inherit BaseChooserOnlyDateAndTimeInputType if

!ENABLE(INPUT_MULTIPLE_FIELDS_UI).

  • html/DateTimeInputType.h: Ditto.
  • html/DateTimeLocalInputType.h: Ditto.
  • html/MonthInputType.h: Ditto.
  • html/TimeInputType.h: Ditto.
  • html/WeekInputType.h: Ditto.
Location:
trunk/Source/WebCore
Files:
2 added
12 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/CMakeLists.txt

    r133275 r133282  
    13341334    html/BaseButtonInputType.cpp
    13351335    html/BaseCheckableInputType.cpp
     1336    html/BaseChooserOnlyDateAndTimeInputType.cpp
    13361337    html/BaseClickableWithKeyInputType.cpp
    13371338    html/BaseDateAndTimeInputType.cpp
  • trunk/Source/WebCore/ChangeLog

    r133281 r133282  
     12012-11-02  Kent Tamura  <tkent@chromium.org>
     2
     3        Add a common base class for date/time input types without inline editing behavior
     4        https://bugs.webkit.org/show_bug.cgi?id=101031
     5
     6        Reviewed by Hajime Morita.
     7
     8        Add BaseChooserOnlyDateAndTimeInputType class, which will support
     9        DateTimeChooserClient, and date/time input types inherit it if
     10        !ENABLE(INPUT_MULTIPLE_FIELDS_UI).
     11
     12        No new tests. This doesn't change any behavior.
     13
     14        * CMakeLists.txt: Add BaseChooserOnlyDateAndTimeInputType.{cpp,h}.
     15        * GNUmakefile.list.am: Ditto.
     16        * Target.pri: Ditto.
     17        * WebCore.gypi: Ditto.
     18        * WebCore.xcodeproj/project.pbxproj: Ditto.
     19        * html/BaseChooserOnlyDateAndTimeInputType.cpp: Added.
     20        * html/BaseChooserOnlyDateAndTimeInputType.h: Added.
     21
     22        * html/DateInputType.h: Inherit BaseChooserOnlyDateAndTimeInputType if
     23        !ENABLE(INPUT_MULTIPLE_FIELDS_UI).
     24        * html/DateTimeInputType.h: Ditto.
     25        * html/DateTimeLocalInputType.h: Ditto.
     26        * html/MonthInputType.h: Ditto.
     27        * html/TimeInputType.h: Ditto.
     28        * html/WeekInputType.h: Ditto.
     29
    1302012-11-02  Peter Wang  <peter.wang@torchmobile.com.cn>
    231
  • trunk/Source/WebCore/GNUmakefile.list.am

    r133275 r133282  
    31793179        Source/WebCore/html/BaseCheckableInputType.cpp \
    31803180        Source/WebCore/html/BaseCheckableInputType.h \
     3181        Source/WebCore/html/BaseChooserOnlyDateAndTimeInputType.cpp \
     3182        Source/WebCore/html/BaseChooserOnlyDateAndTimeInputType.h \
    31813183        Source/WebCore/html/BaseClickableWithKeyInputType.cpp \
    31823184        Source/WebCore/html/BaseClickableWithKeyInputType.h \
  • trunk/Source/WebCore/Target.pri

    r133275 r133282  
    561561    html/BaseButtonInputType.cpp \
    562562    html/BaseCheckableInputType.cpp \
     563    html/BaseChooserOnlyDateAndTimeInputType.cpp \
    563564    html/BaseClickableWithKeyInputType.cpp \
    564565    html/BaseDateAndTimeInputType.cpp \
  • trunk/Source/WebCore/WebCore.gypi

    r133275 r133282  
    40324032            'html/BaseCheckableInputType.cpp',
    40334033            'html/BaseCheckableInputType.h',
     4034            'html/BaseChooserOnlyDateAndTimeInputType.cpp',
     4035            'html/BaseChooserOnlyDateAndTimeInputType.h',
    40344036            'html/BaseClickableWithKeyInputType.cpp',
    40354037            'html/BaseClickableWithKeyInputType.h',
  • trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj

    r133275 r133282  
    63456345                F5C041E60FFCA96D00839D4A /* JSHTMLDataListElement.cpp in Sources */ = {isa = PBXBuildFile; fileRef = F5C041E10FFCA96D00839D4A /* JSHTMLDataListElement.cpp */; };
    63466346                F5C041E70FFCA96D00839D4A /* JSHTMLDataListElement.h in Headers */ = {isa = PBXBuildFile; fileRef = F5C041E20FFCA96D00839D4A /* JSHTMLDataListElement.h */; };
     6347                F5E0C65B1643C42C00D6CB69 /* BaseChooserOnlyDateAndTimeInputType.cpp in Sources */ = {isa = PBXBuildFile; fileRef = F5E0C6591643C42C00D6CB69 /* BaseChooserOnlyDateAndTimeInputType.cpp */; };
     6348                F5E0C65C1643C42C00D6CB69 /* BaseChooserOnlyDateAndTimeInputType.h in Headers */ = {isa = PBXBuildFile; fileRef = F5E0C65A1643C42C00D6CB69 /* BaseChooserOnlyDateAndTimeInputType.h */; };
    63476349                F7A034C4126BF6BE007DC19E /* FontOrientation.h in Headers */ = {isa = PBXBuildFile; fileRef = F7A034C3126BF6BE007DC19E /* FontOrientation.h */; settings = {ATTRIBUTES = (Private, ); }; };
    63486350                F916C48D0DB510F80076CD83 /* JSXMLHttpRequestProgressEvent.cpp in Sources */ = {isa = PBXBuildFile; fileRef = F916C48B0DB510F80076CD83 /* JSXMLHttpRequestProgressEvent.cpp */; };
     
    1380513807                F5C2869402846DCD018635CA /* Carbon.framework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.framework; name = Carbon.framework; path = /System/Library/Frameworks/Carbon.framework; sourceTree = "<absolute>"; };
    1380613808                F5C2869502846DCD018635CA /* Cocoa.framework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.framework; name = Cocoa.framework; path = /System/Library/Frameworks/Cocoa.framework; sourceTree = "<absolute>"; };
     13809                F5E0C6591643C42C00D6CB69 /* BaseChooserOnlyDateAndTimeInputType.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = BaseChooserOnlyDateAndTimeInputType.cpp; sourceTree = "<group>"; };
     13810                F5E0C65A1643C42C00D6CB69 /* BaseChooserOnlyDateAndTimeInputType.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = BaseChooserOnlyDateAndTimeInputType.h; sourceTree = "<group>"; };
    1380713811                F7A034C3126BF6BE007DC19E /* FontOrientation.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = FontOrientation.h; sourceTree = "<group>"; };
    1380813812                F8216299029F4FB501000131 /* JavaScriptCore.framework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.framework; path = JavaScriptCore.framework; sourceTree = BUILT_PRODUCTS_DIR; };
     
    1743017434                                379E61C7126CA5C300B63E8D /* BaseCheckableInputType.cpp */,
    1743117435                                379E61C8126CA5C300B63E8D /* BaseCheckableInputType.h */,
     17436                                F5E0C6591643C42C00D6CB69 /* BaseChooserOnlyDateAndTimeInputType.cpp */,
     17437                                F5E0C65A1643C42C00D6CB69 /* BaseChooserOnlyDateAndTimeInputType.h */,
    1743217438                                C33EE5C214FB49610002095A /* BaseClickableWithKeyInputType.cpp */,
    1743317439                                C33EE5C314FB49610002095A /* BaseClickableWithKeyInputType.h */,
     
    2251522521                                379E61CA126CA5C400B63E8D /* BaseButtonInputType.h in Headers */,
    2251622522                                379E61CC126CA5C400B63E8D /* BaseCheckableInputType.h in Headers */,
     22523                                F5E0C65C1643C42C00D6CB69 /* BaseChooserOnlyDateAndTimeInputType.h in Headers */,
    2251722524                                C33EE5C514FB49610002095A /* BaseClickableWithKeyInputType.h in Headers */,
    2251822525                                F59C96001255B23F000623C0 /* BaseDateAndTimeInputType.h in Headers */,
     
    2612526132                                379E61C9126CA5C300B63E8D /* BaseButtonInputType.cpp in Sources */,
    2612626133                                379E61CB126CA5C400B63E8D /* BaseCheckableInputType.cpp in Sources */,
     26134                                F5E0C65B1643C42C00D6CB69 /* BaseChooserOnlyDateAndTimeInputType.cpp in Sources */,
    2612726135                                C33EE5C414FB49610002095A /* BaseClickableWithKeyInputType.cpp in Sources */,
    2612826136                                F59C95FF1255B23F000623C0 /* BaseDateAndTimeInputType.cpp in Sources */,
  • trunk/Source/WebCore/html/DateInputType.h

    r132896 r133282  
    3333
    3434#if ENABLE(INPUT_TYPE_DATE)
     35#include "BaseChooserOnlyDateAndTimeInputType.h"
    3536#include "BaseMultipleFieldsDateAndTimeInputType.h"
    3637#include <wtf/RefPtr.h>
     
    4344typedef BaseMultipleFieldsDateAndTimeInputType BaseDateInputType;
    4445#else
    45 typedef BaseDateAndTimeInputType BaseDateInputType;
     46typedef BaseChooserOnlyDateAndTimeInputType BaseDateInputType;
    4647#endif
    4748
  • trunk/Source/WebCore/html/DateTimeInputType.h

    r131853 r133282  
    3535
    3636#if ENABLE(INPUT_TYPE_DATETIME)
     37#include "BaseChooserOnlyDateAndTimeInputType.h"
    3738#include "BaseMultipleFieldsDateAndTimeInputType.h"
    3839
     
    4243typedef BaseMultipleFieldsDateAndTimeInputType BaseDateTimeInputType;
    4344#else
    44 typedef BaseDateAndTimeInputType BaseDateTimeInputType;
     45typedef BaseChooserOnlyDateAndTimeInputType BaseDateTimeInputType;
    4546#endif
    4647
  • trunk/Source/WebCore/html/DateTimeLocalInputType.h

    r130147 r133282  
    3333
    3434#if ENABLE(INPUT_TYPE_DATETIMELOCAL)
     35#include "BaseChooserOnlyDateAndTimeInputType.h"
    3536#include "BaseMultipleFieldsDateAndTimeInputType.h"
    3637
     
    4041typedef BaseMultipleFieldsDateAndTimeInputType BaseDateTimeLocalInputType;
    4142#else
    42 typedef BaseDateAndTimeInputType BaseDateTimeLocalInputType;
     43typedef BaseChooserOnlyDateAndTimeInputType BaseDateTimeLocalInputType;
    4344#endif
    4445
  • trunk/Source/WebCore/html/MonthInputType.h

    r130005 r133282  
    3333
    3434#if ENABLE(INPUT_TYPE_MONTH)
     35#include "BaseChooserOnlyDateAndTimeInputType.h"
    3536#include "BaseMultipleFieldsDateAndTimeInputType.h"
    3637
     
    4041typedef BaseMultipleFieldsDateAndTimeInputType BaseMonthInputType;
    4142#else
    42 typedef BaseDateAndTimeInputType BaseMonthInputType;
     43typedef BaseChooserOnlyDateAndTimeInputType BaseMonthInputType;
    4344#endif
    4445
  • trunk/Source/WebCore/html/TimeInputType.h

    r130357 r133282  
    3333
    3434#if ENABLE(INPUT_TYPE_TIME)
     35#include "BaseChooserOnlyDateAndTimeInputType.h"
    3536#include "BaseMultipleFieldsDateAndTimeInputType.h"
    3637
     
    4041typedef BaseMultipleFieldsDateAndTimeInputType BaseTimeInputType;
    4142#else
    42 typedef BaseDateAndTimeInputType BaseTimeInputType;
     43typedef BaseChooserOnlyDateAndTimeInputType BaseTimeInputType;
    4344#endif
    4445
  • trunk/Source/WebCore/html/WeekInputType.h

    r130024 r133282  
    3232#define WeekInputType_h
    3333
     34#if ENABLE(INPUT_TYPE_WEEK)
     35#include "BaseChooserOnlyDateAndTimeInputType.h"
    3436#include "BaseMultipleFieldsDateAndTimeInputType.h"
    35 
    36 #if ENABLE(INPUT_TYPE_WEEK)
    3737
    3838namespace WebCore {
     
    4141typedef BaseMultipleFieldsDateAndTimeInputType BaseWeekInputType;
    4242#else
    43 typedef BaseDateAndTimeInputType BaseWeekInputType;
     43typedef BaseChooserOnlyDateAndTimeInputType BaseWeekInputType;
    4444#endif
    4545
Note: See TracChangeset for help on using the changeset viewer.