Changeset 133793 in webkit

Timestamp:

Nov 7, 2012 12:35:27 PM (11 years ago)

Author:

commit-queue@webkit.org

Message:

Function adoptNS and adoptCF should not generate memory leak diagnostic with Clang Static Analyzer.
​https://bugs.webkit.org/show_bug.cgi?id=101420

Patch by Remy Demarest <​rdemarest@apple.com> on 2012-11-07
Reviewed by Benjamin Poulain.

Add attributes to the adoptNS and adoptCF function arguments to remove Clang Static Analyzer diagnotics.
Define CF_RELEASES_ARGUMENT and NS_RELEASES_ARGUMENT if not available, use them in function declarations.

• wtf/RetainPtr.h:

(WTF::adoptCF): Adds CF_RELEASES_ARGUMENT attribute to the argument.
(WTF::adoptNS): Adds NS_RELEASES_ARGUMENT attribute to the argument.

Location:

trunk/Source/WTF

Files:

• ChangeLog (modified) (1 diff)
• wtf/RetainPtr.h (modified) (3 diffs)

trunk/Source/WTF/ChangeLog

@@ +1 @@
+2012-11-07  Remy Demarest  <rdemarest@apple.com>
+
+        Function adoptNS and adoptCF should not generate memory leak diagnostic with Clang Static Analyzer.
+        https://bugs.webkit.org/show_bug.cgi?id=101420
+
+        Reviewed by Benjamin Poulain.
+
+        Add attributes to the adoptNS and adoptCF function arguments to remove Clang Static Analyzer diagnotics.
+        Define CF_RELEASES_ARGUMENT and NS_RELEASES_ARGUMENT if not available, use them in function declarations.
+
+        * wtf/RetainPtr.h:
+        (WTF::adoptCF): Adds CF_RELEASES_ARGUMENT attribute to the argument.
+        (WTF::adoptNS): Adds NS_RELEASES_ARGUMENT attribute to the argument.
+
 2012-11-07  Christophe Dumez  <christophe.dumez@intel.com>
 

trunk/Source/WTF/wtf/RetainPtr.h

@@ -35 +35 @@
 #endif
 
+#ifndef CF_RELEASES_ARGUMENT
+#define CF_RELEASES_ARGUMENT
+#endif
+
+#ifndef NS_RELEASES_ARGUMENT
+#define NS_RELEASES_ARGUMENT
+#endif
+
 namespace WTF {
 
@@ -258 +266 @@
     }
 
-    template<typename T> inline RetainPtr<T> adoptCF(T) WARN_UNUSED_RETURN;
+    template<typename T> inline RetainPtr<T> adoptCF(T CF_RELEASES_ARGUMENT) WARN_UNUSED_RETURN;
     template<typename T> inline RetainPtr<T> adoptCF(T o)
     {
@@ -264 +272 @@
     }
 
-    template<typename T> inline RetainPtr<T> adoptNS(T) WARN_UNUSED_RETURN;
+    template<typename T> inline RetainPtr<T> adoptNS(T NS_RELEASES_ARGUMENT) WARN_UNUSED_RETURN;
     template<typename T> inline RetainPtr<T> adoptNS(T o)
     {