Changeset 133860 in webkit

Timestamp:

Nov 8, 2012 12:17:50 AM (11 years ago)

Author:

commit-queue@webkit.org

Message:

User can change a disabled select (drop down box)
​https://bugs.webkit.org/show_bug.cgi?id=100932

Patch by Kunihiko Sakamoto <​ksakamoto@chromium.org> on 2012-11-08
Reviewed by Kent Tamura.

Source/WebCore:

<select> should not handle events if it's disabled.

Test: fast/forms/select/select-disabled.html

• html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::defaultEventHandler):

LayoutTests:

Verify that keyboard events do not change value of disabled select.

• fast/forms/select/select-disabled-expected.txt: Added.
• fast/forms/select/select-disabled.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/forms/select/select-disabled-expected.txt (added)
• LayoutTests/fast/forms/select/select-disabled.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/html/HTMLSelectElement.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2012-11-08  Kunihiko Sakamoto  <ksakamoto@chromium.org>
+
+        User can change a disabled select (drop down box)
+        https://bugs.webkit.org/show_bug.cgi?id=100932
+
+        Reviewed by Kent Tamura.
+
+        Verify that keyboard events do not change value of disabled select.
+
+        * fast/forms/select/select-disabled-expected.txt: Added.
+        * fast/forms/select/select-disabled.html: Added.
+
 2012-11-07  Vsevolod Vlasov  <vsevik@chromium.org>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-11-08  Kunihiko Sakamoto  <ksakamoto@chromium.org>
+
+        User can change a disabled select (drop down box)
+        https://bugs.webkit.org/show_bug.cgi?id=100932
+
+        Reviewed by Kent Tamura.
+
+        <select> should not handle events if it's disabled.
+
+        Test: fast/forms/select/select-disabled.html
+
+        * html/HTMLSelectElement.cpp:
+        (WebCore::HTMLSelectElement::defaultEventHandler):
+
 2012-11-08  Alec Flett  <alecflett@chromium.org>
 

trunk/Source/WebCore/html/HTMLSelectElement.cpp

@@ -1441 +1441 @@
         return;
 
+    if (disabled()) {
+        HTMLFormControlElementWithState::defaultEventHandler(event);
+        return;
+    }
+
     if (usesMenuList())
         menuListDefaultEventHandler(event);