Changeset 133998 in webkit


Ignore:
Timestamp:
Nov 8, 2012 7:51:34 PM (11 years ago)
Author:
keishi@webkit.org
Message:

Enable calendar picker for input types week/month
​https://bugs.webkit.org/show_bug.cgi?id=101553

Reviewed by Kent Tamura.

Source/WebCore:

Enabling calendar picker for <input type=week/month>

No new tests. Tests will be added later in Bug 101556 and Bug 101555.

  • rendering/RenderThemeChromiumCommon.cpp:

(WebCore::RenderThemeChromiumCommon::supportsCalendarPicker):

LayoutTests:

  • platform/chromium/TestExpectations: Mark week/month appearance tests as needs rebaseline.
Location:
trunk
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r133996 r133998  
     12012-11-08  Keishi Hattori  <keishi@webkit.org>
     2
     3        Enable calendar picker for input types week/month
     4        https://bugs.webkit.org/show_bug.cgi?id=101553
     5
     6        Reviewed by Kent Tamura.
     7
     8        * platform/chromium/TestExpectations: Mark week/month appearance tests as needs rebaseline.
     9
    1102012-11-08  Hayato Ito  <hayato@chromium.org>
    211

  • trunk/LayoutTests/platform/chromium/TestExpectations

    r133996 r133998  
    35993599webkit.org/b/91445 [ Linux ] plugins/embed-attributes-style.html [ ImageOnlyFailure Pass ]
    36003600
     3601# Needs rebaseline
     3602webkit.org/b/101561 fast/forms/month/month-appearance-basic.html [ ImageOnlyFailure Pass ]
     3603webkit.org/b/101561 fast/forms/month/month-appearance-l10n.html [ ImageOnlyFailure Pass ]
     3604webkit.org/b/101561 fast/forms/month/month-appearance-pseudo-classes.html [ ImageOnlyFailure Pass ]
     3605webkit.org/b/101561 fast/forms/month/month-appearance-pseudo-elements.html [ ImageOnlyFailure Pass ]
     3606webkit.org/b/101561 fast/forms/month/month-appearance-style.html [ ImageOnlyFailure Pass ]
     3607webkit.org/b/101561 fast/forms/week/week-appearance-basic.html [ ImageOnlyFailure Pass ]
     3608webkit.org/b/101561 fast/forms/week/week-appearance-pseudo-classes.html [ ImageOnlyFailure Pass ]
     3609webkit.org/b/101561 fast/forms/week/week-appearance-pseudo-elements.html [ ImageOnlyFailure Pass ]
     3610webkit.org/b/101561 fast/forms/week/week-appearance-style.html [ ImageOnlyFailure Pass ]
     3611
    36013612# Needs rebaseline after bug 97217 is fixed
    36023613webkit.org/b/97325 css3/masking/clip-path-circle-relative-overflow.html [ ImageOnlyFailure Pass ]

  • trunk/Source/WebCore/ChangeLog

    r133997 r133998  
     12012-11-08  Keishi Hattori  <keishi@webkit.org>
     2
     3        Enable calendar picker for input types week/month
     4        https://bugs.webkit.org/show_bug.cgi?id=101553
     5
     6        Reviewed by Kent Tamura.
     7
     8        Enabling calendar picker for <input type=week/month>
     9
     10        No new tests. Tests will be added later in Bug 101556 and Bug 101555.
     11
     12        * rendering/RenderThemeChromiumCommon.cpp:
     13        (WebCore::RenderThemeChromiumCommon::supportsCalendarPicker):
     14
    1152012-11-08  Robin Cao  <robin.cao@torchmobile.com.cn>
    216

  • trunk/Source/WebCore/rendering/RenderThemeChromiumCommon.cpp

    r133779 r133998  
    5050bool RenderThemeChromiumCommon::supportsCalendarPicker(const AtomicString& type)
    5151{
    52     // FIXME: We'd like to support datetime, datetime-local, month, and week too.
    53     return type == InputTypeNames::date();
     52    // FIXME: We'd like to support datetime, and datetime-local too.
     53    return type == InputTypeNames::date()
     54        || type == InputTypeNames::month()
     55        || type == InputTypeNames::week();
    5456}
    5557#endif
Note: See TracChangeset for help on using the changeset viewer.