Changeset 134057 in webkit

Timestamp:

Nov 9, 2012 6:03:14 AM (11 years ago)

Author:

commit-queue@webkit.org

Message:

[EFL] Enable -Werror for the EFL port
​https://bugs.webkit.org/show_bug.cgi?id=98715

Patch by Laszlo Gombos <​l.gombos@samsung.com> on 2012-11-09
Reviewed by Gyuyoung Kim.

Treat all warnings as errors, except the existing warnings in the
current code base ("unused-parameter", "sign-compare" and "switch").

Thanks for Raphael Kubo da Costa for the extra help.

• Source/CMakeLists.txt: Enable warnings as error for all libraries

(except WebKit and WebKit2) for the EFL port.
Other cmake-based ports are welcome to join.

• Source/cmake/WebKitHelpers.cmake: Treat warnings as errors by

default for cmake-based ports when ENABLE_WERROR is set.

Location:

trunk

Files:

• ChangeLog (modified) (1 diff)
• Source/CMakeLists.txt (modified) (1 diff)
• Source/cmake/WebKitHelpers.cmake (modified) (2 diffs)

trunk/ChangeLog

@@ +1 @@
+2012-11-09  Laszlo Gombos  <l.gombos@samsung.com>
+
+        [EFL] Enable -Werror for the EFL port
+        https://bugs.webkit.org/show_bug.cgi?id=98715
+
+        Reviewed by Gyuyoung Kim.
+
+        Treat all warnings as errors, except the existing warnings in the
+        current code base ("unused-parameter", "sign-compare" and "switch").
+
+        Thanks for Raphael Kubo da Costa for the extra help.      
+
+        * Source/CMakeLists.txt: Enable warnings as error for all libraries
+        (except WebKit and WebKit2) for the EFL port. 
+        Other cmake-based ports are welcome to join.
+
+        * Source/cmake/WebKitHelpers.cmake: Treat warnings as errors by
+        default for cmake-based ports when ENABLE_WERROR is set.
+
 2012-11-08  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
 

trunk/Source/CMakeLists.txt

@@ -27 +27 @@
 # Set compiler flags for all targets
 # -----------------------------------------------------------------------------
-WEBKIT_SET_EXTRA_COMPILER_FLAGS(${WTF_LIBRARY_NAME})
-WEBKIT_SET_EXTRA_COMPILER_FLAGS(${JavaScriptCore_LIBRARY_NAME})
-WEBKIT_SET_EXTRA_COMPILER_FLAGS(${WebCoreTestSupport_LIBRARY_NAME})
+IF (${PORT} STREQUAL "Efl")
+    SET(ADDITIONAL_FLAGS ENABLE_WERROR)
+ENDIF ()
+
+WEBKIT_SET_EXTRA_COMPILER_FLAGS(${WTF_LIBRARY_NAME} ${ADDITIONAL_FLAGS})
+WEBKIT_SET_EXTRA_COMPILER_FLAGS(${JavaScriptCore_LIBRARY_NAME} ${ADDITIONAL_FLAGS})
+WEBKIT_SET_EXTRA_COMPILER_FLAGS(${WebCoreTestSupport_LIBRARY_NAME} ${ADDITIONAL_FLAGS})
 
 IF (ENABLE_WEBCORE)
-    WEBKIT_SET_EXTRA_COMPILER_FLAGS(${WebCore_LIBRARY_NAME})
+    WEBKIT_SET_EXTRA_COMPILER_FLAGS(${WebCore_LIBRARY_NAME} ${ADDITIONAL_FLAGS})
 ENDIF ()
 

trunk/Source/cmake/WebKitHelpers.cmake

@@ -3 +3 @@
 # Currently, only GCC is supported.
 MACRO(WEBKIT_SET_EXTRA_COMPILER_FLAGS _target)
-  SET(options IGNORECXX_WARNINGS)
-  CMAKE_PARSE_ARGUMENTS("OPTION" "IGNORECXX_WARNINGS" "" "" ${ARGN})
+  SET(options ENABLE_WERROR IGNORECXX_WARNINGS)
+  CMAKE_PARSE_ARGUMENTS("OPTION" "${options}" "" "" ${ARGN})
   IF (CMAKE_COMPILER_IS_GNUCXX OR "${CMAKE_CXX_COMPILER_ID}" STREQUAL "Clang")
     GET_TARGET_PROPERTY(OLD_COMPILE_FLAGS ${_target} COMPILE_FLAGS)
@@ -38 +38 @@
     # Enable warnings by default
     IF (NOT ${OPTION_IGNORECXX_WARNINGS})
-        SET(OLD_COMPILE_FLAGS "-DANOTHER_BRICK_IN_THE -Wall -Wextra -Wcast-align -Wformat-security -Wmissing-format-attribute -Wpointer-arith -Wundef -Wwrite-strings ${OLD_COMPILE_FLAGS}")
+        SET(OLD_COMPILE_FLAGS "-Wall -Wextra -Wcast-align -Wformat-security -Wmissing-format-attribute -Wpointer-arith -Wundef -Wwrite-strings ${OLD_COMPILE_FLAGS}")
+    ENDIF ()
+
+    # Enable errors on warning
+    IF (OPTION_ENABLE_WERROR)
+        SET(OLD_COMPILE_FLAGS "${OLD_COMPILE_FLAGS} -Werror -Wno-error=unused-parameter -Wno-error=sign-compare -Wno-error=switch")
     ENDIF ()