Changeset 134093 in webkit

Timestamp:

Nov 9, 2012 11:39:01 AM (11 years ago)

Author:

tommyw@google.com

Message:

MediaStream API: Don't trigger any object deletion during RTCPeerConnection::stop
​https://bugs.webkit.org/show_bug.cgi?id=101586

Reviewed by Adam Barth.

Stop calling stop on the RTCPeerConnectionHandler, and don't delete it, when
ActiveDOMObject::stop is called on RTCPeerConnection. Due to the async nature of the new
API some WebCore objects might be cleaned away which is not allowed at this stage.

This behaviour is not possible to test unfortunately in webkit.

• Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::stop):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• Modules/mediastream/RTCPeerConnection.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-11-09  Tommy Widenflycht  <tommyw@google.com>
+
+        MediaStream API: Don't trigger any object deletion during RTCPeerConnection::stop
+        https://bugs.webkit.org/show_bug.cgi?id=101586
+
+        Reviewed by Adam Barth.
+
+        Stop calling stop on the RTCPeerConnectionHandler, and don't delete it, when
+        ActiveDOMObject::stop is called on RTCPeerConnection. Due to the async nature of the new
+        API some WebCore objects might be cleaned away which is not allowed at this stage.
+
+        This behaviour is not possible to test unfortunately in webkit.
+
+        * Modules/mediastream/RTCPeerConnection.cpp:
+        (WebCore::RTCPeerConnection::stop):
+
 2012-11-09  Joshua Bell  <jsbell@chromium.org>
 

trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp

@@ -524 +524 @@
 void RTCPeerConnection::stop()
 {
-    if (m_readyState != ReadyStateClosed)
-        m_peerHandler->stop();
-
-    m_peerHandler.clear();
-
     m_iceState = IceStateClosed;
     m_readyState = ReadyStateClosed;